New issue
Advanced search Search tips

Issue 880195 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 879662



Sign in to add a comment

Need a layer performance test with viewport constrained layers.

Project Member Reported by vmi...@chromium.org, Sep 4

Issue description

If a root layer has viewport constrained objects, this triggers a full
compositing inputs update when scrolling.

The rendering.mobile/google_web_search_mobile_2018 is such a page.

We should add a case with high number of layers in "tough_compositing_cases" to monitor this.
 
Blocking: 879662
Cc: flackr@chromium.org
Status: Started (was: Available)
I'm in the process of adding these tests here: http://crrev.com/c/1252634

The screenshot shows the difference in thread times on Nexus 4 with and without
a fixed position element on top.
root_scroller_plus_sticky.png
144 KB View Download
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/11ee84bf640000
Owner: vmi...@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4453a95e9b19f2c70818f229d3e1c4f00512fc8

commit e4453a95e9b19f2c70818f229d3e1c4f00512fc8
Author: Victor Miura <vmiura@chromium.org>
Date: Wed Oct 03 04:00:55 2018

Add layer performance tests with viewport constrained layers.

Adds stories for root scroller cases, with a "position:fixed" element
on top.

BUG= 880195 

Change-Id: I3b293a1818225aca5807adc60f5db3954d61eb95
Reviewed-on: https://chromium-review.googlesource.com/c/1252634
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596117}
[add] https://crrev.com/e4453a95e9b19f2c70818f229d3e1c4f00512fc8/chrome/test/data/perf/tough_compositor_cases/infinite_scroll_root_fixed_n_layers.html
[modify] https://crrev.com/e4453a95e9b19f2c70818f229d3e1c4f00512fc8/tools/perf/page_sets/rendering/tough_compositor_cases.py

Status: Fixed (was: Started)

Sign in to add a comment