New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 880176 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Mac
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: inline_text_box_.Start() + length <= first_line_string.length() in inline_text_b

Project Member Reported by ClusterFuzz, Sep 4

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5473332171112448

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  inline_text_box_.Start() + length <= first_line_string.length() in inline_text_b
  blink::InlineTextBoxPainter::Paint
  blink::InlineTextBox::Paint
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=535606:535607

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5473332171112448

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Sep 4

Components: Blink>Layout Blink>Paint
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Sep 4

Labels: Test-Predator-Auto-Owner
Owner: chrishtr@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/3ee8649cef061b5016288b3f49f6e72288caf582 (Revert "Revert "Work around bug leading to out of range check when transforming first-line text."").

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by ClusterFuzz, Sep 4

Labels: OS-Mac
Components: -Blink>Paint
Owner: ----
Status: Untriaged (was: Assigned)
Cc: kkaluri@chromium.org
Labels: Test-Predator-Wrong-CLs M-69
Owner: yoichio@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.

Using Code Search for the file, "inline_text_box_painter.cc" suspecting the below Cl might have caused this issue

Suspect CL: https://chromium.googlesource.com/chromium/src/+/63eea6e3aa8520b01b08e170c171691518bfef4d

yoichio@ -- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!
Status: Started (was: Assigned)
Confirmed.
Labels: Needs-Bisect
Owner: ----
Status: (was: Started)
I confirmed the crash but the case doesn't relate to my change.
Could you bisect?
Cc: manoranj...@chromium.org
manoranjanr@ Could you please look into this issue.
Status: Unconfirmed
Project Member

Comment 10 by ClusterFuzz, Sep 7

Labels: OS-Android
Owner: kojii@chromium.org
Status: Assigned (was: Unconfirmed)
Would you mind looking into this kojii?
Cc: szager@chromium.org
The CHECK was added in issue 722873.
Oh, but then the code was branched for first-line and the CHECK was copied to the first-line code path. Maybe not the original cause but due to first-line.
Yeah, the problem is in the first-line code, sorry for the noise.
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7659161bf6a183c356ad79a45993cc7e9971cb6

commit d7659161bf6a183c356ad79a45993cc7e9971cb6
Author: Koji Ishii <kojii@chromium.org>
Date: Tue Sep 11 03:51:56 2018

Fix first-line text-transform workaround when start is not zero

r526281 added a workaround for when text-transform shorten
the string, but did so only for when inline_text_box_.Start()
is zero.

This patch extends the workaround for when inline_text_box_.
Start() is not zero.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib4536ae5aaf92352e41ef19e53c2046a4c86806c
Bug:  880176 ,  795498 
Reviewed-on: https://chromium-review.googlesource.com/1218202
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590194}
[modify] https://crrev.com/d7659161bf6a183c356ad79a45993cc7e9971cb6/third_party/WebKit/LayoutTests/fast/text/firstline/capitalize-transform.html
[modify] https://crrev.com/d7659161bf6a183c356ad79a45993cc7e9971cb6/third_party/blink/renderer/core/paint/inline_text_box_painter.cc

Project Member

Comment 16 by ClusterFuzz, Sep 11

ClusterFuzz has detected this issue as fixed in range 590193:590194.

Detailed report: https://clusterfuzz.com/testcase?key=5473332171112448

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  inline_text_box_.Start() + length <= first_line_string.length() in inline_text_b
  blink::InlineTextBoxPainter::Paint
  blink::InlineTextBox::Paint
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=535606:535607
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=590193:590194

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5473332171112448

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Status: Fixed (was: Assigned)
Project Member

Comment 18 by ClusterFuzz, Sep 11

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5473332171112448 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment