New issue
Advanced search Search tips

Issue 880169 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 11
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Float-cast-overflow in blink::ShapeResultBuffer::IndividualCharacterAdvances

Project Member Reported by ClusterFuzz, Sep 4

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5955757661749248

Fuzzer: inferno_twister_c
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Float-cast-overflow
Crash Address: 
Crash State:
  blink::ShapeResultBuffer::IndividualCharacterAdvances
  blink::CachingWordShaper::IndividualCharacterAdvances
  blink::Font::IndividualCharacterAdvances
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=583777:583778

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5955757661749248

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Sep 4

Components: Platform
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Sep 4

Labels: Test-Predator-Auto-Owner
Owner: davidqu@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/3c61aca7b5c67ebdee22f5e146f215d724249fae (Separate TextMetrics advances from CharacterRanges (ligatures fixed).).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5b5efa7c13fc585c98406e333df1a2c61721938

commit e5b5efa7c13fc585c98406e333df1a2c61721938
Author: David Quiroz Marin <davidqu@chromium.org>
Date: Mon Sep 10 19:03:32 2018

Fix float-cast-overflow in IndividualCharacterAdvances

Advances should be store as doubles, but the previous code
was using a float as a part of their computation.

Bug:  880169 
Change-Id: I47fd70bf947c9b1e0fdb827eba69108bd938a72a
Reviewed-on: https://chromium-review.googlesource.com/1213516
Reviewed-by: Stephen White <senorblanco@chromium.org>
Commit-Queue: David Quiroz Marin <davidqu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590010}
[modify] https://crrev.com/e5b5efa7c13fc585c98406e333df1a2c61721938/third_party/blink/renderer/platform/fonts/shaping/shape_result_buffer.cc
[modify] https://crrev.com/e5b5efa7c13fc585c98406e333df1a2c61721938/third_party/blink/renderer/platform/fonts/shaping/shape_result_buffer.h

Project Member

Comment 4 by ClusterFuzz, Sep 11

ClusterFuzz has detected this issue as fixed in range 590008:590010.

Detailed report: https://clusterfuzz.com/testcase?key=5955757661749248

Fuzzer: inferno_twister_c
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Float-cast-overflow
Crash Address: 
Crash State:
  blink::ShapeResultBuffer::IndividualCharacterAdvances
  blink::CachingWordShaper::IndividualCharacterAdvances
  blink::Font::IndividualCharacterAdvances
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=583777:583778
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=590008:590010

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5955757661749248

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Sep 11

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5955757661749248 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment