Can't tell progress of crostini shutdown |
||||
Issue descriptionChrome Version: 70.0.3532.8 OS: Chrome What steps will reproduce the problem? (1) Run terminal (2) Shut down Linux in app launcher (3) Try to run terminal again. What is the expected result? Ideally, there would be some indication that Linux is shutting down somewhere. Failing that, the normal spinner over the terminal icon should be shown (to cover both the shutdown and the startup of Linux). What happens instead? There is no progress indicator, but the terminal starts eventually.
,
Sep 4
,
Sep 7
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/799e7f9f1c40439ed33c66f4a4e3adc20d452345 commit 799e7f9f1c40439ed33c66f4a4e3adc20d452345 Author: Josh Pratt <jopra@chromium.org> Date: Fri Sep 07 06:50:43 2018 Track Vm state while 'running' (starting, started, stopping) This allows CrostiniManager to handle states where a VM hasn't finished starting/stopping fully. BUG= 880165 Change-Id: Ia94bf4059c4bfbf41c3fe920873fa7c8bc2aea18 Reviewed-on: https://chromium-review.googlesource.com/1212206 Reviewed-by: Nicholas Verne <nverne@chromium.org> Commit-Queue: Josh Pratt <jopra@chromium.org> Cr-Commit-Position: refs/heads/master@{#589449} [modify] https://crrev.com/799e7f9f1c40439ed33c66f4a4e3adc20d452345/chrome/browser/chromeos/crostini/crostini_manager.cc [modify] https://crrev.com/799e7f9f1c40439ed33c66f4a4e3adc20d452345/chrome/browser/chromeos/crostini/crostini_manager.h
,
Sep 10
The above CL ensures that the spinner shows when the VM is starting (after 400+ms). It does not show if the VM is only shutting down (as this would look the same as a VM starting). I believe this resolves this bug, if the shutting down state still needs to be surfaced (separately) it can be addressed in a new bug.
,
Sep 10
Thanks team! |
||||
►
Sign in to add a comment |
||||
Comment 1 by nverne@chromium.org
, Sep 4I was able to repro on my eve. Technically, the problem is that CrostiniManager currently doesn't track states like {STARTING, RUNNING, STOPPING} for vms. We need to keep track of this if we want to display UI like spinners when stopping, then awaiting restart of a VM.