Update the FIlesApp folder_shortcut.js tests |
|||||
Issue descriptionFolderShortcut FilesApp tests need a few comments to describe what the test steps do, updates to let / const, and more speed if possible [1]. The addRemoveFolderShortcuts test, for example, opens two windows and does stuff, but is border-line on the ASAN bot (the test-time is near the ASAN bot time-out limit) leading to TIMEOUT PASS flakes. The flakes seems to depend on bot load (viz., what other tests are running on the bot at the time). If the test flakes, it is retried at the end of the browser test run, and it always passes, ie., when there are few or no other tests running on the bot.
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 commit c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:09:18 2018 Modernize folder_shortcuts.js traverseFolderShortcuts test Use SetupAndWaitUntilReady(). Add comments describing each test step. Test: browser_tests --gtest_filter="*traverseFolderShortcuts" Bug: 880127 Change-Id: Icd425052e9acc9f2086a6c0b97ebca6b643ef473 Reviewed-on: https://chromium-review.googlesource.com/1201653 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588445} [modify] https://crrev.com/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 commit c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:09:18 2018 Modernize folder_shortcuts.js traverseFolderShortcuts test Use SetupAndWaitUntilReady(). Add comments describing each test step. Test: browser_tests --gtest_filter="*traverseFolderShortcuts" Bug: 880127 Change-Id: Icd425052e9acc9f2086a6c0b97ebca6b643ef473 Reviewed-on: https://chromium-review.googlesource.com/1201653 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588445} [modify] https://crrev.com/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 commit c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:09:18 2018 Modernize folder_shortcuts.js traverseFolderShortcuts test Use SetupAndWaitUntilReady(). Add comments describing each test step. Test: browser_tests --gtest_filter="*traverseFolderShortcuts" Bug: 880127 Change-Id: Icd425052e9acc9f2086a6c0b97ebca6b643ef473 Reviewed-on: https://chromium-review.googlesource.com/1201653 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588445} [modify] https://crrev.com/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 commit c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:09:18 2018 Modernize folder_shortcuts.js traverseFolderShortcuts test Use SetupAndWaitUntilReady(). Add comments describing each test step. Test: browser_tests --gtest_filter="*traverseFolderShortcuts" Bug: 880127 Change-Id: Icd425052e9acc9f2086a6c0b97ebca6b643ef473 Reviewed-on: https://chromium-review.googlesource.com/1201653 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588445} [modify] https://crrev.com/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 commit c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:09:18 2018 Modernize folder_shortcuts.js traverseFolderShortcuts test Use SetupAndWaitUntilReady(). Add comments describing each test step. Test: browser_tests --gtest_filter="*traverseFolderShortcuts" Bug: 880127 Change-Id: Icd425052e9acc9f2086a6c0b97ebca6b643ef473 Reviewed-on: https://chromium-review.googlesource.com/1201653 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588445} [modify] https://crrev.com/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 commit c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:09:18 2018 Modernize folder_shortcuts.js traverseFolderShortcuts test Use SetupAndWaitUntilReady(). Add comments describing each test step. Test: browser_tests --gtest_filter="*traverseFolderShortcuts" Bug: 880127 Change-Id: Icd425052e9acc9f2086a6c0b97ebca6b643ef473 Reviewed-on: https://chromium-review.googlesource.com/1201653 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588445} [modify] https://crrev.com/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79cb7a58544709d400353378b1758cbb33c16223 commit 79cb7a58544709d400353378b1758cbb33c16223 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:56:23 2018 file_shortcuts.js test: move constants into their helper routines Move directory tree expansion / icon constants into their helpers (the only place they are used). Minor comment clean-ups. Test: browser_tests --gtest_filter="FolderShortcuts/FilesApp*" Bug: 880127 Change-Id: I466ab7f59042801c170192b2ae5a5b132d3e26bf Reviewed-on: https://chromium-review.googlesource.com/1201655 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588446} [modify] https://crrev.com/79cb7a58544709d400353378b1758cbb33c16223/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 commit c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:09:18 2018 Modernize folder_shortcuts.js traverseFolderShortcuts test Use SetupAndWaitUntilReady(). Add comments describing each test step. Test: browser_tests --gtest_filter="*traverseFolderShortcuts" Bug: 880127 Change-Id: Icd425052e9acc9f2086a6c0b97ebca6b643ef473 Reviewed-on: https://chromium-review.googlesource.com/1201653 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588445} [modify] https://crrev.com/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79cb7a58544709d400353378b1758cbb33c16223 commit 79cb7a58544709d400353378b1758cbb33c16223 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:56:23 2018 file_shortcuts.js test: move constants into their helper routines Move directory tree expansion / icon constants into their helpers (the only place they are used). Minor comment clean-ups. Test: browser_tests --gtest_filter="FolderShortcuts/FilesApp*" Bug: 880127 Change-Id: I466ab7f59042801c170192b2ae5a5b132d3e26bf Reviewed-on: https://chromium-review.googlesource.com/1201655 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588446} [modify] https://crrev.com/79cb7a58544709d400353378b1758cbb33c16223/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8ddae9684a1074275f789cced663fc582565569 commit c8ddae9684a1074275f789cced663fc582565569 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 03:00:06 2018 Modernize folder_shortcuts.js addRemoveFolderShortcuts test Make a local helper to open FilesApp on Drive. Document the test steps to explain the intent of the test. Test: browser_tests --gtest_filter="*addRemoveFolderShortcuts" Bug: 880127 Change-Id: I4c31539bf518e59376602308208ba0bb7a854c70 Reviewed-on: https://chromium-review.googlesource.com/1201654 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588447} [modify] https://crrev.com/c8ddae9684a1074275f789cced663fc582565569/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 commit c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:09:18 2018 Modernize folder_shortcuts.js traverseFolderShortcuts test Use SetupAndWaitUntilReady(). Add comments describing each test step. Test: browser_tests --gtest_filter="*traverseFolderShortcuts" Bug: 880127 Change-Id: Icd425052e9acc9f2086a6c0b97ebca6b643ef473 Reviewed-on: https://chromium-review.googlesource.com/1201653 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588445} [modify] https://crrev.com/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79cb7a58544709d400353378b1758cbb33c16223 commit 79cb7a58544709d400353378b1758cbb33c16223 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:56:23 2018 file_shortcuts.js test: move constants into their helper routines Move directory tree expansion / icon constants into their helpers (the only place they are used). Minor comment clean-ups. Test: browser_tests --gtest_filter="FolderShortcuts/FilesApp*" Bug: 880127 Change-Id: I466ab7f59042801c170192b2ae5a5b132d3e26bf Reviewed-on: https://chromium-review.googlesource.com/1201655 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588446} [modify] https://crrev.com/79cb7a58544709d400353378b1758cbb33c16223/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 commit c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:09:18 2018 Modernize folder_shortcuts.js traverseFolderShortcuts test Use SetupAndWaitUntilReady(). Add comments describing each test step. Test: browser_tests --gtest_filter="*traverseFolderShortcuts" Bug: 880127 Change-Id: Icd425052e9acc9f2086a6c0b97ebca6b643ef473 Reviewed-on: https://chromium-review.googlesource.com/1201653 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588445} [modify] https://crrev.com/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8ddae9684a1074275f789cced663fc582565569 commit c8ddae9684a1074275f789cced663fc582565569 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 03:00:06 2018 Modernize folder_shortcuts.js addRemoveFolderShortcuts test Make a local helper to open FilesApp on Drive. Document the test steps to explain the intent of the test. Test: browser_tests --gtest_filter="*addRemoveFolderShortcuts" Bug: 880127 Change-Id: I4c31539bf518e59376602308208ba0bb7a854c70 Reviewed-on: https://chromium-review.googlesource.com/1201654 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588447} [modify] https://crrev.com/c8ddae9684a1074275f789cced663fc582565569/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79cb7a58544709d400353378b1758cbb33c16223 commit 79cb7a58544709d400353378b1758cbb33c16223 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:56:23 2018 file_shortcuts.js test: move constants into their helper routines Move directory tree expansion / icon constants into their helpers (the only place they are used). Minor comment clean-ups. Test: browser_tests --gtest_filter="FolderShortcuts/FilesApp*" Bug: 880127 Change-Id: I466ab7f59042801c170192b2ae5a5b132d3e26bf Reviewed-on: https://chromium-review.googlesource.com/1201655 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588446} [modify] https://crrev.com/79cb7a58544709d400353378b1758cbb33c16223/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8ddae9684a1074275f789cced663fc582565569 commit c8ddae9684a1074275f789cced663fc582565569 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 03:00:06 2018 Modernize folder_shortcuts.js addRemoveFolderShortcuts test Make a local helper to open FilesApp on Drive. Document the test steps to explain the intent of the test. Test: browser_tests --gtest_filter="*addRemoveFolderShortcuts" Bug: 880127 Change-Id: I4c31539bf518e59376602308208ba0bb7a854c70 Reviewed-on: https://chromium-review.googlesource.com/1201654 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588447} [modify] https://crrev.com/c8ddae9684a1074275f789cced663fc582565569/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 commit c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:09:18 2018 Modernize folder_shortcuts.js traverseFolderShortcuts test Use SetupAndWaitUntilReady(). Add comments describing each test step. Test: browser_tests --gtest_filter="*traverseFolderShortcuts" Bug: 880127 Change-Id: Icd425052e9acc9f2086a6c0b97ebca6b643ef473 Reviewed-on: https://chromium-review.googlesource.com/1201653 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588445} [modify] https://crrev.com/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79cb7a58544709d400353378b1758cbb33c16223 commit 79cb7a58544709d400353378b1758cbb33c16223 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:56:23 2018 file_shortcuts.js test: move constants into their helper routines Move directory tree expansion / icon constants into their helpers (the only place they are used). Minor comment clean-ups. Test: browser_tests --gtest_filter="FolderShortcuts/FilesApp*" Bug: 880127 Change-Id: I466ab7f59042801c170192b2ae5a5b132d3e26bf Reviewed-on: https://chromium-review.googlesource.com/1201655 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588446} [modify] https://crrev.com/79cb7a58544709d400353378b1758cbb33c16223/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8ddae9684a1074275f789cced663fc582565569 commit c8ddae9684a1074275f789cced663fc582565569 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 03:00:06 2018 Modernize folder_shortcuts.js addRemoveFolderShortcuts test Make a local helper to open FilesApp on Drive. Document the test steps to explain the intent of the test. Test: browser_tests --gtest_filter="*addRemoveFolderShortcuts" Bug: 880127 Change-Id: I4c31539bf518e59376602308208ba0bb7a854c70 Reviewed-on: https://chromium-review.googlesource.com/1201654 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588447} [modify] https://crrev.com/c8ddae9684a1074275f789cced663fc582565569/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 commit c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:09:18 2018 Modernize folder_shortcuts.js traverseFolderShortcuts test Use SetupAndWaitUntilReady(). Add comments describing each test step. Test: browser_tests --gtest_filter="*traverseFolderShortcuts" Bug: 880127 Change-Id: Icd425052e9acc9f2086a6c0b97ebca6b643ef473 Reviewed-on: https://chromium-review.googlesource.com/1201653 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588445} [modify] https://crrev.com/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79cb7a58544709d400353378b1758cbb33c16223 commit 79cb7a58544709d400353378b1758cbb33c16223 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:56:23 2018 file_shortcuts.js test: move constants into their helper routines Move directory tree expansion / icon constants into their helpers (the only place they are used). Minor comment clean-ups. Test: browser_tests --gtest_filter="FolderShortcuts/FilesApp*" Bug: 880127 Change-Id: I466ab7f59042801c170192b2ae5a5b132d3e26bf Reviewed-on: https://chromium-review.googlesource.com/1201655 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588446} [modify] https://crrev.com/79cb7a58544709d400353378b1758cbb33c16223/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8ddae9684a1074275f789cced663fc582565569 commit c8ddae9684a1074275f789cced663fc582565569 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 03:00:06 2018 Modernize folder_shortcuts.js addRemoveFolderShortcuts test Make a local helper to open FilesApp on Drive. Document the test steps to explain the intent of the test. Test: browser_tests --gtest_filter="*addRemoveFolderShortcuts" Bug: 880127 Change-Id: I4c31539bf518e59376602308208ba0bb7a854c70 Reviewed-on: https://chromium-review.googlesource.com/1201654 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588447} [modify] https://crrev.com/c8ddae9684a1074275f789cced663fc582565569/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 commit c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:09:18 2018 Modernize folder_shortcuts.js traverseFolderShortcuts test Use SetupAndWaitUntilReady(). Add comments describing each test step. Test: browser_tests --gtest_filter="*traverseFolderShortcuts" Bug: 880127 Change-Id: Icd425052e9acc9f2086a6c0b97ebca6b643ef473 Reviewed-on: https://chromium-review.googlesource.com/1201653 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588445} [modify] https://crrev.com/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79cb7a58544709d400353378b1758cbb33c16223 commit 79cb7a58544709d400353378b1758cbb33c16223 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:56:23 2018 file_shortcuts.js test: move constants into their helper routines Move directory tree expansion / icon constants into their helpers (the only place they are used). Minor comment clean-ups. Test: browser_tests --gtest_filter="FolderShortcuts/FilesApp*" Bug: 880127 Change-Id: I466ab7f59042801c170192b2ae5a5b132d3e26bf Reviewed-on: https://chromium-review.googlesource.com/1201655 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588446} [modify] https://crrev.com/79cb7a58544709d400353378b1758cbb33c16223/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8ddae9684a1074275f789cced663fc582565569 commit c8ddae9684a1074275f789cced663fc582565569 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 03:00:06 2018 Modernize folder_shortcuts.js addRemoveFolderShortcuts test Make a local helper to open FilesApp on Drive. Document the test steps to explain the intent of the test. Test: browser_tests --gtest_filter="*addRemoveFolderShortcuts" Bug: 880127 Change-Id: I4c31539bf518e59376602308208ba0bb7a854c70 Reviewed-on: https://chromium-review.googlesource.com/1201654 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588447} [modify] https://crrev.com/c8ddae9684a1074275f789cced663fc582565569/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 commit c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:09:18 2018 Modernize folder_shortcuts.js traverseFolderShortcuts test Use SetupAndWaitUntilReady(). Add comments describing each test step. Test: browser_tests --gtest_filter="*traverseFolderShortcuts" Bug: 880127 Change-Id: Icd425052e9acc9f2086a6c0b97ebca6b643ef473 Reviewed-on: https://chromium-review.googlesource.com/1201653 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588445} [modify] https://crrev.com/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79cb7a58544709d400353378b1758cbb33c16223 commit 79cb7a58544709d400353378b1758cbb33c16223 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:56:23 2018 file_shortcuts.js test: move constants into their helper routines Move directory tree expansion / icon constants into their helpers (the only place they are used). Minor comment clean-ups. Test: browser_tests --gtest_filter="FolderShortcuts/FilesApp*" Bug: 880127 Change-Id: I466ab7f59042801c170192b2ae5a5b132d3e26bf Reviewed-on: https://chromium-review.googlesource.com/1201655 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588446} [modify] https://crrev.com/79cb7a58544709d400353378b1758cbb33c16223/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8ddae9684a1074275f789cced663fc582565569 commit c8ddae9684a1074275f789cced663fc582565569 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 03:00:06 2018 Modernize folder_shortcuts.js addRemoveFolderShortcuts test Make a local helper to open FilesApp on Drive. Document the test steps to explain the intent of the test. Test: browser_tests --gtest_filter="*addRemoveFolderShortcuts" Bug: 880127 Change-Id: I4c31539bf518e59376602308208ba0bb7a854c70 Reviewed-on: https://chromium-review.googlesource.com/1201654 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588447} [modify] https://crrev.com/c8ddae9684a1074275f789cced663fc582565569/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 commit c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:09:18 2018 Modernize folder_shortcuts.js traverseFolderShortcuts test Use SetupAndWaitUntilReady(). Add comments describing each test step. Test: browser_tests --gtest_filter="*traverseFolderShortcuts" Bug: 880127 Change-Id: Icd425052e9acc9f2086a6c0b97ebca6b643ef473 Reviewed-on: https://chromium-review.googlesource.com/1201653 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588445} [modify] https://crrev.com/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79cb7a58544709d400353378b1758cbb33c16223 commit 79cb7a58544709d400353378b1758cbb33c16223 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:56:23 2018 file_shortcuts.js test: move constants into their helper routines Move directory tree expansion / icon constants into their helpers (the only place they are used). Minor comment clean-ups. Test: browser_tests --gtest_filter="FolderShortcuts/FilesApp*" Bug: 880127 Change-Id: I466ab7f59042801c170192b2ae5a5b132d3e26bf Reviewed-on: https://chromium-review.googlesource.com/1201655 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588446} [modify] https://crrev.com/79cb7a58544709d400353378b1758cbb33c16223/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8ddae9684a1074275f789cced663fc582565569 commit c8ddae9684a1074275f789cced663fc582565569 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 03:00:06 2018 Modernize folder_shortcuts.js addRemoveFolderShortcuts test Make a local helper to open FilesApp on Drive. Document the test steps to explain the intent of the test. Test: browser_tests --gtest_filter="*addRemoveFolderShortcuts" Bug: 880127 Change-Id: I4c31539bf518e59376602308208ba0bb7a854c70 Reviewed-on: https://chromium-review.googlesource.com/1201654 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588447} [modify] https://crrev.com/c8ddae9684a1074275f789cced663fc582565569/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 commit c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:09:18 2018 Modernize folder_shortcuts.js traverseFolderShortcuts test Use SetupAndWaitUntilReady(). Add comments describing each test step. Test: browser_tests --gtest_filter="*traverseFolderShortcuts" Bug: 880127 Change-Id: Icd425052e9acc9f2086a6c0b97ebca6b643ef473 Reviewed-on: https://chromium-review.googlesource.com/1201653 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588445} [modify] https://crrev.com/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79cb7a58544709d400353378b1758cbb33c16223 commit 79cb7a58544709d400353378b1758cbb33c16223 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:56:23 2018 file_shortcuts.js test: move constants into their helper routines Move directory tree expansion / icon constants into their helpers (the only place they are used). Minor comment clean-ups. Test: browser_tests --gtest_filter="FolderShortcuts/FilesApp*" Bug: 880127 Change-Id: I466ab7f59042801c170192b2ae5a5b132d3e26bf Reviewed-on: https://chromium-review.googlesource.com/1201655 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588446} [modify] https://crrev.com/79cb7a58544709d400353378b1758cbb33c16223/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8ddae9684a1074275f789cced663fc582565569 commit c8ddae9684a1074275f789cced663fc582565569 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 03:00:06 2018 Modernize folder_shortcuts.js addRemoveFolderShortcuts test Make a local helper to open FilesApp on Drive. Document the test steps to explain the intent of the test. Test: browser_tests --gtest_filter="*addRemoveFolderShortcuts" Bug: 880127 Change-Id: I4c31539bf518e59376602308208ba0bb7a854c70 Reviewed-on: https://chromium-review.googlesource.com/1201654 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588447} [modify] https://crrev.com/c8ddae9684a1074275f789cced663fc582565569/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 commit c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:09:18 2018 Modernize folder_shortcuts.js traverseFolderShortcuts test Use SetupAndWaitUntilReady(). Add comments describing each test step. Test: browser_tests --gtest_filter="*traverseFolderShortcuts" Bug: 880127 Change-Id: Icd425052e9acc9f2086a6c0b97ebca6b643ef473 Reviewed-on: https://chromium-review.googlesource.com/1201653 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588445} [modify] https://crrev.com/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79cb7a58544709d400353378b1758cbb33c16223 commit 79cb7a58544709d400353378b1758cbb33c16223 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:56:23 2018 file_shortcuts.js test: move constants into their helper routines Move directory tree expansion / icon constants into their helpers (the only place they are used). Minor comment clean-ups. Test: browser_tests --gtest_filter="FolderShortcuts/FilesApp*" Bug: 880127 Change-Id: I466ab7f59042801c170192b2ae5a5b132d3e26bf Reviewed-on: https://chromium-review.googlesource.com/1201655 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588446} [modify] https://crrev.com/79cb7a58544709d400353378b1758cbb33c16223/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8ddae9684a1074275f789cced663fc582565569 commit c8ddae9684a1074275f789cced663fc582565569 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 03:00:06 2018 Modernize folder_shortcuts.js addRemoveFolderShortcuts test Make a local helper to open FilesApp on Drive. Document the test steps to explain the intent of the test. Test: browser_tests --gtest_filter="*addRemoveFolderShortcuts" Bug: 880127 Change-Id: I4c31539bf518e59376602308208ba0bb7a854c70 Reviewed-on: https://chromium-review.googlesource.com/1201654 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588447} [modify] https://crrev.com/c8ddae9684a1074275f789cced663fc582565569/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 commit c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:09:18 2018 Modernize folder_shortcuts.js traverseFolderShortcuts test Use SetupAndWaitUntilReady(). Add comments describing each test step. Test: browser_tests --gtest_filter="*traverseFolderShortcuts" Bug: 880127 Change-Id: Icd425052e9acc9f2086a6c0b97ebca6b643ef473 Reviewed-on: https://chromium-review.googlesource.com/1201653 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588445} [modify] https://crrev.com/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79cb7a58544709d400353378b1758cbb33c16223 commit 79cb7a58544709d400353378b1758cbb33c16223 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:56:23 2018 file_shortcuts.js test: move constants into their helper routines Move directory tree expansion / icon constants into their helpers (the only place they are used). Minor comment clean-ups. Test: browser_tests --gtest_filter="FolderShortcuts/FilesApp*" Bug: 880127 Change-Id: I466ab7f59042801c170192b2ae5a5b132d3e26bf Reviewed-on: https://chromium-review.googlesource.com/1201655 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588446} [modify] https://crrev.com/79cb7a58544709d400353378b1758cbb33c16223/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8ddae9684a1074275f789cced663fc582565569 commit c8ddae9684a1074275f789cced663fc582565569 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 03:00:06 2018 Modernize folder_shortcuts.js addRemoveFolderShortcuts test Make a local helper to open FilesApp on Drive. Document the test steps to explain the intent of the test. Test: browser_tests --gtest_filter="*addRemoveFolderShortcuts" Bug: 880127 Change-Id: I4c31539bf518e59376602308208ba0bb7a854c70 Reviewed-on: https://chromium-review.googlesource.com/1201654 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588447} [modify] https://crrev.com/c8ddae9684a1074275f789cced663fc582565569/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 commit c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:09:18 2018 Modernize folder_shortcuts.js traverseFolderShortcuts test Use SetupAndWaitUntilReady(). Add comments describing each test step. Test: browser_tests --gtest_filter="*traverseFolderShortcuts" Bug: 880127 Change-Id: Icd425052e9acc9f2086a6c0b97ebca6b643ef473 Reviewed-on: https://chromium-review.googlesource.com/1201653 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588445} [modify] https://crrev.com/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79cb7a58544709d400353378b1758cbb33c16223 commit 79cb7a58544709d400353378b1758cbb33c16223 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:56:23 2018 file_shortcuts.js test: move constants into their helper routines Move directory tree expansion / icon constants into their helpers (the only place they are used). Minor comment clean-ups. Test: browser_tests --gtest_filter="FolderShortcuts/FilesApp*" Bug: 880127 Change-Id: I466ab7f59042801c170192b2ae5a5b132d3e26bf Reviewed-on: https://chromium-review.googlesource.com/1201655 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588446} [modify] https://crrev.com/79cb7a58544709d400353378b1758cbb33c16223/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8ddae9684a1074275f789cced663fc582565569 commit c8ddae9684a1074275f789cced663fc582565569 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 03:00:06 2018 Modernize folder_shortcuts.js addRemoveFolderShortcuts test Make a local helper to open FilesApp on Drive. Document the test steps to explain the intent of the test. Test: browser_tests --gtest_filter="*addRemoveFolderShortcuts" Bug: 880127 Change-Id: I4c31539bf518e59376602308208ba0bb7a854c70 Reviewed-on: https://chromium-review.googlesource.com/1201654 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588447} [modify] https://crrev.com/c8ddae9684a1074275f789cced663fc582565569/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 commit c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:09:18 2018 Modernize folder_shortcuts.js traverseFolderShortcuts test Use SetupAndWaitUntilReady(). Add comments describing each test step. Test: browser_tests --gtest_filter="*traverseFolderShortcuts" Bug: 880127 Change-Id: Icd425052e9acc9f2086a6c0b97ebca6b643ef473 Reviewed-on: https://chromium-review.googlesource.com/1201653 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588445} [modify] https://crrev.com/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79cb7a58544709d400353378b1758cbb33c16223 commit 79cb7a58544709d400353378b1758cbb33c16223 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:56:23 2018 file_shortcuts.js test: move constants into their helper routines Move directory tree expansion / icon constants into their helpers (the only place they are used). Minor comment clean-ups. Test: browser_tests --gtest_filter="FolderShortcuts/FilesApp*" Bug: 880127 Change-Id: I466ab7f59042801c170192b2ae5a5b132d3e26bf Reviewed-on: https://chromium-review.googlesource.com/1201655 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588446} [modify] https://crrev.com/79cb7a58544709d400353378b1758cbb33c16223/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8ddae9684a1074275f789cced663fc582565569 commit c8ddae9684a1074275f789cced663fc582565569 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 03:00:06 2018 Modernize folder_shortcuts.js addRemoveFolderShortcuts test Make a local helper to open FilesApp on Drive. Document the test steps to explain the intent of the test. Test: browser_tests --gtest_filter="*addRemoveFolderShortcuts" Bug: 880127 Change-Id: I4c31539bf518e59376602308208ba0bb7a854c70 Reviewed-on: https://chromium-review.googlesource.com/1201654 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588447} [modify] https://crrev.com/c8ddae9684a1074275f789cced663fc582565569/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7a6b71ad5ccb309ee068ce886c788952a8cc50b commit e7a6b71ad5ccb309ee068ce886c788952a8cc50b Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 08:56:37 2018 folder_shortcuts.js: convert windowId to appId windowId => appId, clarify some comments, rename odd variables, format a few helper routines. Bug: 880127 Change-Id: Ieff0384975930be4384d2dc932187b817cc1527d Reviewed-on: https://chromium-review.googlesource.com/1203516 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588477} [modify] https://crrev.com/e7a6b71ad5ccb309ee068ce886c788952a8cc50b/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91534a9a1253fa5aad5a9f5d505880ddc80dca69 commit 91534a9a1253fa5aad5a9f5d505880ddc80dca69 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 10:28:47 2018 folder_shortcuts.js: correct Tricum spelling nit (fulfilled). Bug: 880127 Change-Id: Ia501894e384937da8e1aa2c9520372b6067f9d34 Reviewed-on: https://chromium-review.googlesource.com/1203755 Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588483} [modify] https://crrev.com/91534a9a1253fa5aad5a9f5d505880ddc80dca69/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 commit c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:09:18 2018 Modernize folder_shortcuts.js traverseFolderShortcuts test Use SetupAndWaitUntilReady(). Add comments describing each test step. Test: browser_tests --gtest_filter="*traverseFolderShortcuts" Bug: 880127 Change-Id: Icd425052e9acc9f2086a6c0b97ebca6b643ef473 Reviewed-on: https://chromium-review.googlesource.com/1201653 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588445} [modify] https://crrev.com/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79cb7a58544709d400353378b1758cbb33c16223 commit 79cb7a58544709d400353378b1758cbb33c16223 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:56:23 2018 file_shortcuts.js test: move constants into their helper routines Move directory tree expansion / icon constants into their helpers (the only place they are used). Minor comment clean-ups. Test: browser_tests --gtest_filter="FolderShortcuts/FilesApp*" Bug: 880127 Change-Id: I466ab7f59042801c170192b2ae5a5b132d3e26bf Reviewed-on: https://chromium-review.googlesource.com/1201655 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588446} [modify] https://crrev.com/79cb7a58544709d400353378b1758cbb33c16223/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8ddae9684a1074275f789cced663fc582565569 commit c8ddae9684a1074275f789cced663fc582565569 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 03:00:06 2018 Modernize folder_shortcuts.js addRemoveFolderShortcuts test Make a local helper to open FilesApp on Drive. Document the test steps to explain the intent of the test. Test: browser_tests --gtest_filter="*addRemoveFolderShortcuts" Bug: 880127 Change-Id: I4c31539bf518e59376602308208ba0bb7a854c70 Reviewed-on: https://chromium-review.googlesource.com/1201654 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588447} [modify] https://crrev.com/c8ddae9684a1074275f789cced663fc582565569/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7a6b71ad5ccb309ee068ce886c788952a8cc50b commit e7a6b71ad5ccb309ee068ce886c788952a8cc50b Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 08:56:37 2018 folder_shortcuts.js: convert windowId to appId windowId => appId, clarify some comments, rename odd variables, format a few helper routines. Bug: 880127 Change-Id: Ieff0384975930be4384d2dc932187b817cc1527d Reviewed-on: https://chromium-review.googlesource.com/1203516 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588477} [modify] https://crrev.com/e7a6b71ad5ccb309ee068ce886c788952a8cc50b/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91534a9a1253fa5aad5a9f5d505880ddc80dca69 commit 91534a9a1253fa5aad5a9f5d505880ddc80dca69 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 10:28:47 2018 folder_shortcuts.js: correct Tricum spelling nit (fulfilled). Bug: 880127 Change-Id: Ia501894e384937da8e1aa2c9520372b6067f9d34 Reviewed-on: https://chromium-review.googlesource.com/1203755 Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588483} [modify] https://crrev.com/91534a9a1253fa5aad5a9f5d505880ddc80dca69/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 commit c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:09:18 2018 Modernize folder_shortcuts.js traverseFolderShortcuts test Use SetupAndWaitUntilReady(). Add comments describing each test step. Test: browser_tests --gtest_filter="*traverseFolderShortcuts" Bug: 880127 Change-Id: Icd425052e9acc9f2086a6c0b97ebca6b643ef473 Reviewed-on: https://chromium-review.googlesource.com/1201653 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588445} [modify] https://crrev.com/c9fbcbffc170fa0fb765ded8e3f3f7396a9dcbf4/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79cb7a58544709d400353378b1758cbb33c16223 commit 79cb7a58544709d400353378b1758cbb33c16223 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 02:56:23 2018 file_shortcuts.js test: move constants into their helper routines Move directory tree expansion / icon constants into their helpers (the only place they are used). Minor comment clean-ups. Test: browser_tests --gtest_filter="FolderShortcuts/FilesApp*" Bug: 880127 Change-Id: I466ab7f59042801c170192b2ae5a5b132d3e26bf Reviewed-on: https://chromium-review.googlesource.com/1201655 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588446} [modify] https://crrev.com/79cb7a58544709d400353378b1758cbb33c16223/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8ddae9684a1074275f789cced663fc582565569 commit c8ddae9684a1074275f789cced663fc582565569 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 03:00:06 2018 Modernize folder_shortcuts.js addRemoveFolderShortcuts test Make a local helper to open FilesApp on Drive. Document the test steps to explain the intent of the test. Test: browser_tests --gtest_filter="*addRemoveFolderShortcuts" Bug: 880127 Change-Id: I4c31539bf518e59376602308208ba0bb7a854c70 Reviewed-on: https://chromium-review.googlesource.com/1201654 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588447} [modify] https://crrev.com/c8ddae9684a1074275f789cced663fc582565569/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7a6b71ad5ccb309ee068ce886c788952a8cc50b commit e7a6b71ad5ccb309ee068ce886c788952a8cc50b Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 08:56:37 2018 folder_shortcuts.js: convert windowId to appId windowId => appId, clarify some comments, rename odd variables, format a few helper routines. Bug: 880127 Change-Id: Ieff0384975930be4384d2dc932187b817cc1527d Reviewed-on: https://chromium-review.googlesource.com/1203516 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588477} [modify] https://crrev.com/e7a6b71ad5ccb309ee068ce886c788952a8cc50b/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91534a9a1253fa5aad5a9f5d505880ddc80dca69 commit 91534a9a1253fa5aad5a9f5d505880ddc80dca69 Author: Noel Gordon <noel@chromium.org> Date: Tue Sep 04 10:28:47 2018 folder_shortcuts.js: correct Tricum spelling nit (fulfilled). Bug: 880127 Change-Id: Ia501894e384937da8e1aa2c9520372b6067f9d34 Reviewed-on: https://chromium-review.googlesource.com/1203755 Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588483} [modify] https://crrev.com/91534a9a1253fa5aad5a9f5d505880ddc80dca69/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Sep 4
,
Sep 5
+jbudorick this test flirts with the chrome-os ASAN bot time-limit. Add bot load due to other tests, and flirt becomes a flake (picture). How can we get more time on the bot? Or make this test on its own always?
,
Sep 5
Ahem "Or make this test _run_ on its own always?"
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/086b23ad7e923c392ec542cd4036269cd6a24231 commit 086b23ad7e923c392ec542cd4036269cd6a24231 Author: Noel Gordon <noel@chromium.org> Date: Wed Sep 05 00:58:01 2018 folder_shortcuts.js: minor clean-up Make clickShortCut() test the fakeMouseClick's return result. Reformat lines that now fits on a line. Change "should" to "must". Test: browser_tests --gtest_filter="FolderShortcuts/*FilesApp" Bug: 880127 Change-Id: I2084a7ae576aec93097c423bc14171b90ccbe443 Reviewed-on: https://chromium-review.googlesource.com/1203481 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588724} [modify] https://crrev.com/086b23ad7e923c392ec542cd4036269cd6a24231/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
,
Nov 6
,
Nov 6
Per #61, while I was OOO, seems the chrome-os ASAN bot test time limit was increased. None of folder_shortcut.js tests hit the limit anymore.
,
Nov 6
,
Nov 6
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Sep 4