New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 880126 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Feature

Blocking:
issue 844278



Sign in to add a comment

desktop-pwas: PendingAppManager::UninstallApps() should wait for any previous InstallApps() calls to end.

Project Member Reported by ortuno@chromium.org, Sep 4

Issue description

Currently UninstallApps() runs immediately even if there is an InstallApps() call in progress. For example:

1. Client calls InstallApps() with [A, B, C]
2. Client calls UninstallApps() with [C] while InstallApps is in progress.

The call to UninstallApps will fail because C has not been install yet. To work around this clients need to wait for InstallApps() to finish before calling UninstallApps().

Rather than pushing this logic down to clients, PendingAppManager::UninstallApps() should wait for the previous InstallApps() call to finish.
 
Perhaps, instead of separate InstallApps and UninstallApps methods (which take a std::vector<AppInfo>), there should be a single method which takes std::vector<std::pair<AppInfo, AppAction>>.

Sign in to add a comment