New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 880123 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Sep 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Crash in _platform_memmove$VARIANT$Nehalem

Project Member Reported by ClusterFuzz, Sep 4

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5681768819326976

Fuzzer: inferno_twister
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: UNKNOWN WRITE
Crash Address: 0x0001450d9000
Crash State:
  _platform_memmove$VARIANT$Nehalem
  SkBinaryWriteBuffer::writeByteArray
  SkTextBlobPriv::Flatten
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=588391:588392

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5681768819326976

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Sep 4

Components: Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Sep 4

Labels: Test-Predator-Auto-Owner
Owner: bauerb@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/2956bd1091705fa7bfde132796fcc3f8983f6a00 (Make PropertyModelChangeProcessor observe its model).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 4

Labels: Target-70 M-70
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 4

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 4

Labels: Pri-1
Cc: bauerb@chromium.org
Labels: Test-Predator-Wrong-CLs
Owner: ----
Status: Untriaged (was: Assigned)
r588392 is Java-only, it shouldn't affect Skia on Mac.
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 5

Labels: -Security_Impact-Head Security_Impact-Beta
Cc: tedc...@chromium.org dtrainor@chromium.org twelling...@chromium.org
CC'ing some extra people that reviewed the culprit CL as @bauerb seems to be OOO.
Oh, sorry, missed the comment by @bauerb.
Cc: -twelling...@chromium.org -tedc...@chromium.org -bauerb@chromium.org -dtrainor@chromium.org hcm@chromium.org herb@chromium.org reed@chromium.org liyuqian@chromium.org
Hi Skia team, can you please triage this and assign an owner?
Project Member

Comment 11 by ClusterFuzz, Sep 8

ClusterFuzz has detected this issue as fixed in range 589552:589567.

Detailed report: https://clusterfuzz.com/testcase?key=5681768819326976

Fuzzer: inferno_twister
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: UNKNOWN WRITE
Crash Address: 0x0001450d9000
Crash State:
  _platform_memmove$VARIANT$Nehalem
  SkBinaryWriteBuffer::writeByteArray
  SkTextBlobPriv::Flatten
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=588391:588392
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=589552:589567

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5681768819326976

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Sep 8

Labels: ClusterFuzz-Verified
Status: Verified (was: Untriaged)
ClusterFuzz testcase 5681768819326976 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 13 by sheriffbot@chromium.org, Sep 8

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 14 by sheriffbot@chromium.org, Sep 14

Labels: Merge-Request-70
Project Member

Comment 15 by sheriffbot@chromium.org, Sep 14

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Is there a merge required for this? Seems like there wasn't any fix that landed?
Labels: -Merge-Review-70
Labels: -Target-70 -M-70 Target-71 M-71
Labels: -ReleaseBlock-Stable
Project Member

Comment 20 by sheriffbot@chromium.org, Dec 15

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment