New issue
Advanced search Search tips

Issue 880090 link

Starred by 1 user
Status: Fixed
Owner:
jdoerrie@chromium.org
Closed: Jan 8
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove https credentials cleaning code

Project Member Reported by gemene@google.com, Sep 3 
https://crrev.com/c/1186323 introduce the code that delete HTTPS credentials with wrong signon_realm.

Once metric named PasswordManager.InvalidtHttpsCredentialsNeedToBeCleared reports that users doesn't need clearing, code that can be removed because the it will not be useful anymore.

Comment 1 by gemene@google.com, Sep 18

Description: Show this description

Comment 2 by jdoerrie@chromium.org, Jan 7

Owner: jdoerrie@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16b762adf37a2d6d8ad18d58f46e886f9b7451a2

commit 16b762adf37a2d6d8ad18d58f46e886f9b7451a2
Author: jdoerrie <jdoerrie@chromium.org>
Date: Tue Jan 08 07:44:43 2019

[Passwords] Remove invalid HTTPS credential clean-up logic

This change removes the clean-up logic of invalid HTTPS credentials
introduced in M71. In particular, this change deletes the
InvalidRealmCredentialCleaner class, and gets rid of / obsoletes the
related PasswordManager.InvalidtHttpsCredentialsNeedToBeCleared UMA
histogram and "profile.credentials_with_wrong_signon_realm_removed"
preference.

Bug: 915900,  880090 
Change-Id: I7d70719a483518294540cf318e43898811580d67
Reviewed-on: https://chromium-review.googlesource.com/c/1397610
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620647}
[modify] https://crrev.com/16b762adf37a2d6d8ad18d58f46e886f9b7451a2/components/password_manager/core/browser/BUILD.gn
[delete] https://crrev.com/f0eaba271750726683c5ccd07317a98a4d251358/components/password_manager/core/browser/invalid_realm_credential_cleaner.cc
[delete] https://crrev.com/f0eaba271750726683c5ccd07317a98a4d251358/components/password_manager/core/browser/invalid_realm_credential_cleaner.h
[delete] https://crrev.com/f0eaba271750726683c5ccd07317a98a4d251358/components/password_manager/core/browser/invalid_realm_credential_cleaner_unittest.cc
[modify] https://crrev.com/16b762adf37a2d6d8ad18d58f46e886f9b7451a2/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/16b762adf37a2d6d8ad18d58f46e886f9b7451a2/components/password_manager/core/browser/password_manager_util.cc
[modify] https://crrev.com/16b762adf37a2d6d8ad18d58f46e886f9b7451a2/components/password_manager/core/browser/password_manager_util_unittest.cc
[modify] https://crrev.com/16b762adf37a2d6d8ad18d58f46e886f9b7451a2/components/password_manager/core/common/password_manager_pref_names.cc
[modify] https://crrev.com/16b762adf37a2d6d8ad18d58f46e886f9b7451a2/components/password_manager/core/common/password_manager_pref_names.h
[modify] https://crrev.com/16b762adf37a2d6d8ad18d58f46e886f9b7451a2/tools/metrics/histograms/histograms.xml

Comment 4 by jdoerrie@chromium.org, Jan 8

Status: Fixed (was: Assigned)
Similarly to  https://crbug.com/866794 , PasswordManager.InvalidtHttpsCredentialsNeedToBeCleared was below 2% (going further down only very very slowly), which we believe is caused by the fact that the preference was recorded before performing the actual clean-up.
►

Sign in to add a comment