New issue
Advanced search Search tips

Issue 880087 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Merge [Images for the translation of chrome://webrtc-logs/] to M70

Project Member Reported by eladalon@chromium.org, Sep 3

Issue description

Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Components: Blink>WebRTC>Tools
Cc: guidou@chromium.org
Guido, this has not yet been approved; do you know if there's somebody I should ping, or is this still within the expected time-frame?
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 4

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 5

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1730de93a77f7f86a352e461c8fc475fd3d1b5ce

commit 1730de93a77f7f86a352e461c8fc475fd3d1b5ce
Author: Elad Alon <eladalon@chromium.org>
Date: Tue Sep 04 19:14:00 2018

Images for the translation of chrome://webrtc-logs/

Add the sha1 files for the images intended to assist the
translation of chrome://webrtc-logs/.

Bug:  880087 
Change-Id: I15e61b61442bba819132a707ceccd3b59e8f964c
Reviewed-on: https://chromium-review.googlesource.com/1202150
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588405}(cherry picked from commit 5acae9ed6e99acddfae6eedae904c26e73870563)
Reviewed-on: https://chromium-review.googlesource.com/1205071
Reviewed-by: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#32}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[add] https://crrev.com/1730de93a77f7f86a352e461c8fc475fd3d1b5ce/chrome/app/generated_resources_grd/IDS_WEBRTC_EVENT_LOGS_LOG_COUNT_BANNER_FORMAT.png.sha1
[add] https://crrev.com/1730de93a77f7f86a352e461c8fc475fd3d1b5ce/chrome/app/generated_resources_grd/IDS_WEBRTC_LOGS_BUG_LINK_LABEL.png.sha1
[add] https://crrev.com/1730de93a77f7f86a352e461c8fc475fd3d1b5ce/chrome/app/generated_resources_grd/IDS_WEBRTC_LOGS_EVENT_LOG_LOCAL_LOG_ID.png.sha1
[add] https://crrev.com/1730de93a77f7f86a352e461c8fc475fd3d1b5ce/chrome/app/generated_resources_grd/IDS_WEBRTC_LOGS_LOG_ACTIVELY_UPLOADED_MESSAGE.png.sha1
[add] https://crrev.com/1730de93a77f7f86a352e461c8fc475fd3d1b5ce/chrome/app/generated_resources_grd/IDS_WEBRTC_LOGS_LOG_FAILED_UPLOAD_TIME_FORMAT.png.sha1
[add] https://crrev.com/1730de93a77f7f86a352e461c8fc475fd3d1b5ce/chrome/app/generated_resources_grd/IDS_WEBRTC_LOGS_LOG_HEADER_FORMAT.png.sha1
[add] https://crrev.com/1730de93a77f7f86a352e461c8fc475fd3d1b5ce/chrome/app/generated_resources_grd/IDS_WEBRTC_LOGS_LOG_LOCAL_FILE_LABEL_FORMAT.png.sha1
[add] https://crrev.com/1730de93a77f7f86a352e461c8fc475fd3d1b5ce/chrome/app/generated_resources_grd/IDS_WEBRTC_LOGS_LOG_NOT_UPLOADED_MESSAGE.png.sha1
[add] https://crrev.com/1730de93a77f7f86a352e461c8fc475fd3d1b5ce/chrome/app/generated_resources_grd/IDS_WEBRTC_LOGS_LOG_PENDING_MESSAGE.png.sha1
[add] https://crrev.com/1730de93a77f7f86a352e461c8fc475fd3d1b5ce/chrome/app/generated_resources_grd/IDS_WEBRTC_LOGS_LOG_REPORT_ID_FORMAT.png.sha1
[add] https://crrev.com/1730de93a77f7f86a352e461c8fc475fd3d1b5ce/chrome/app/generated_resources_grd/IDS_WEBRTC_LOGS_LOG_UPLOAD_TIME_FORMAT.png.sha1
[add] https://crrev.com/1730de93a77f7f86a352e461c8fc475fd3d1b5ce/chrome/app/generated_resources_grd/IDS_WEBRTC_LOGS_NO_EVENT_LOGS_MESSAGE.png.sha1
[add] https://crrev.com/1730de93a77f7f86a352e461c8fc475fd3d1b5ce/chrome/app/generated_resources_grd/IDS_WEBRTC_LOGS_NO_LOCAL_LOG_FILE_MESSAGE.png.sha1
[add] https://crrev.com/1730de93a77f7f86a352e461c8fc475fd3d1b5ce/chrome/app/generated_resources_grd/IDS_WEBRTC_LOGS_NO_TEXT_LOGS_MESSAGE.png.sha1
[add] https://crrev.com/1730de93a77f7f86a352e461c8fc475fd3d1b5ce/chrome/app/generated_resources_grd/IDS_WEBRTC_LOGS_TITLE.png.sha1
[add] https://crrev.com/1730de93a77f7f86a352e461c8fc475fd3d1b5ce/chrome/app/generated_resources_grd/IDS_WEBRTC_TEXT_LOGS_LOG_COUNT_BANNER_FORMAT.png.sha1

Sign in to add a comment