New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 880074 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature

Blocking:
issue 850936



Sign in to add a comment

Delete audio quality browser tests

Project Member Reported by marinaciocea@chromium.org, Sep 3

Issue description

Improve audio quality browsertests[1] to make failures easier to reproduce and investigate (see [2]), and to support newer Windows versions (currently only running on Win 7).

[1] https://cs.chromium.org/chromium/src/chrome/browser/media/webrtc/webrtc_audio_quality_browsertest.cc
[2]  https://crbug.com/850936#c55 
 
Status: Started (was: Available)
Summary: Delete audio quality browser tests (was: Improve and reenable audio quality browser tests on Windows)
Instead of fixing the tests, we have decided to delete them.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/35889d88d3549acf0626c17d29a6296a56f9939a

commit 35889d88d3549acf0626c17d29a6296a56f9939a
Author: Patrik Höglund <phoglund@chromium.org>
Date: Wed Oct 10 13:02:31 2018

Stop running WebRTC Audio Quality tests.

We have decided these tests aren't worth the effort to keep running,
so let's delete them and the supporting code. This will also make the
chromium.webrtc migration easier.

Bug:  880074 
Change-Id: Ice92e0c4ba32354b32483ff1c1d575114c1b7b43
Reviewed-on: https://chromium-review.googlesource.com/c/1273217
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>

[modify] https://crrev.com/35889d88d3549acf0626c17d29a6296a56f9939a/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.expected/webrtc_tester.json
[modify] https://crrev.com/35889d88d3549acf0626c17d29a6296a56f9939a/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py
[modify] https://crrev.com/35889d88d3549acf0626c17d29a6296a56f9939a/scripts/slave/recipe_modules/chromium_tests/steps.py
[delete] https://crrev.com/3e302e55438b6d28c0a99c47a12d9d0fdbf1893e/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.expected/no_upload_if_no_wav_files.json
[modify] https://crrev.com/35889d88d3549acf0626c17d29a6296a56f9939a/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.expected/webrtc_fyi_tester.json
[delete] https://crrev.com/3e302e55438b6d28c0a99c47a12d9d0fdbf1893e/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.expected/upload_any_wav_files_from_audio_quality_test.json
[delete] https://crrev.com/3e302e55438b6d28c0a99c47a12d9d0fdbf1893e/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.expected/upload_any_wav_files_even_if_test_fails.json
[modify] https://crrev.com/35889d88d3549acf0626c17d29a6296a56f9939a/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.py

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c0016933a08fb73810323836dbaf63d79108823

commit 3c0016933a08fb73810323836dbaf63d79108823
Author: Patrik Höglund <phoglund@chromium.org>
Date: Wed Oct 10 13:20:15 2018

Remove WebRTC audio quality browser tests.

We have found these tests are not worth keeping since it's so hard
to run them for developers, so it's time to delete them.

Bug:  chromium:880074 
Change-Id: I5a853b9259573f67029b08656485bd03c5ccf90f
Reviewed-on: https://chromium-review.googlesource.com/c/1273060
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598300}
[delete] https://crrev.com/77762bfaf5ff2821b95f007f9a7dd99c08bef0d8/chrome/browser/media/webrtc/webrtc_audio_quality_browsertest.cc
[delete] https://crrev.com/77762bfaf5ff2821b95f007f9a7dd99c08bef0d8/chrome/browser/media/webrtc/webrtc_browsertest_audio.cc
[delete] https://crrev.com/77762bfaf5ff2821b95f007f9a7dd99c08bef0d8/chrome/browser/media/webrtc/webrtc_browsertest_audio.h
[modify] https://crrev.com/3c0016933a08fb73810323836dbaf63d79108823/chrome/test/BUILD.gn
[delete] https://crrev.com/77762bfaf5ff2821b95f007f9a7dd99c08bef0d8/chrome/test/data/webrtc/resources/force_mic_volume_max.exe.sha1
[delete] https://crrev.com/77762bfaf5ff2821b95f007f9a7dd99c08bef0d8/chrome/test/data/webrtc/resources/speech_44kHz_16bit_stereo.wav.sha1
[modify] https://crrev.com/3c0016933a08fb73810323836dbaf63d79108823/chrome/test/data/webrtc/resources/tools/README
[delete] https://crrev.com/77762bfaf5ff2821b95f007f9a7dd99c08bef0d8/chrome/test/data/webrtc/resources/tools/linux/pesq.sha1
[delete] https://crrev.com/77762bfaf5ff2821b95f007f9a7dd99c08bef0d8/chrome/test/data/webrtc/resources/tools/mac/pesq.sha1
[delete] https://crrev.com/77762bfaf5ff2821b95f007f9a7dd99c08bef0d8/chrome/test/data/webrtc/resources/tools/win/pesq.exe.sha1
[delete] https://crrev.com/77762bfaf5ff2821b95f007f9a7dd99c08bef0d8/chrome/test/data/webrtc/resources/tools/win/sox.exe.sha1
[modify] https://crrev.com/3c0016933a08fb73810323836dbaf63d79108823/testing/buildbot/filters/webrtc_perf.browser_tests.filter

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 15

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/cae8802dc12a36b856656ba52ca234bb1943c8f8

commit cae8802dc12a36b856656ba52ca234bb1943c8f8
Author: Patrik Höglund <phoglund@webrtc.org>
Date: Mon Oct 15 09:08:07 2018

Delete force_mic_volume_max.

This tool is no longer needed since we're deleting the AQ tests.

Bug:  chromium:880074 
Change-Id: I035d7b33c7c4feb5962cf9dafc8e7086a8dee440
Reviewed-on: https://webrtc-review.googlesource.com/c/105140
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25162}
[modify] https://crrev.com/cae8802dc12a36b856656ba52ca234bb1943c8f8/rtc_tools/BUILD.gn
[delete] https://crrev.com/83bd37cda43249e69de07d40bcba5539bcbe7f9e/rtc_tools/force_mic_volume_max/force_mic_volume_max.cc

Wiki cleanup is also complete.
Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5826ca3ce2a627c12fd2a1c79cb4f8a07365d5f7

commit 5826ca3ce2a627c12fd2a1c79cb4f8a07365d5f7
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Oct 16 06:08:25 2018

Roll src/third_party/webrtc f7fee39547d8..c9e6b969a452 (42 commits)

https://webrtc.googlesource.com/src.git/+log/f7fee39547d8..c9e6b969a452


git log f7fee39547d8..c9e6b969a452 --date=short --no-merges --format='%ad %ae %s'
2018-10-15 ouj@fb.com Add necessary frameworks to sdk objc audio targets.
2018-10-15 mbonadei@webrtc.org Export symbols needed by the Chromium component build (part 2).
2018-10-15 benwright@webrtc.org Formatting and style guide improvements for opensslstreamadapter.cc
2018-10-15 mbonadei@webrtc.org Revert "Deprecates legacy transport feedback adapter."
2018-10-15 srte@webrtc.org Deprecates legacy transport feedback adapter.
2018-10-15 srte@webrtc.org Removes analyzer dependency on legacy congestion controller.
2018-10-15 niklas.enbom@webrtc.org Revert "Modernize rtc::SSLCertificate"
2018-10-15 eladalon@webrtc.org Fix force_fieldtrials documentation in video_loopback
2018-10-15 srte@webrtc.org Removing forward declarations in paced_sender.h.
2018-10-15 srte@webrtc.org Adds unit test for RTT based backoff.
2018-10-15 srte@webrtc.org Merges ControlHandler and PacerController.
2018-10-15 srte@webrtc.org Moves functionality to TransportFeedbackAdapter.
2018-10-15 ivoc@webrtc.org Stop simulations when a LOG_END event is reached.
2018-10-15 henrik.lundin@webrtc.org NetEq fuzzer: Restrict fuzzer input to 90000 bytes
2018-10-15 ivoc@webrtc.org Make ivoc owner of audio_coding.
2018-10-15 mbonadei@webrtc.org Revert "Reland: Use unique_ptr and ArrayView in SSLFingerprint"
2018-10-15 titovartem@webrtc.org Extract functionality of test_main into separate library.
2018-10-15 ivoc@webrtc.org Add command-line flag for setting the max number of packets in the buffer.
2018-10-15 sprang@webrtc.org Move MockVideoDecoder to api/test.
2018-10-15 gustaf@webrtc.org AEC3: Simplify render buffering
2018-10-15 srte@webrtc.org Moves rtc::SentPacket to separate target.
2018-10-15 crodbro@webrtc.org New method for precise packet reception time measurement.
2018-10-15 asapersson@webrtc.org Add field trial to disable unsignalled video.
2018-10-15 ilnik@webrtc.org Fix FakeEncoder to produce correct bitrate for several temporal layers
2018-10-15 ssilkin@webrtc.org Set frame duration per spatial layer.
2018-10-15 kron@webrtc.org Refactor of extmap-allow-mixed in SessionDescription
2018-10-15 phoglund@webrtc.org Delete force_mic_volume_max.
2018-10-15 jakobi@webrtc.org Add field trials for configuring Opus encoder packet loss rate.
2018-10-15 danilchap@webrtc.org in RtpPacketizers separate case 'frame fits into single packet'.
2018-10-15 asapersson@webrtc.org Add field trial for normalized simulcast size.
2018-10-15 mbonadei@webrtc.org Remove ios32_sim_ios9_dbg from CQ.
2018-10-15 oprypin@webrtc.org cq: explicitly mark presubmit tryjob as not re-usable in CQ.
2018-10-15 mbonadei@webrtc.org Remove rtc_base/Dummy.java.
2018-10-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 03013c95df..0df2607f98 (599460:599562)
2018-10-14 oprypin@webrtc.org Revert "Propagate media transport to media channel."
2018-10-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3b54b6aa8b..03013c95df (599343:599460)
2018-10-12 sukhanov@google.com Propagate media transport to media channel.
2018-10-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c12ec9eedc..3b54b6aa8b (599188:599343)
2018-10-12 steveanton@webrtc.org Modernize rtc::SSLCertificate
2018-10-12 steveanton@webrtc.org Reland: Use unique_ptr and ArrayView in SSLFingerprint
2018-10-12 benwright@webrtc.org Removes backwards compatability CryptoOptions support.
2018-10-12 terelius@webrtc.org Move expectations from eventlog unittests to helper functions.


Created with:
  gclient setdep -r src/third_party/webrtc@c9e6b969a452

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:895082,chromium:None,chromium:895338,chromium:none,chromium:880074,chromium:none,chromium:893955,chromium:None,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I91bb7f65d2d749ab95ddcc51e5391973e6c6deca
Reviewed-on: https://chromium-review.googlesource.com/c/1282323
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599886}
[modify] https://crrev.com/5826ca3ce2a627c12fd2a1c79cb4f8a07365d5f7/DEPS

Sign in to add a comment