New issue
Advanced search Search tips

Issue 880056 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 801985



Sign in to add a comment

Meta bug for invalidation related clean-ups

Project Member Reported by melandory@chromium.org, Sep 3

Issue description

Invalidation-related code needs clean-up.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a083b0d06a9590e8841279ca64dc6c20816070b

commit 2a083b0d06a9590e8841279ca64dc6c20816070b
Author: Tanja Gornak <melandory@chromium.org>
Date: Wed Oct 31 11:53:26 2018

Add melandory to the components/invalidation OWNERS

Bug: 880056, 801985
Change-Id: I0606bb84518b35a8d965e6bb2fb44bb6fcee5620
Reviewed-on: https://chromium-review.googlesource.com/c/1307435
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604213}
[modify] https://crrev.com/2a083b0d06a9590e8841279ca64dc6c20816070b/components/invalidation/OWNERS

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f13e0bb9699e80adc08072f3623fd73e08c739e

commit 3f13e0bb9699e80adc08072f3623fd73e08c739e
Author: Tanja Gornak <melandory@chromium.org>
Date: Wed Oct 31 11:56:13 2018

Ditch tools/sync_client

sync_client isn't used on any platforms, hence it doesn't make sense to keep it around.

Bug: 880056, 801985
Change-Id: I1bbb5c689d1b004fa8a673e5d86c91a3e9712900
Reviewed-on: https://chromium-review.googlesource.com/c/1307494
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604214}
[modify] https://crrev.com/3f13e0bb9699e80adc08072f3623fd73e08c739e/BUILD.gn
[modify] https://crrev.com/3f13e0bb9699e80adc08072f3623fd73e08c739e/components/sync/tools/BUILD.gn
[delete] https://crrev.com/2a083b0d06a9590e8841279ca64dc6c20816070b/components/sync/tools/sync_client.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecbf38d52d37f5fe8668aba014435edd4a58c898

commit ecbf38d52d37f5fe8668aba014435edd4a58c898
Author: Tanja Gornak <melandory@chromium.org>
Date: Mon Nov 12 13:15:23 2018

Ditch components/sync/tools/sync_listen_notifications.

sync_listen_notifications istn't used neither in production code,
nor in tests. Hence removing.

Bug: 880056, 801985
Change-Id: If518c9dad72b3f718ee649844a6cf3a4703bc0c7
Reviewed-on: https://chromium-review.googlesource.com/c/1307434
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607209}
[modify] https://crrev.com/ecbf38d52d37f5fe8668aba014435edd4a58c898/BUILD.gn
[delete] https://crrev.com/af2a90f55444d56c9529eb20ab499c4ccc5e6bfd/components/sync/tools/BUILD.gn
[delete] https://crrev.com/af2a90f55444d56c9529eb20ab499c4ccc5e6bfd/components/sync/tools/DEPS
[delete] https://crrev.com/af2a90f55444d56c9529eb20ab499c4ccc5e6bfd/components/sync/tools/null_invalidation_state_tracker.cc
[delete] https://crrev.com/af2a90f55444d56c9529eb20ab499c4ccc5e6bfd/components/sync/tools/null_invalidation_state_tracker.h
[delete] https://crrev.com/af2a90f55444d56c9529eb20ab499c4ccc5e6bfd/components/sync/tools/sync_listen_notifications.cc
[modify] https://crrev.com/ecbf38d52d37f5fe8668aba014435edd4a58c898/components/sync/tools/testserver/DEPS

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a09895cf4d4ce0b5d4f620b1c82180152f02913

commit 5a09895cf4d4ce0b5d4f620b1c82180152f02913
Author: Tanja Gornak <melandory@chromium.org>
Date: Wed Dec 19 14:41:10 2018

[Tango->FCM] Change state to enabled, once InstanceID token is received.

As of today, invalidations declare them selves as working after 1st
message is received via FCM channel. This approach has worked in deprecated
implementation, since there server has generated fake invalidations.
In the new system, this approach will result into increased number of
getUpdates requests from the one device clients, since for them the invalidations
will never be marked as enabled.

Bug: 880056
Change-Id: Ie5ba30bd4cd214f445dcc3c7ca027a3b268a46d6
Reviewed-on: https://chromium-review.googlesource.com/c/1384044
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617824}
[modify] https://crrev.com/5a09895cf4d4ce0b5d4f620b1c82180152f02913/components/invalidation/impl/fcm_network_handler.cc

Sign in to add a comment