Regression: Focus ring is not seen on "Done" button after selecting any wallpaper from collection overlay
Reported by
khushal....@etouch.net,
Sep 3
|
||||||
Issue descriptionChrome Version: 71.0.3541.0 (Official Build) Revision 5b7432c268333c962bdf8bc3280f2d33baf00932-refs/branch-heads/3541@{#1} (64-bit) OS: Mac (10.12.6, 10.13.1, 10.13.6, 10.14), Win (7, 8, 8.1, 10) & Linux (14.04 LTS) Pre-condition: Enable the flag "Enable using the Google local NTP" & "New Tab Page Background Selection" from chrome://flags/ What steps will reproduce the problem? (1) Launch chrome, open NTP, click on gear icon then select 'Chrome backgrounds' option ('Select a collection' overlay will open) and select any collection. (2) Select any wallpaper ('Done' button will get enabled). (3) Now try to traverse the focus on "Done" button and Observe. Actual Result: Focus ring is not seen on "Done" button of Wallpaper collection overlay. Expected Result: Focus ring should be seen on "Done" button of Wallpaper collection overlay. This is a Regression issue seen from 'M-71' and providing the bisect info below: Good Build: 71.0.3539.0 (Revision: 588236) Bad Build: 71.0.3540.0 (Revision: 588296) (Unable to provide bisect using per-revision script as "[Errno 2] No such file or directory" error message is thrown, hence providing narrow bisect) Narrow Bisect details: You are probably looking for a change made after 588251 (known good), but no later than 588265 (first known bad). CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/92940c99a682f67d32762308355c891d4f970852..e88b2130e1e8cf39ad8c598923918ecfd5af7846 Suspecting: r588258 ?? @sweilun: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Please refer the attached screen-cast. Thank You..!!
,
Sep 4
,
Sep 5
,
Sep 5
Update: Rechecked the above issue on Mac (10.12.6, 10.13.1, 10.13.6, 10.14), Win (7, 8, 8.1, 10) & Linux (14.04 LTS) using latest canary version #71.0.3543.0 and the issue is found Fixed. Hence, adding respective labels. Please refer the attached screen-cast. Thank You..!!
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f950b1e6ba8e339eb345b0771655aba13490e95 commit 6f950b1e6ba8e339eb345b0771655aba13490e95 Author: Weilun Shi <sweilun@chromium.org> Date: Tue Sep 04 19:38:54 2018 [NTP] Adding focus ring back to done when it is available Adding focus ring back to the done button on custom background dialog when it is available. Fixing the regression problem for previous CL id: 1196165. Bug: 880049 Change-Id: Ib280c3af292240320547c52cf03d218cb1fc0d79 Reviewed-on: https://chromium-review.googlesource.com/1203416 Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#588616} [modify] https://crrev.com/6f950b1e6ba8e339eb345b0771655aba13490e95/chrome/browser/resources/local_ntp/custom_backgrounds.css
,
Sep 10
,
Oct 9
Not reproducible in remote. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sweilun@chromium.org
, Sep 3