New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 880041 link

Starred by 2 users
Status: Fixed
Owner:
tetsui@chromium.org
Closed: Oct 19
Cc:
ajha@chromium.org
tetsui@chromium.org
█ yoshiki@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 816350



Sign in to add a comment

Non-Regression : Add 'Change' option in Lock screen to tab focus cycle

Project Member Reported by mmanchala@chromium.org, Sep 3 
Chrome Version: 70.0.3538.0/11030.0.0 dev channel Daisy,Kip and Celes
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> click on Uber Tray and select 'Lock' option
(2)Now in Lock screen click on Uber Tray -> observe 'Notifications are hidden" and 'change' button is seen
(2)Now press 'tab' and observe focus is not seen on 'change' option but able to click on 'Change' option 
(Please refer Video)

Expected: Tab focus should be seen on 'Change' option
Actual: Instead Tab focus is seen missing on 'Change' option


This is Non-Regression Issue as 'Change' option is seen from 70.0.3538.0

Comment 1 by mmanchala@chromium.org, Sep 3

Actual_TabFocus.mp4
17.2 MB Download

Comment 2 by tetsui@chromium.org, Sep 5

Owner: tetsui@chromium.org

Comment 3 by tetsui@chromium.org, Sep 21

Cc: yoshiki@chromium.org
Labels: -M-70 M-71
Status: Assigned (was: Untriaged)
Summary: Non-Regression : Add 'Change' option in Lock screen to tab focus cycle (was: Non-Regression : Tab focus is seen missing on 'Change' option in Lock screen)
Lock screen notification is disabled on M70.

Comment 4 by tetsui@chromium.org, Sep 27

Blocking: 816350

Comment 5 by tetsui@chromium.org, Oct 17

Labels: -M-71 M-73
Lock screen notification is punted to M73

Comment 6 by tetsui@chromium.org, Oct 18

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01e6b4ad120d26f2f7090eba9e49e6156cc316d2

commit 01e6b4ad120d26f2f7090eba9e49e6156cc316d2
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Fri Oct 19 01:37:44 2018

Unified: Improve focus cycle of UnifiedSystemTray

This CL makes following improvements:
* Now first time Shift-Tab will focus on "Clear All" button.
* Now "Change" button for lock screen notification is included in
  focus cycle.

TEST=manual
BUG= 880041 

Change-Id: I3185936e505755a9d0de19c4425c285b3337e9ad
Reviewed-on: https://chromium-review.googlesource.com/c/1288110
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601014}
[modify] https://crrev.com/01e6b4ad120d26f2f7090eba9e49e6156cc316d2/ash/system/unified/unified_system_tray_view.cc

Comment 8 by tetsui@chromium.org, Oct 19

Status: Fixed (was: Started)
►

Sign in to add a comment