Issue metadata
Sign in to add a comment
|
Link copied toast message is not displayed on copying the URL from share menu |
||||||||||||||||||||||
Issue descriptionApp Version: 70.0.3537.0 beta iOS Version: 11.4.1, 10.3.3, 12 beta 12 Device: iPhone, iPad Steps to reproduce: 1. Launch chrome 2. Go to any webpage say http://www.google.com 3. Tap on the share button 4. Tap on copy button Observed results: Notice that no link copied toast message is displayed Note: Link copied toast message is also not displayed in non UI-Refresh Expected results: Link copied toast message should be displayed Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): No on M68 Bug reproducible on the current beta channel build (App Version, iOS Version): No on M69 beta Link to video: M69 behavior: https://drive.google.com/file/d/1FeqUAEDDXdteFaCZ8T0tNevhYXGqCNwL/view?usp=sharing M70 behavior: https://drive.google.com/file/d/1JloLPMrquLNn1T915rasx62BNKZlBz0u/view?usp=sharing
,
Sep 3
,
Sep 5
gambard@ git blame shows gambard@ may have made changes here recently, and I believe pkl@ is an owner for 'share'. Adding both for investigation.
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/243bc7a0a211a164e9dfdb7df828864e2b0fa7aa commit 243bc7a0a211a164e9dfdb7df828864e2b0fa7aa Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Sep 14 10:52:06 2018 [iOS] Add snackbar for the copy action This CL adds a snackbar for the copy action from the share menu. It also consolidates metrics for the different actions of the share menu. Bug: 880030 , 883642 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I9ad39ad2f4f9b34e4d26aacc12a9db1fb2364bb6 Reviewed-on: https://chromium-review.googlesource.com/1224311 Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#591320} [modify] https://crrev.com/243bc7a0a211a164e9dfdb7df828864e2b0fa7aa/ios/chrome/browser/ui/activity_services/activities/bookmark_activity.mm [modify] https://crrev.com/243bc7a0a211a164e9dfdb7df828864e2b0fa7aa/ios/chrome/browser/ui/activity_services/activities/find_in_page_activity.mm [modify] https://crrev.com/243bc7a0a211a164e9dfdb7df828864e2b0fa7aa/ios/chrome/browser/ui/activity_services/activities/reading_list_activity.mm [modify] https://crrev.com/243bc7a0a211a164e9dfdb7df828864e2b0fa7aa/ios/chrome/browser/ui/activity_services/activity_type_util.h [modify] https://crrev.com/243bc7a0a211a164e9dfdb7df828864e2b0fa7aa/ios/chrome/browser/ui/activity_services/activity_type_util.mm [modify] https://crrev.com/243bc7a0a211a164e9dfdb7df828864e2b0fa7aa/tools/metrics/actions/actions.xml
,
Sep 17
Verified in Canary. Merge request.
,
Sep 17
This bug requires manual review: Less than 25 days to go before AppStore submit on M70 Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 17
Approved.
,
Sep 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36861adff6ca785c012d45eae124987eda160645 commit 36861adff6ca785c012d45eae124987eda160645 Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Sep 17 15:18:06 2018 [iOS] Add snackbar for the copy action This CL adds a snackbar for the copy action from the share menu. It also consolidates metrics for the different actions of the share menu. Bug: 880030 , 883642 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I9ad39ad2f4f9b34e4d26aacc12a9db1fb2364bb6 Reviewed-on: https://chromium-review.googlesource.com/1224311 Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#591320}(cherry picked from commit 243bc7a0a211a164e9dfdb7df828864e2b0fa7aa) Reviewed-on: https://chromium-review.googlesource.com/1228196 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#446} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/36861adff6ca785c012d45eae124987eda160645/ios/chrome/browser/ui/activity_services/activities/bookmark_activity.mm [modify] https://crrev.com/36861adff6ca785c012d45eae124987eda160645/ios/chrome/browser/ui/activity_services/activities/find_in_page_activity.mm [modify] https://crrev.com/36861adff6ca785c012d45eae124987eda160645/ios/chrome/browser/ui/activity_services/activities/reading_list_activity.mm [modify] https://crrev.com/36861adff6ca785c012d45eae124987eda160645/ios/chrome/browser/ui/activity_services/activity_type_util.h [modify] https://crrev.com/36861adff6ca785c012d45eae124987eda160645/ios/chrome/browser/ui/activity_services/activity_type_util.mm [modify] https://crrev.com/36861adff6ca785c012d45eae124987eda160645/tools/metrics/actions/actions.xml
,
Sep 18
Issue verified Version: Chrome Canary 71.0.3555.0 Device: iPhone 8 iOS: 12.0 Copied link toast message shows up https://drive.google.com/open?id=15Gpae0mr9MHE3mRnRDC99ngqIw-9W1E8
,
Sep 19
Verified in: App Version: 70.0.3538.22 beta Devices: iPhone 7 Plus, iPhone 6 Plus, iPhone 8 Plus, iPad Mini iOS Version: 10.3.3, 11.4.1, 12.0 'Link Copied' toast message is displayed Video: https://drive.google.com/open?id=1m3nXOVWa6bKGgMkhARYuakiT2cw7rwco |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rakurati@chromium.org
, Sep 3