New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug


Sign in to add a comment
link

Issue 880027: Create separate ResourceFetcher/FetchContexts for inside/outsideSettings

Reported by hirosh...@chromium.org, Sep 3 Project Member

Issue description

In workers/worklets, there are two "settings objects" used for fetching:
- inside settings object, corresponding to the worker/worklet global scope, used for subresource fetching in workers, and
- outside settings object, corresponding to parent Document (or parent worker in nested cases), used for top-level worker script fetching.

In off-the-main-thread world, both of these are done in the worker/worklet threads, but currently using a single ResourceFetcher/WorkerFetchContext that behaves sometimes like the inside settings object and sometimes like the outside settings object.

To implement more off-the-main-thread fetch easily, secure and spec-conformant, this issue creates two ResourceFetcher and WorkerFetchContext, one for inside and one for outside settings object, and use correct ResourceFetcher/WorkerFetchContext instead of mixing two behaviors in a single FetchContext.

Design doc to be created.
 

Comment 1 by hirosh...@chromium.org, Sep 3

Blockedon: 880015
Blocking: 878274
Summary: Create separate ResourceFetcher/FetchContexts for inside/outsideSettings (was: Off-the-main-thread-fetch: Create separate ResourceFetcher/FetchContexts for inside/outsideSettings)

Comment 2 by bugdroid1@chromium.org, Sep 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85ef12e4845a8fdfcc00517ba61c5ebc3fd6416c

commit 85ef12e4845a8fdfcc00517ba61c5ebc3fd6416c
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Fri Sep 07 09:46:26 2018

Worker: Move UpgradeInsecureRequest() to PopulateResourceRequest()

Currently, UpgradeInsecureRequest() is called in
WorkerFetchContext::PrepareRequest(), which is called after
mixed content check.
Therefore, insecure requests are blocked as mixed content
before upgraded.

This CL moves the UpgradeInsecureRequest() call to
WorkerFetchContext::PopulateResourceRequest(), which is called
before mixed content check.
This is also consistent with FrameFetchContext, where
insecure request is upgraded in
FrameFetchContext::PopulateResourceRequest().

Bug: 880986,  880023 ,  880015 , 880027
Change-Id: I983a40eebda8d04698b70d8c29e3707d4dcdf838
Reviewed-on: https://chromium-review.googlesource.com/1205750
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589478}
[modify] https://crrev.com/85ef12e4845a8fdfcc00517ba61c5ebc3fd6416c/third_party/blink/renderer/core/loader/worker_fetch_context.cc

Comment 3 by bugdroid1@chromium.org, Sep 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5

commit f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Tue Sep 11 19:34:28 2018

Move FetchClientSettingsObject to platform/loader

To expose FetchClientSettingsObject in FetchContext in
https://chromium-review.googlesource.com/1200042,
this CL moves FetchClientSettingsObject to platform/.

Bug: 880027
Change-Id: I71c9eac42fc561e58742398cfa229b21c31662c7
Reviewed-on: https://chromium-review.googlesource.com/1198889
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590439}
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/execution_context/execution_context.cc
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/execution_context/execution_context.h
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/loader/base_fetch_context.h
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/loader/link_loader.cc
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/loader/modulescript/module_script_loader.cc
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.h
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_registry.cc
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_test.cc
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/script/BUILD.gn
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/script/dynamic_module_resolver.cc
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/script/fetch_client_settings_object_impl.h
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/script/modulator_impl_base.cc
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/script/module_map_test.cc
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/script/script_loader.cc
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/workers/dedicated_worker.cc
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/workers/dedicated_worker_global_scope.cc
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/workers/experimental/thread_pool.cc
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/workers/threaded_worklet_messaging_proxy.cc
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/workers/threaded_worklet_object_proxy.cc
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/workers/worker_thread.cc
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/workers/worklet.cc
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/core/workers/worklet_global_scope.cc
[modify] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/platform/loader/BUILD.gn
[rename] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object.h
[rename] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object_snapshot.cc
[rename] https://crrev.com/f0d0742b9cd4a946ca5fc15a9288cf1beabbe9e5/third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object_snapshot.h

Comment 4 by bugdroid1@chromium.org, Sep 17

Project Member
Labels: merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ecbff63d7872264433cb0fa827e880342c10072

commit 6ecbff63d7872264433cb0fa827e880342c10072
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Mon Sep 17 19:16:33 2018

Worker: Move UpgradeInsecureRequest() to PopulateResourceRequest()

Currently, UpgradeInsecureRequest() is called in
WorkerFetchContext::PrepareRequest(), which is called after
mixed content check.
Therefore, insecure requests are blocked as mixed content
before upgraded.

This CL moves the UpgradeInsecureRequest() call to
WorkerFetchContext::PopulateResourceRequest(), which is called
before mixed content check.
This is also consistent with FrameFetchContext, where
insecure request is upgraded in
FrameFetchContext::PopulateResourceRequest().

Bug: 880986,  880023 ,  880015 , 880027
Change-Id: I983a40eebda8d04698b70d8c29e3707d4dcdf838
Reviewed-on: https://chromium-review.googlesource.com/1205750
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589478}(cherry picked from commit 85ef12e4845a8fdfcc00517ba61c5ebc3fd6416c)
Reviewed-on: https://chromium-review.googlesource.com/1228779
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#452}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/6ecbff63d7872264433cb0fa827e880342c10072/third_party/blink/renderer/core/loader/worker_fetch_context.cc

Comment 5 by nhiroki@chromium.org, Oct 24

Blocking: 835717

Comment 6 by hirosh...@chromium.org, Nov 8

Blockedon: 903579

Comment 7 by bugdroid1@chromium.org, Nov 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4589f59d07ff5e625bc57d6cf03cb9438d8180b

commit d4589f59d07ff5e625bc57d6cf03cb9438d8180b
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Fri Nov 09 00:29:28 2018

Remove WorkerFetchContextHolder

Keeping scoped_refptr<WebWorkerFetchContext> in WorkerFetchContextHolder
cause WebWorkerFetchContext destruction on the main thread, because
WorkerFetchContextHolder is destructed on the main thread.

To avoid this, this CL passes WebWorkerFetchContext via
GlobalScopeCreationParams to WorkerOrWorkletGlobalScope.

This CL doesn't change the behavior.

Bug: 880027
Change-Id: Idab91d31cafdb33b264662c5f1bef126d93ba9f3
Reviewed-on: https://chromium-review.googlesource.com/c/1198891
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606649}
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/core/layout/custom/layout_worklet_global_scope_proxy.cc
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/core/loader/worker_fetch_context.h
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/core/workers/dedicated_worker.cc
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/core/workers/dedicated_worker_test.cc
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/core/workers/experimental/thread_pool.cc
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/core/workers/global_scope_creation_params.cc
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/core/workers/global_scope_creation_params.h
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/core/workers/main_thread_worklet_test.cc
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/core/workers/threaded_messaging_proxy_base.cc
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/core/workers/threaded_worklet_messaging_proxy.cc
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/core/workers/threaded_worklet_test.cc
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/core/workers/worker_global_scope.cc
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.h
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/core/workers/worker_thread_test.cc
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/core/workers/worker_thread_test_helper.h
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/core/workers/worklet_global_scope.cc
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/modules/animationworklet/animation_worklet_global_scope_test.cc
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/modules/csspaint/paint_worklet_global_scope_proxy.cc
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/modules/csspaint/paint_worklet_global_scope_test.cc
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/modules/webaudio/audio_worklet_global_scope_test.cc
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/modules/webaudio/audio_worklet_thread_test.cc
[modify] https://crrev.com/d4589f59d07ff5e625bc57d6cf03cb9438d8180b/third_party/blink/renderer/modules/worklet/animation_and_paint_worklet_thread_test.cc

Comment 8 by bugdroid1@chromium.org, Nov 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3be0467c26405d8e7f9bfea484d94a79c75522b9

commit 3be0467c26405d8e7f9bfea484d94a79c75522b9
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Fri Nov 09 02:27:39 2018

Make WebWorkerFetchContext RefCounted

To share WebWorkerFetchContext from multiple FetchContext.

This CL doesn't change the behavior.

Bug: 880027
Change-Id: I09a8eb8355c5186ffd22456400ae934f586996c2
Reviewed-on: https://chromium-review.googlesource.com/c/1198679
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606708}
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/content/renderer/loader/web_worker_fetch_context_impl.cc
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/content/renderer/loader/web_worker_fetch_context_impl.h
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/content/renderer/render_frame_impl.h
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/content/renderer/service_worker/service_worker_fetch_context_impl.h
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/content/renderer/shared_worker/embedded_shared_worker_stub.h
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/third_party/blink/public/platform/web_worker_fetch_context.h
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/third_party/blink/public/web/modules/service_worker/web_service_worker_context_client.h
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/third_party/blink/public/web/web_local_frame_client.h
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/third_party/blink/public/web/web_shared_worker_client.h
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/third_party/blink/renderer/core/exported/local_frame_client_impl.cc
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/third_party/blink/renderer/core/exported/local_frame_client_impl.h
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/third_party/blink/renderer/core/frame/local_frame_client.h
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/third_party/blink/renderer/core/loader/worker_fetch_context.h
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/third_party/blink/renderer/core/workers/global_scope_creation_params.cc
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/third_party/blink/renderer/core/workers/global_scope_creation_params.h
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/third_party/blink/renderer/core/workers/threaded_messaging_proxy_base.cc
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.h
[modify] https://crrev.com/3be0467c26405d8e7f9bfea484d94a79c75522b9/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc

Comment 9 by bugdroid1@chromium.org, Nov 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb193cc583121820faf4c42d3debb2aeb1e50754

commit cb193cc583121820faf4c42d3debb2aeb1e50754
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Fri Nov 09 07:34:15 2018

Move GetFetchClientSettingsObject() to FetchContext

As preparation for plumbing FetchClientSettingsObject via
FetchContext rather than as an argument,
this CL exposes GetFetchClientSettingsObject() in FetchContext.

NullFetchContext is added just to make
FetchContext::GetFetchClientSettingsObject() abstract and
FetchContext::NullInstance()'s GetFetchClientSettingsObject()
non-null.

This CL doesn't change the behavior.

Bug: 880027
Change-Id: I02a428d77d202ab88cffd22a3fdf3cd34eff4aca
Reviewed-on: https://chromium-review.googlesource.com/c/1200042
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606759}
[modify] https://crrev.com/cb193cc583121820faf4c42d3debb2aeb1e50754/third_party/blink/renderer/core/loader/base_fetch_context.h
[modify] https://crrev.com/cb193cc583121820faf4c42d3debb2aeb1e50754/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/cb193cc583121820faf4c42d3debb2aeb1e50754/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/cb193cc583121820faf4c42d3debb2aeb1e50754/third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h

Comment 10 by bugdroid1@chromium.org, Nov 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ede5922f5c054c81b5ea049651775ab0503582c

commit 7ede5922f5c054c81b5ea049651775ab0503582c
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Fri Nov 09 14:46:31 2018

Enable multiple WorkerFetchContext per one global scope

Currently WorkerFetchContext has the ownership of
some objects originated from WebWorkerFetchContext.
To create multiple WorkerFetchContexts
for one WorkerOrWorkletGlobalScope/WebWorkerFetchContext,
this CL moves these ownership outside WorkerFetchContext.
Namely,
- url_loader_factory_ and script_loader_factory_
  from WorkerFetchContext to WebWorketFetchContext subclasses, and
- subresource_filter_ from WorkerFetchContext to
  WorkerOrWorkletGlobalScope.
  Still |WorkerFetchContext::subresource_filter_| is kept, but
  it is created in WorkerOrWorkletGlobalScope and passed to
  WorkerFetchContext.

This CL doesn't change the observable behavior.
This CL creates WebURLLoaderFactory a little more eagerly, i.e.
when WorkerFetchContext is created,
while previously it was created when
WorkerFetchContext::CreateURLLoader() is called for the first time.

Bug: 880027, 903579
Change-Id: I84a8bafee25b7f293201a271d198260e2dfb8e68
Reviewed-on: https://chromium-review.googlesource.com/c/1193385
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606835}
[modify] https://crrev.com/7ede5922f5c054c81b5ea049651775ab0503582c/content/renderer/loader/web_worker_fetch_context_impl.cc
[modify] https://crrev.com/7ede5922f5c054c81b5ea049651775ab0503582c/content/renderer/loader/web_worker_fetch_context_impl.h
[modify] https://crrev.com/7ede5922f5c054c81b5ea049651775ab0503582c/content/renderer/service_worker/service_worker_fetch_context_impl.cc
[modify] https://crrev.com/7ede5922f5c054c81b5ea049651775ab0503582c/content/renderer/service_worker/service_worker_fetch_context_impl.h
[modify] https://crrev.com/7ede5922f5c054c81b5ea049651775ab0503582c/third_party/blink/public/platform/web_worker_fetch_context.h
[modify] https://crrev.com/7ede5922f5c054c81b5ea049651775ab0503582c/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/7ede5922f5c054c81b5ea049651775ab0503582c/third_party/blink/renderer/core/loader/worker_fetch_context.h
[modify] https://crrev.com/7ede5922f5c054c81b5ea049651775ab0503582c/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/7ede5922f5c054c81b5ea049651775ab0503582c/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.h

Comment 11 by bugdroid1@chromium.org, Nov 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2de0f9a45dc3e898f5c784f1054667d662c5e10

commit e2de0f9a45dc3e898f5c784f1054667d662c5e10
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Wed Nov 14 02:14:16 2018

Implement FetchClientSettingsObject::GetHttpsState()

Previously, FetchClientSettingsObjectImpl
- Is used as WorkerFetchContext's FetchClientSettingsObject,
- Implements GetHttpsState(), and
- Is used for checking mixed contents on workers.

Issue 880027 will introduce outsideSettings WorkerFetchContext
which will have FetchClientSettingsObjectSnapshot as its
FetchClientSettingsObject [1].

Therefore, this CL switches
- WorkerFetchContext's FetchClientSettingsObject and
- MixedContentChecker::IsMixedContent()
to use FetchClientSettingsObject (not ...Impl), and
implements GetHttpsState() in FetchClientSettingsObject
and FetchClientSettingsObjectSnapshot.

This CL shouldn't change the behavior at this time, because
WorkerFetchContext's FetchClientSettingsObject is still
a FetchClientSettingsObjectImpl object, and thus mixed content
checks is done using already-implemented
FetchClientSettingsObjectImpl::GetHttpsState().

The code path added in this CL will be used in [2].

[1] https://chromium-review.googlesource.com/1328043
[2] https://chromium-review.googlesource.com/1328164

Bug: 880027
Change-Id: I399694bd239c21fe9b5a650fcb689fb2c98572f5
Reviewed-on: https://chromium-review.googlesource.com/c/1328162
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607860}
[modify] https://crrev.com/e2de0f9a45dc3e898f5c784f1054667d662c5e10/third_party/blink/renderer/core/execution_context/execution_context.cc
[modify] https://crrev.com/e2de0f9a45dc3e898f5c784f1054667d662c5e10/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/e2de0f9a45dc3e898f5c784f1054667d662c5e10/third_party/blink/renderer/core/loader/mixed_content_checker.cc
[modify] https://crrev.com/e2de0f9a45dc3e898f5c784f1054667d662c5e10/third_party/blink/renderer/core/loader/mixed_content_checker.h
[modify] https://crrev.com/e2de0f9a45dc3e898f5c784f1054667d662c5e10/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/e2de0f9a45dc3e898f5c784f1054667d662c5e10/third_party/blink/renderer/core/loader/worker_fetch_context.h
[modify] https://crrev.com/e2de0f9a45dc3e898f5c784f1054667d662c5e10/third_party/blink/renderer/core/script/fetch_client_settings_object_impl.h
[modify] https://crrev.com/e2de0f9a45dc3e898f5c784f1054667d662c5e10/third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object.h
[modify] https://crrev.com/e2de0f9a45dc3e898f5c784f1054667d662c5e10/third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object_snapshot.cc
[modify] https://crrev.com/e2de0f9a45dc3e898f5c784f1054667d662c5e10/third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object_snapshot.h
[modify] https://crrev.com/e2de0f9a45dc3e898f5c784f1054667d662c5e10/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/e2de0f9a45dc3e898f5c784f1054667d662c5e10/third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h

Comment 12 by bugdroid1@chromium.org, Nov 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8227f1454fb16660f418abacdf814b8e6cba4c81

commit 8227f1454fb16660f418abacdf814b8e6cba4c81
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Wed Nov 14 09:03:19 2018

Introduce WorkerOrWorkletGlobalScope::CreateOutsideSettingsFetcher()

This CL
- Introduces CreateOutsideSettingsFetcher() that will be used in
  https://chromium-review.googlesource.com/1328164
- Extends pause/unpause mechanism that has been implemented for
  existing (insideSettings) ResourceFetcher to cover
  ResourceFetchers created by CreateOutsideSettingsFetcher().

This CL shouldn't change the behavior.

Bug: 880027
Change-Id: Ifa21b4d31f6d01fa7a9021410d5aa95a7bbf0a78
Reviewed-on: https://chromium-review.googlesource.com/c/1328043
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607939}
[modify] https://crrev.com/8227f1454fb16660f418abacdf814b8e6cba4c81/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/8227f1454fb16660f418abacdf814b8e6cba4c81/third_party/blink/renderer/core/loader/worker_fetch_context.h
[modify] https://crrev.com/8227f1454fb16660f418abacdf814b8e6cba4c81/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/8227f1454fb16660f418abacdf814b8e6cba4c81/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.h

Comment 13 by bugdroid1@chromium.org, Nov 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ee777f6ec979c89fe8e35559b6b1556b97a3775

commit 5ee777f6ec979c89fe8e35559b6b1556b97a3775
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Mon Nov 19 21:04:14 2018

Fix test exclusion logic of wpt/referrer-policy test generator

Previously, all worker-request, a-tag, area-tag tests were excluded
because "redirection" field was not included in |selection_pattern|,
and thus "worker-requests-with-swap-origin-redirect" and
"overhead-for-redirection" entries in "excluded_tests" in spec.src.json
were applied to all redirection types.

This CL
- Includes "redirection" field in |selection_pattern| and
  instead remove "redirection" field from filenames, and
- Regenerates tests.

Therefore, this CL
- Adds new test files for worker-request, a-tag, area-tag, and
- Renames existing test files.

The only manual changes are
- referrer-policy/generic/tools/common_paths.py
- third_party/WebKit/LayoutTests/SlowTests
- third_party/WebKit/LayoutTests/SmokeTests
and all other modifications are made by
referrer-policy/generic/tools/generate.py.

Bug: 880027
Change-Id: Ie628f92b334d6e2adddc5957cc6cceaa8c69f322
Reviewed-on: https://chromium-review.googlesource.com/c/1330901
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609433}
[modify] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/SmokeTests
[modify] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/generic/tools/common_paths.py
[copy] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/cross-origin/http-http/a-tag/no-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/cross-origin/http-http/iframe-tag/keep-origin-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/cross-origin/http-http/iframe-tag/no-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/cross-origin/http-http/iframe-tag/swap-origin-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/cross-origin/http-http/img-tag/keep-origin-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/cross-origin/http-http/img-tag/no-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/cross-origin/http-http/img-tag/swap-origin-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/cross-origin/http-http/script-tag/keep-origin-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/cross-origin/http-http/script-tag/no-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/cross-origin/http-http/script-tag/swap-origin-redirect/insecure-protocol.http.html
[copy] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/cross-origin/http-https/a-tag/no-redirect/upgrade-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/cross-origin/http-https/iframe-tag/keep-origin-redirect/upgrade-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/cross-origin/http-https/iframe-tag/no-redirect/upgrade-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/cross-origin/http-https/iframe-tag/swap-origin-redirect/upgrade-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/cross-origin/http-https/img-tag/keep-origin-redirect/upgrade-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/cross-origin/http-https/img-tag/no-redirect/upgrade-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/cross-origin/http-https/img-tag/swap-origin-redirect/upgrade-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/cross-origin/http-https/script-tag/keep-origin-redirect/upgrade-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/cross-origin/http-https/script-tag/no-redirect/upgrade-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/cross-origin/http-https/script-tag/swap-origin-redirect/upgrade-protocol.http.html
[copy] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/same-origin/http-http/a-tag/no-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/same-origin/http-http/iframe-tag/keep-origin-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/same-origin/http-http/iframe-tag/no-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/same-origin/http-http/iframe-tag/swap-origin-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/same-origin/http-http/img-tag/keep-origin-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/same-origin/http-http/img-tag/no-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/same-origin/http-http/img-tag/swap-origin-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/same-origin/http-http/script-tag/keep-origin-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/same-origin/http-http/script-tag/no-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/same-origin/http-http/script-tag/swap-origin-redirect/insecure-protocol.http.html
[copy] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/same-origin/http-https/a-tag/no-redirect/upgrade-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/same-origin/http-https/iframe-tag/keep-origin-redirect/upgrade-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/same-origin/http-https/iframe-tag/no-redirect/upgrade-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/same-origin/http-https/iframe-tag/swap-origin-redirect/upgrade-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/same-origin/http-https/img-tag/keep-origin-redirect/upgrade-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/same-origin/http-https/img-tag/no-redirect/upgrade-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/same-origin/http-https/img-tag/swap-origin-redirect/upgrade-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/same-origin/http-https/script-tag/keep-origin-redirect/upgrade-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/same-origin/http-https/script-tag/no-redirect/upgrade-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/attr-referrer/same-origin/http-https/script-tag/swap-origin-redirect/upgrade-protocol.http.html
[copy] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/a-tag/no-redirect/insecure-protocol.http.html
[copy] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/a-tag/no-redirect/insecure-protocol.http.html.headers
[delete] https://crrev.com/e5e23f0b861e0cef2c646d352abd45d7e90662e0/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/fetch-request/insecure-protocol.keep-origin-redirect.http.html.headers
[delete] https://crrev.com/e5e23f0b861e0cef2c646d352abd45d7e90662e0/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/fetch-request/insecure-protocol.swap-origin-redirect.http.html.headers
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/fetch-request/keep-origin-redirect/insecure-protocol.http.html
[copy] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/fetch-request/keep-origin-redirect/insecure-protocol.http.html.headers
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/fetch-request/no-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/fetch-request/no-redirect/insecure-protocol.http.html.headers
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/fetch-request/swap-origin-redirect/insecure-protocol.http.html
[copy] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/fetch-request/swap-origin-redirect/insecure-protocol.http.html.headers
[delete] https://crrev.com/e5e23f0b861e0cef2c646d352abd45d7e90662e0/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/iframe-tag/insecure-protocol.keep-origin-redirect.http.html.headers
[delete] https://crrev.com/e5e23f0b861e0cef2c646d352abd45d7e90662e0/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/iframe-tag/insecure-protocol.swap-origin-redirect.http.html.headers
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/iframe-tag/keep-origin-redirect/insecure-protocol.http.html
[copy] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/iframe-tag/keep-origin-redirect/insecure-protocol.http.html.headers
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/iframe-tag/no-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/iframe-tag/no-redirect/insecure-protocol.http.html.headers
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/iframe-tag/swap-origin-redirect/insecure-protocol.http.html
[copy] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/iframe-tag/swap-origin-redirect/insecure-protocol.http.html.headers
[delete] https://crrev.com/e5e23f0b861e0cef2c646d352abd45d7e90662e0/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/img-tag/insecure-protocol.keep-origin-redirect.http.html.headers
[delete] https://crrev.com/e5e23f0b861e0cef2c646d352abd45d7e90662e0/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/img-tag/insecure-protocol.swap-origin-redirect.http.html.headers
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/img-tag/keep-origin-redirect/insecure-protocol.http.html
[copy] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/img-tag/keep-origin-redirect/insecure-protocol.http.html.headers
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/img-tag/no-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/img-tag/no-redirect/insecure-protocol.http.html.headers
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/img-tag/swap-origin-redirect/insecure-protocol.http.html
[copy] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/img-tag/swap-origin-redirect/insecure-protocol.http.html.headers
[delete] https://crrev.com/e5e23f0b861e0cef2c646d352abd45d7e90662e0/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/script-tag/insecure-protocol.keep-origin-redirect.http.html.headers
[delete] https://crrev.com/e5e23f0b861e0cef2c646d352abd45d7e90662e0/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/script-tag/insecure-protocol.swap-origin-redirect.http.html.headers
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/script-tag/keep-origin-redirect/insecure-protocol.http.html
[copy] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/script-tag/keep-origin-redirect/insecure-protocol.http.html.headers
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/script-tag/no-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/script-tag/no-redirect/insecure-protocol.http.html.headers
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/script-tag/swap-origin-redirect/insecure-protocol.http.html
[copy] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/script-tag/swap-origin-redirect/insecure-protocol.http.html.headers
[delete] https://crrev.com/e5e23f0b861e0cef2c646d352abd45d7e90662e0/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/xhr-request/insecure-protocol.keep-origin-redirect.http.html.headers
[delete] https://crrev.com/e5e23f0b861e0cef2c646d352abd45d7e90662e0/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/xhr-request/insecure-protocol.swap-origin-redirect.http.html.headers
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/xhr-request/keep-origin-redirect/insecure-protocol.http.html
[copy] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/xhr-request/keep-origin-redirect/insecure-protocol.http.html.headers
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/xhr-request/no-redirect/insecure-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/xhr-request/no-redirect/insecure-protocol.http.html.headers
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/xhr-request/swap-origin-redirect/insecure-protocol.http.html
[copy] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-http/xhr-request/swap-origin-redirect/insecure-protocol.http.html.headers
[copy] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-https/a-tag/no-redirect/upgrade-protocol.http.html
[copy] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-https/a-tag/no-redirect/upgrade-protocol.http.html.headers
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-https/fetch-request/keep-origin-redirect/upgrade-protocol.http.html
[copy] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-https/fetch-request/keep-origin-redirect/upgrade-protocol.http.html.headers
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-https/fetch-request/no-redirect/upgrade-protocol.http.html
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-https/fetch-request/no-redirect/upgrade-protocol.http.html.headers
[rename] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-https/fetch-request/swap-origin-redirect/upgrade-protocol.http.html
[copy] https://crrev.com/5ee777f6ec979c89fe8e35559b6b1556b97a3775/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-https/fetch-request/swap-origin-redirect/upgrade-protocol.http.html.headers
[delete] https://crrev.com/e5e23f0b861e0cef2c646d352abd45d7e90662e0/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http-https/fetch-request/upgrade-protocol.keep-origin-redirect.http.html.headers
[delete] https://crrev.com/e5e23f0b861e0cef2c646d352abd45d7e90662e0/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/cross-origin/http

Comment 14 by hirosh...@chromium.org, Nov 19

Blockedon: 906850

Comment 16 by bugdroid1@chromium.org, Nov 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec589a5ce0cd6d297605922119065cc2805d8db9

commit ec589a5ce0cd6d297605922119065cc2805d8db9
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Tue Nov 20 03:55:30 2018

Add referrer-policy module worker tests

This CL adds WPT tests for referrer policy applied to
module worker top-level script fetch.

The only manual changes are
- referrer-policy/generic/common.js
- referrer-policy/generic/referrer-policy-test-case.js
- referrer-policy/spec.src.json
and all other modifications are made by
referrer-policy/generic/tools/generate.py.

Bug: 880027
Change-Id: Ib1f9136161e8efacf317fb9b7e9ba0651a103c41
Reviewed-on: https://chromium-review.googlesource.com/c/1330906
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609589}
[modify] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/generic/common.js
[modify] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/generic/referrer-policy-test-case.js
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html.headers
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html.headers
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/meta-referrer/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html.headers
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer/http-rp/same-origin/http-http/module-worker/no-redirect/generic.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer/http-rp/same-origin/http-http/module-worker/no-redirect/generic.http.html.headers
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer/meta-referrer/same-origin/http-http/module-worker/no-redirect/generic.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/same-origin-insecure.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/same-origin-insecure.http.html.headers
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/no-redirect/same-origin-insecure.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/no-redirect/same-origin-insecure.http.html.headers
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/same-origin-insecure.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-http/module-worker/no-redirect/same-origin-insecure.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html.headers
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin/http-rp/same-origin/http-http/module-worker/no-redirect/generic.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin/http-rp/same-origin/http-http/module-worker/no-redirect/generic.http.html.headers
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin/meta-referrer/same-origin/http-http/module-worker/no-redirect/generic.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/same-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/same-origin-insecure.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/same-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/same-origin-insecure.http.html.headers
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/same-origin/http-rp/same-origin/http-http/module-worker/no-redirect/same-origin-insecure.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/same-origin/http-rp/same-origin/http-http/module-worker/no-redirect/same-origin-insecure.http.html.headers
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/same-origin/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/same-origin-insecure.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/same-origin/meta-referrer/same-origin/http-http/module-worker/no-redirect/same-origin-insecure.http.html
[modify] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/spec.src.json
[modify] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/spec_json.js
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/same-insecure.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/same-insecure.http.html.headers
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/no-redirect/same-insecure.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/no-redirect/same-insecure.http.html.headers
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin-when-cross-origin/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/same-insecure.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin-when-cross-origin/meta-referrer/same-origin/http-http/module-worker/no-redirect/same-insecure.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html.headers
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin/http-rp/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin/http-rp/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html.headers
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin/meta-referrer/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unsafe-url/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unsafe-url/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html.headers
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unsafe-url/http-rp/same-origin/http-http/module-worker/no-redirect/generic.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unsafe-url/http-rp/same-origin/http-http/module-worker/no-redirect/generic.http.html.headers
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unsafe-url/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unsafe-url/meta-referrer/same-origin/http-http/module-worker/no-redirect/generic.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unset-referrer-policy/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unset-referrer-policy/http-rp/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unset-referrer-policy/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html
[add] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unset-referrer-policy/meta-referrer/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html

Comment 17 by bugdroid1@chromium.org, Nov 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02c7f5d5693c6bb20ca28ab443c3eb7d5577ca18

commit 02c7f5d5693c6bb20ca28ab443c3eb7d5577ca18
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Tue Nov 20 17:02:18 2018

Revert "Add referrer-policy module worker tests"

This reverts commit ec589a5ce0cd6d297605922119065cc2805d8db9.

Reason for revert:  crbug.com/906964 

Original change's description:
> Add referrer-policy module worker tests
> 
> This CL adds WPT tests for referrer policy applied to
> module worker top-level script fetch.
> 
> The only manual changes are
> - referrer-policy/generic/common.js
> - referrer-policy/generic/referrer-policy-test-case.js
> - referrer-policy/spec.src.json
> and all other modifications are made by
> referrer-policy/generic/tools/generate.py.
> 
> Bug: 880027
> Change-Id: Ib1f9136161e8efacf317fb9b7e9ba0651a103c41
> Reviewed-on: https://chromium-review.googlesource.com/c/1330906
> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609589}

TBR=hiroshige@chromium.org,nhiroki@chromium.org,jochen@chromium.org

Change-Id: I0931159c0494b981a1d6b07232af55b20f68f559
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 880027,  906964 
Reviewed-on: https://chromium-review.googlesource.com/c/1344213
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609731}
[modify] https://crrev.com/02c7f5d5693c6bb20ca28ab443c3eb7d5577ca18/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/generic/common.js
[modify] https://crrev.com/02c7f5d5693c6bb20ca28ab443c3eb7d5577ca18/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/generic/referrer-policy-test-case.js
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html.headers
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html.headers
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/meta-referrer/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html.headers
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer/http-rp/same-origin/http-http/module-worker/no-redirect/generic.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer/http-rp/same-origin/http-http/module-worker/no-redirect/generic.http.html.headers
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer/meta-referrer/same-origin/http-http/module-worker/no-redirect/generic.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/same-origin-insecure.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/same-origin-insecure.http.html.headers
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/no-redirect/same-origin-insecure.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/no-redirect/same-origin-insecure.http.html.headers
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/same-origin-insecure.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-http/module-worker/no-redirect/same-origin-insecure.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html.headers
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin/http-rp/same-origin/http-http/module-worker/no-redirect/generic.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin/http-rp/same-origin/http-http/module-worker/no-redirect/generic.http.html.headers
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin/meta-referrer/same-origin/http-http/module-worker/no-redirect/generic.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/same-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/same-origin-insecure.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/same-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/same-origin-insecure.http.html.headers
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/same-origin/http-rp/same-origin/http-http/module-worker/no-redirect/same-origin-insecure.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/same-origin/http-rp/same-origin/http-http/module-worker/no-redirect/same-origin-insecure.http.html.headers
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/same-origin/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/same-origin-insecure.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/same-origin/meta-referrer/same-origin/http-http/module-worker/no-redirect/same-origin-insecure.http.html
[modify] https://crrev.com/02c7f5d5693c6bb20ca28ab443c3eb7d5577ca18/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/spec.src.json
[modify] https://crrev.com/02c7f5d5693c6bb20ca28ab443c3eb7d5577ca18/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/spec_json.js
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/same-insecure.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/same-insecure.http.html.headers
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/no-redirect/same-insecure.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/no-redirect/same-insecure.http.html.headers
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin-when-cross-origin/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/same-insecure.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin-when-cross-origin/meta-referrer/same-origin/http-http/module-worker/no-redirect/same-insecure.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html.headers
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin/http-rp/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin/http-rp/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html.headers
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin/meta-referrer/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unsafe-url/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unsafe-url/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html.headers
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unsafe-url/http-rp/same-origin/http-http/module-worker/no-redirect/generic.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unsafe-url/http-rp/same-origin/http-http/module-worker/no-redirect/generic.http.html.headers
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unsafe-url/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unsafe-url/meta-referrer/same-origin/http-http/module-worker/no-redirect/generic.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unset-referrer-policy/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unset-referrer-policy/http-rp/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unset-referrer-policy/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html
[delete] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unset-referrer-policy/meta-referrer/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html

Comment 18 by bugdroid1@chromium.org, Nov 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f1e2810ab8f2d368485771201f81952119e859a

commit 6f1e2810ab8f2d368485771201f81952119e859a
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Tue Nov 20 17:04:52 2018

Revert "Add off-main-thread-worker-script-fetch/external/wpt/referrer-policy"

This reverts commit 98dc58ecdac5a3cc4273426e24a19fff081b24c8.

Reason for revert:  crbug.com/906964 

Original change's description:
> Add off-main-thread-worker-script-fetch/external/wpt/referrer-policy
> 
> Bug: 835717, 880027
> Change-Id: I074ea4b911132477853bf95be70a36b7d62c4f79
> Reviewed-on: https://chromium-review.googlesource.com/c/1330903
> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609534}

TBR=hiroshige@chromium.org,nhiroki@chromium.org

Change-Id: Ic9c46e2efd39d774c3833aef324a654010f65bc2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 835717, 880027,  906964 
Reviewed-on: https://chromium-review.googlesource.com/c/1344257
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609732}
[modify] https://crrev.com/6f1e2810ab8f2d368485771201f81952119e859a/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6f1e2810ab8f2d368485771201f81952119e859a/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/02c7f5d5693c6bb20ca28ab443c3eb7d5577ca18/third_party/WebKit/LayoutTests/virtual/off-main-thread-worker-script-fetch/external/wpt/referrer-policy/README.txt

Comment 19 by bugdroid1@chromium.org, Nov 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01a03aab2d89c93c157c9af52dca7ac20d8ed96b

commit 01a03aab2d89c93c157c9af52dca7ac20d8ed96b
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Wed Nov 21 23:08:51 2018

Reland "Add referrer-policy module worker tests"

This reverts commit 02c7f5d5693c6bb20ca28ab443c3eb7d5577ca18.

Reason for revert: I expect crbug/906964 is fixed by reverting
another CL, so relanding this.

Original change's description:
> Revert "Add referrer-policy module worker tests"
>
> This reverts commit ec589a5ce0cd6d297605922119065cc2805d8db9.
>
> Reason for revert:  crbug.com/906964 
>
> Original change's description:
> > Add referrer-policy module worker tests
> >
> > This CL adds WPT tests for referrer policy applied to
> > module worker top-level script fetch.
> >
> > The only manual changes are
> > - referrer-policy/generic/common.js
> > - referrer-policy/generic/referrer-policy-test-case.js
> > - referrer-policy/spec.src.json
> > and all other modifications are made by
> > referrer-policy/generic/tools/generate.py.
> >
> > Bug: 880027
> > Change-Id: Ib1f9136161e8efacf317fb9b7e9ba0651a103c41
> > Reviewed-on: https://chromium-review.googlesource.com/c/1330906
> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> > Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#609589}
>
> TBR=hiroshige@chromium.org,nhiroki@chromium.org,jochen@chromium.org
>
> Change-Id: I0931159c0494b981a1d6b07232af55b20f68f559
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 880027,  906964 
> Reviewed-on: https://chromium-review.googlesource.com/c/1344213
> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609731}

TBR=hiroshige@chromium.org,nhiroki@chromium.org,jochen@chromium.org

Change-Id: I48d40a578e06526558fc7a4733395e1e505b9694
Bug: 880027,  906964 
Reviewed-on: https://chromium-review.googlesource.com/c/1344267
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610256}
[modify] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/generic/common.js
[modify] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/generic/referrer-policy-test-case.js
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html.headers
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/http-rp/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html.headers
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer-when-downgrade/meta-referrer/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html.headers
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer/http-rp/same-origin/http-http/module-worker/no-redirect/generic.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer/http-rp/same-origin/http-http/module-worker/no-redirect/generic.http.html.headers
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/no-referrer/meta-referrer/same-origin/http-http/module-worker/no-redirect/generic.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/same-origin-insecure.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/same-origin-insecure.http.html.headers
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/no-redirect/same-origin-insecure.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/no-redirect/same-origin-insecure.http.html.headers
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/same-origin-insecure.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-http/module-worker/no-redirect/same-origin-insecure.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html.headers
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin/http-rp/same-origin/http-http/module-worker/no-redirect/generic.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin/http-rp/same-origin/http-http/module-worker/no-redirect/generic.http.html.headers
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/origin/meta-referrer/same-origin/http-http/module-worker/no-redirect/generic.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/same-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/same-origin-insecure.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/same-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/same-origin-insecure.http.html.headers
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/same-origin/http-rp/same-origin/http-http/module-worker/no-redirect/same-origin-insecure.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/same-origin/http-rp/same-origin/http-http/module-worker/no-redirect/same-origin-insecure.http.html.headers
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/same-origin/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/same-origin-insecure.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/same-origin/meta-referrer/same-origin/http-http/module-worker/no-redirect/same-origin-insecure.http.html
[modify] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/spec.src.json
[modify] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/spec_json.js
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/same-insecure.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/same-insecure.http.html.headers
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/no-redirect/same-insecure.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin-when-cross-origin/http-rp/same-origin/http-http/module-worker/no-redirect/same-insecure.http.html.headers
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin-when-cross-origin/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/same-insecure.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin-when-cross-origin/meta-referrer/same-origin/http-http/module-worker/no-redirect/same-insecure.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html.headers
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin/http-rp/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin/http-rp/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html.headers
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/strict-origin/meta-referrer/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unsafe-url/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unsafe-url/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html.headers
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unsafe-url/http-rp/same-origin/http-http/module-worker/no-redirect/generic.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unsafe-url/http-rp/same-origin/http-http/module-worker/no-redirect/generic.http.html.headers
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unsafe-url/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/generic.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unsafe-url/meta-referrer/same-origin/http-http/module-worker/no-redirect/generic.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unset-referrer-policy/http-rp/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unset-referrer-policy/http-rp/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unset-referrer-policy/meta-referrer/same-origin/http-http/module-worker/keep-origin-redirect/insecure-protocol.http.html
[add] https://crrev.com/01a03aab2d89c93c157c9af52dca7ac20d8ed96b/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/unset-referrer-policy/meta-referrer/same-origin/http-http/module-worker/no-redirect/insecure-protocol.http.html

Comment 21 by bugdroid1@chromium.org, Nov 27

Project Member

Comment 22 by bugdroid1@chromium.org, Dec 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67552628b0942f484ddd8e09a831812396a1019c

commit 67552628b0942f484ddd8e09a831812396a1019c
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Wed Dec 05 00:32:29 2018

Switch top-level module worker fetch to use outsideSettings ResourceFetcher

Before this CL, module loading uses the combination of
- a spec-conformant FetchClientSettingsObject (FCSO) (either
  insideSettings or outsideSettings) that is passed explicitly, and
- a single ResourceFetcher (insideSettings-ish thing) that is
  tied with ExecutionContext,
to implement off-the-main-thread top-level fetch.

However, module loading potentially used another insideSettings FCSO
behind the ResourceFetcher in some cases,
which was not spec conformant in off-the-main-thread fetch.

Also, sharing the single ResourceFetcher makes it harder to
distinguish insideSettings and outsideSettings fetches further.

This CL
- Creates a new outsideSettings ResourceFetcher/FetchContext
  which has the outsideSettings FCSO behind it
  for each invocation of off-the-main-thread top-level module worker
  script fetch in WorkerOrWorkletGlobalScope::FetchModuleScript(), and
- Plumbs ResourceFetcher (and FetchContext/FCSO behind that)
  in core/loader/modulescript instead of directly plumbing FCSO.

After this CL,
- FCSO used in module loading is always the outsideSettings FCSO
  behind the outsideSettings ResourceFetcher.
  In most cases this doesn't affect the behavior though, because
  - insideSettings and outsideSettings are so similar
    that the difference isn't caught by the tests, and
  - Where the difference can be observable,
    the explicitly given outsideSettings FCSO is already used
    (e.g. for SecurityOrigin, referrer and referrer policy).
- We have different ResourceFetcher/FetchContext objects for
  insideSettings and outsideSettings fetches.
  Currently their behaviors are the same (except for FCSO),
  but eventually we can further differentiate
  insideSettings and outsideSettings fetches and thus improve
  the spec conformance, by setting different data/behavior to
  each ResourceFetcher/FetchContext.

Bug: 880027
Change-Id: I740ffe3691c7e5213c610f1ab71bd1fc8fd853f6
Reviewed-on: https://chromium-review.googlesource.com/c/1328164
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613783}
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/loader/link_loader.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/loader/link_loader_test.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.h
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/loader/modulescript/installed_service_worker_module_script_fetcher.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/loader/modulescript/installed_service_worker_module_script_fetcher.h
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/loader/modulescript/module_script_fetcher.h
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/loader/modulescript/module_script_loader.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/loader/modulescript/module_script_loader.h
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.h
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_test.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.h
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.h
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/script/document_modulator_impl.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/script/document_modulator_impl.h
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/script/dynamic_module_resolver.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/script/dynamic_module_resolver_test.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/script/modulator.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/script/modulator.h
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/script/modulator_impl_base.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/script/modulator_impl_base.h
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/script/module_map.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/script/module_map.h
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/script/module_map_test.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/script/script_loader.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/script/script_loader.h
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/script/worker_modulator_impl.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/script/worklet_modulator_impl.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/testing/dummy_modulator.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/testing/dummy_modulator.h
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/workers/worker_thread_test.cc
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/workers/worker_thread_test_helper.h
[modify] https://crrev.com/67552628b0942f484ddd8e09a831812396a1019c/third_party/blink/renderer/core/workers/worklet_module_responses_map_test.cc

Comment 23 by bugdroid1@chromium.org, Dec 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/640e4fb6366560ce116a2d14ba1dfade6a56e7f0

commit 640e4fb6366560ce116a2d14ba1dfade6a56e7f0
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Wed Dec 05 04:38:37 2018

Switch top-level classic worker fetch to use outsideSettings ResourceFetcher

This CL
- Makes ThreadableLoader and WorkerClassicScriptLoader
  accept a ResourceFetcher argument, and
- Creates and passes outsideSettings in
  WorkerGlobalScope::ImportClassicScriptPausable().

This switches FetchClientSettingsObject used for off-the-main-thread
classic worker top-level script fetch, and fixes
virtual/omt-worker-fetch/external/wpt/referrer-policy
test failures.

Bug: 880027, 835717
Change-Id: I68b6c8025c88362b507fcf84e56571d0e7eea409
Reviewed-on: https://chromium-review.googlesource.com/c/1328565
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613867}
[modify] https://crrev.com/640e4fb6366560ce116a2d14ba1dfade6a56e7f0/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc
[modify] https://crrev.com/640e4fb6366560ce116a2d14ba1dfade6a56e7f0/third_party/blink/renderer/core/loader/threadable_loader.cc
[modify] https://crrev.com/640e4fb6366560ce116a2d14ba1dfade6a56e7f0/third_party/blink/renderer/core/loader/threadable_loader.h
[modify] https://crrev.com/640e4fb6366560ce116a2d14ba1dfade6a56e7f0/third_party/blink/renderer/core/workers/dedicated_worker.cc
[modify] https://crrev.com/640e4fb6366560ce116a2d14ba1dfade6a56e7f0/third_party/blink/renderer/core/workers/worker_classic_script_loader.cc
[modify] https://crrev.com/640e4fb6366560ce116a2d14ba1dfade6a56e7f0/third_party/blink/renderer/core/workers/worker_classic_script_loader.h
[modify] https://crrev.com/640e4fb6366560ce116a2d14ba1dfade6a56e7f0/third_party/blink/renderer/core/workers/worker_global_scope.cc
[modify] https://crrev.com/640e4fb6366560ce116a2d14ba1dfade6a56e7f0/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc
[modify] https://crrev.com/640e4fb6366560ce116a2d14ba1dfade6a56e7f0/third_party/blink/web_tests/TestExpectations

Comment 24 by bugdroid1@chromium.org, Dec 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5918e1225fc91bc5c02bb1cfb447dc97578e952

commit f5918e1225fc91bc5c02bb1cfb447dc97578e952
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Wed Dec 05 05:53:08 2018

Move AllowedByNosniff to platform/loader

To cleanup the logic around AllowedByNosniff in
WorkerClassicScriptLoader, [1] will move AllowedByNosniff
option to FetchClientSettingsObject (in platform/loader).
As a preparation, this CL moves
AllowedByNosniff to platform/loader.

This shouldn't change the behavior.

[1] https://chromium-review.googlesource.com/1351929

Bug: 880027
Change-Id: I348d97820cc37b843f3e7b5c5a19bcbc4d01e790
Reviewed-on: https://chromium-review.googlesource.com/c/1351873
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613879}
[modify] https://crrev.com/f5918e1225fc91bc5c02bb1cfb447dc97578e952/third_party/blink/renderer/core/BUILD.gn
[modify] https://crrev.com/f5918e1225fc91bc5c02bb1cfb447dc97578e952/third_party/blink/renderer/core/loader/BUILD.gn
[delete] https://crrev.com/8e4895f5ae969598c11957ccb1a5da289f1acc9d/third_party/blink/renderer/core/loader/allowed_by_nosniff.h
[modify] https://crrev.com/f5918e1225fc91bc5c02bb1cfb447dc97578e952/third_party/blink/renderer/core/loader/base_fetch_context.h
[modify] https://crrev.com/f5918e1225fc91bc5c02bb1cfb447dc97578e952/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/f5918e1225fc91bc5c02bb1cfb447dc97578e952/third_party/blink/renderer/core/workers/worker_classic_script_loader.cc
[modify] https://crrev.com/f5918e1225fc91bc5c02bb1cfb447dc97578e952/third_party/blink/renderer/core/workers/worker_classic_script_loader.h
[modify] https://crrev.com/f5918e1225fc91bc5c02bb1cfb447dc97578e952/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/f5918e1225fc91bc5c02bb1cfb447dc97578e952/third_party/blink/renderer/platform/loader/BUILD.gn
[rename] https://crrev.com/f5918e1225fc91bc5c02bb1cfb447dc97578e952/third_party/blink/renderer/platform/loader/allowed_by_nosniff.cc
[add] https://crrev.com/f5918e1225fc91bc5c02bb1cfb447dc97578e952/third_party/blink/renderer/platform/loader/allowed_by_nosniff.h
[rename] https://crrev.com/f5918e1225fc91bc5c02bb1cfb447dc97578e952/third_party/blink/renderer/platform/loader/allowed_by_nosniff_test.cc
[modify] https://crrev.com/f5918e1225fc91bc5c02bb1cfb447dc97578e952/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/f5918e1225fc91bc5c02bb1cfb447dc97578e952/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/f5918e1225fc91bc5c02bb1cfb447dc97578e952/third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h

Comment 25 by bugdroid1@chromium.org, Dec 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b52031f2bd48cb9aa63d001c080c6040a9609f6b

commit b52031f2bd48cb9aa63d001c080c6040a9609f6b
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Wed Dec 05 06:19:37 2018

Remove ExecutionContext::CreateFetchClientSettingsObjectSnapshot()

Previously, there are two kinds of FetchClientSettingsObject instances
that originate from the same ExecutionContext but are
created via different, duplicated code paths:

[1] FetchClientSettingsObjectImpl and
[2] FetchClientSettingsObjectSnapshot created by
    ExecutionContext::CreateFetchClientSettingsObjectSnapshot().

To simplify the data flow this CL replaces [2] with:

[3] FetchClientSettingsObjectSnapshot created from [1] by
    a newly added FetchClientSettingsObjectSnapshot copy-ish constructor.

After this CL, it is easier to add logic to
FetchClientSettingsObjectImpl methods, as its return values are
propagated to FetchClientSettingsObjectSnapshot, without adding the
same logic to CreateFetchClientSettingsObjectSnapshot().
(For example https://chromium-review.googlesource.com/1351929).

Bug: 880027
Change-Id: I207ef34dd44923bccb0d0813bb71ac72a0b15066
Reviewed-on: https://chromium-review.googlesource.com/c/1352972
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613882}
[modify] https://crrev.com/b52031f2bd48cb9aa63d001c080c6040a9609f6b/third_party/blink/renderer/core/execution_context/execution_context.cc
[modify] https://crrev.com/b52031f2bd48cb9aa63d001c080c6040a9609f6b/third_party/blink/renderer/core/execution_context/execution_context.h
[modify] https://crrev.com/b52031f2bd48cb9aa63d001c080c6040a9609f6b/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc
[modify] https://crrev.com/b52031f2bd48cb9aa63d001c080c6040a9609f6b/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/b52031f2bd48cb9aa63d001c080c6040a9609f6b/third_party/blink/renderer/core/workers/dedicated_worker.cc
[modify] https://crrev.com/b52031f2bd48cb9aa63d001c080c6040a9609f6b/third_party/blink/renderer/core/workers/worklet.cc
[modify] https://crrev.com/b52031f2bd48cb9aa63d001c080c6040a9609f6b/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc
[modify] https://crrev.com/b52031f2bd48cb9aa63d001c080c6040a9609f6b/third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object_snapshot.cc
[modify] https://crrev.com/b52031f2bd48cb9aa63d001c080c6040a9609f6b/third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object_snapshot.h

Comment 26 by hirosh...@chromium.org, Dec 5

Blockedon: 912046

Comment 27 by bugdroid1@chromium.org, Dec 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/748875b36e91d5cd25bd8d653677fb5192203c97

commit 748875b36e91d5cd25bd8d653677fb5192203c97
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Thu Dec 06 05:46:57 2018

Revert unintentional switching to element document in an AllowedByNosniff call

In classic_pending_script.cc, [1] uses
GetElement()->GetDocument().Fetcher()->Context()
which corresponds to the element document, while before [1] it was
GetElement()->GetDocument().ContextDocument()
which corresponds to the context document.

This CL reverts this change and uses the context document, and
adds a regression test derived from a clusterfuzz test case.

[1] https://chromium-review.googlesource.com/1351873

Bug:  912046 , 880027
Change-Id: I92ca9723c3fdd1c5d9c304e4e196aeb77c75ee88
Reviewed-on: https://chromium-review.googlesource.com/c/1364050
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614279}
[modify] https://crrev.com/748875b36e91d5cd25bd8d653677fb5192203c97/third_party/blink/renderer/core/script/classic_pending_script.cc
[add] https://crrev.com/748875b36e91d5cd25bd8d653677fb5192203c97/third_party/blink/web_tests/http/tests/misc/script-moved-to-createDocument-crash.html

Comment 28 by bugdroid1@chromium.org, Dec 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87c80ca3a00312eec1c92b7f5c0344b05ef8ef05

commit 87c80ca3a00312eec1c92b7f5c0344b05ef8ef05
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Thu Dec 06 06:36:49 2018

Make FetchContext::GetSecurityOrigin() non-virtual

This CL introduces FetchContext::fetch_client_settings_object_ and makes
- FetchContext::GetSecurityOrigin()
- FetchContext::GetFetchClientSettingsObject()
non-virtual, to make it clearer that FetchContext's SecurityOrigin
is always the SecurityOrigin of FetchContext's FetchClientSettingsObject.

Bug: 880027
Change-Id: I7ea1cc0edd4d7096b3a0c009c24fcb140d275430
Reviewed-on: https://chromium-review.googlesource.com/c/1352042
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614282}
[modify] https://crrev.com/87c80ca3a00312eec1c92b7f5c0344b05ef8ef05/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/87c80ca3a00312eec1c92b7f5c0344b05ef8ef05/third_party/blink/renderer/core/loader/base_fetch_context_test.cc
[modify] https://crrev.com/87c80ca3a00312eec1c92b7f5c0344b05ef8ef05/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/87c80ca3a00312eec1c92b7f5c0344b05ef8ef05/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/87c80ca3a00312eec1c92b7f5c0344b05ef8ef05/third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
[modify] https://crrev.com/87c80ca3a00312eec1c92b7f5c0344b05ef8ef05/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/87c80ca3a00312eec1c92b7f5c0344b05ef8ef05/third_party/blink/renderer/core/loader/worker_fetch_context.h
[modify] https://crrev.com/87c80ca3a00312eec1c92b7f5c0344b05ef8ef05/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/87c80ca3a00312eec1c92b7f5c0344b05ef8ef05/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/87c80ca3a00312eec1c92b7f5c0344b05ef8ef05/third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h

Comment 29 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7968ab13a3ae57504e720b312d13e8486be671d

commit d7968ab13a3ae57504e720b312d13e8486be671d
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Thu Dec 06 20:03:38 2018

Move AllowedByNosniff::MimeTypeCheck logic to FetchClientSettingsObject

This CL introduces
FetchClientSettingsObject::MimeTypeCheckForClassicWorkerScript()
and moves AllowedByNosniff::MimeTypeCheck logic to it from
WorkerClassicScriptLoader.

This CL removes most of dependencies from
WorkerClassicScriptLoader to ExeuctionContext except for
calling IsWorkerGlobalScope() and plumbing to ThreadableLoader.

This CL shouldn't change the behavior.

Bug: 880027, 794548
Change-Id: I68d31e359899faf4d5461e1be8a46db9f9bc1303
Reviewed-on: https://chromium-review.googlesource.com/c/1351929
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614461}
[modify] https://crrev.com/d7968ab13a3ae57504e720b312d13e8486be671d/third_party/blink/renderer/core/execution_context/execution_context.cc
[modify] https://crrev.com/d7968ab13a3ae57504e720b312d13e8486be671d/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc
[modify] https://crrev.com/d7968ab13a3ae57504e720b312d13e8486be671d/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/d7968ab13a3ae57504e720b312d13e8486be671d/third_party/blink/renderer/core/script/fetch_client_settings_object_impl.cc
[modify] https://crrev.com/d7968ab13a3ae57504e720b312d13e8486be671d/third_party/blink/renderer/core/script/fetch_client_settings_object_impl.h
[modify] https://crrev.com/d7968ab13a3ae57504e720b312d13e8486be671d/third_party/blink/renderer/core/workers/dedicated_worker.cc
[modify] https://crrev.com/d7968ab13a3ae57504e720b312d13e8486be671d/third_party/blink/renderer/core/workers/worker_classic_script_loader.cc
[modify] https://crrev.com/d7968ab13a3ae57504e720b312d13e8486be671d/third_party/blink/renderer/core/workers/worker_classic_script_loader.h
[modify] https://crrev.com/d7968ab13a3ae57504e720b312d13e8486be671d/third_party/blink/renderer/core/workers/worker_global_scope.cc
[modify] https://crrev.com/d7968ab13a3ae57504e720b312d13e8486be671d/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc
[modify] https://crrev.com/d7968ab13a3ae57504e720b312d13e8486be671d/third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object.h
[modify] https://crrev.com/d7968ab13a3ae57504e720b312d13e8486be671d/third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object_snapshot.cc
[modify] https://crrev.com/d7968ab13a3ae57504e720b312d13e8486be671d/third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object_snapshot.h
[modify] https://crrev.com/d7968ab13a3ae57504e720b312d13e8486be671d/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/d7968ab13a3ae57504e720b312d13e8486be671d/third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h

Comment 32 by bugdroid1@chromium.org, Dec 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9447b7af71ee8fe35d090d66e33ff903d1fb00a

commit d9447b7af71ee8fe35d090d66e33ff903d1fb00a
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Tue Dec 18 21:39:09 2018

Always set FetchClientSettingsObject at FrameFetchContext ctor

This CL makes FetchContext's FetchClientSettingsObject always non-null.

Bug: 880027
Change-Id: I44ceb77f98bcbf7ed5f5cd9acf2184f3c2072da0
Reviewed-on: https://chromium-review.googlesource.com/c/1372033
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617635}
[modify] https://crrev.com/d9447b7af71ee8fe35d090d66e33ff903d1fb00a/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/d9447b7af71ee8fe35d090d66e33ff903d1fb00a/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc

Comment 33 by bugdroid1@chromium.org, Dec 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76

commit d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Tue Dec 18 23:14:33 2018

Require FetchClientSettingsObject in FetchContext ctor

This CL clarifies that a FetchClientSettingsObject is given
to FetchContext at construction by
adding FetchClientSettingsObject parameter to the ctor and
removing SetFetchClientSettingsObject() calls unless
necessary for navigation/detached FrameFetchContext.

This CL also removes
- MockFetchContext::Create()
- MockFetchContext::SetSecurityOrigin()
and adjusted how FetchContext is created in unit tests.

Bug: 880027
Change-Id: I27c7e2718a89ec0ef3a936f3fe6984f1cc97b0a7
Reviewed-on: https://chromium-review.googlesource.com/c/1378820
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617665}
[modify] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/third_party/blink/renderer/core/loader/base_fetch_context.cc
[modify] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/third_party/blink/renderer/core/loader/base_fetch_context.h
[modify] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/third_party/blink/renderer/core/loader/base_fetch_context_test.cc
[modify] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/third_party/blink/renderer/core/loader/resource/font_resource_test.cc
[modify] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/third_party/blink/renderer/core/loader/resource/image_resource_test.cc
[modify] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/third_party/blink/renderer/core/workers/worklet_module_responses_map_test.cc
[modify] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/third_party/blink/renderer/platform/loader/allowed_by_nosniff_test.cc
[modify] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/third_party/blink/renderer/platform/loader/fetch/memory_cache_correctness_test.cc
[modify] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/third_party/blink/renderer/platform/loader/fetch/memory_cache_test.cc
[modify] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
[modify] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler_test.cc
[modify] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/third_party/blink/renderer/platform/loader/fetch/resource_loader_defer_loading_test.cc
[modify] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/third_party/blink/renderer/platform/loader/fetch/resource_loader_test.cc
[modify] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/third_party/blink/renderer/platform/loader/subresource_integrity_test.cc
[modify] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/third_party/blink/renderer/platform/loader/testing/fetch_testing_platform_support.cc
[modify] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/third_party/blink/renderer/platform/loader/testing/fetch_testing_platform_support.h
[modify] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h

Comment 35 by bugdroid1@chromium.org, Dec 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7f12622772fb25d4c152af812be7b0a88262386

commit e7f12622772fb25d4c152af812be7b0a88262386
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Thu Dec 20 04:57:44 2018

Use CoreProbeSink instead of ExecutionContext in FetchContext

To prepare for further decoupling outsideSettings WorkerFetchContext,
this CL reduces dependency to ExecutionContext from FetchContext
by switching them to CoreProbeSink.

Bug: 880027
Change-Id: I9cc8739178d04e553f16aa977b3805a13f873c5e
Reviewed-on: https://chromium-review.googlesource.com/c/1193382
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618114}
[modify] https://crrev.com/e7f12622772fb25d4c152af812be7b0a88262386/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/e7f12622772fb25d4c152af812be7b0a88262386/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/e7f12622772fb25d4c152af812be7b0a88262386/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/e7f12622772fb25d4c152af812be7b0a88262386/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/e7f12622772fb25d4c152af812be7b0a88262386/third_party/blink/renderer/core/loader/threadable_loader.cc
[modify] https://crrev.com/e7f12622772fb25d4c152af812be7b0a88262386/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/e7f12622772fb25d4c152af812be7b0a88262386/third_party/blink/renderer/core/loader/worker_fetch_context.h
[modify] https://crrev.com/e7f12622772fb25d4c152af812be7b0a88262386/third_party/blink/renderer/core/probe/core_probes.h
[modify] https://crrev.com/e7f12622772fb25d4c152af812be7b0a88262386/third_party/blink/renderer/core/probe/core_probes.pidl

Comment 36 by bugdroid1@chromium.org, Jan 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3408668fb2bb8bce5bb6b0dc2a00ec09c1e6419

commit c3408668fb2bb8bce5bb6b0dc2a00ec09c1e6419
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Fri Jan 11 02:01:51 2019

Do not call EnsureFetcher() in ThreadableLoader for outsideSettings fetch

Currently, ThreadableLoader always calls EnsureFetcher(),
which is not necessary and
would cause assertion failures when switching the worker's URL
because this creates worker's insideSettings ResourceFetcher
(which depends on ExecutionContext and its URL)
at the start of outsideSettings top-level script fetch.

This CL skips such unnecessary EnsureFetcher() calls and thus
avoids the assertion failures.

Bug: 880027, 835717, 861564
Change-Id: I7768b0274bdc47e856df2a4a529d4b223d978c80
Reviewed-on: https://chromium-review.googlesource.com/c/1394643
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621863}
[modify] https://crrev.com/c3408668fb2bb8bce5bb6b0dc2a00ec09c1e6419/third_party/blink/renderer/core/loader/threadable_loader.cc

Comment 37 by bugdroid, Feb 20 (3 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fee56e9c7b39cf1d48102e2ece517110435ada71

commit fee56e9c7b39cf1d48102e2ece517110435ada71
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Wed Feb 20 22:27:16 2019

Remove ExecutionContext dependency in WillSendRequest() for replay XHR

In off-the-main-thread worker script fetch, worker scripts are
fetched on the worker thread, but WorkerGlobalScope shouldn't be
referenced there as it is not yet fully initialized and
it is not the fetch client's settings object.

To reduce dependency to WorkerGlobalScope=ExecutionContext
during fetch, this CL removes ExecutionContext usage from
InspectorNetworkAgent::WillSendRequestInternal()
and instead supplies ExecutionContext for replayXHR from
WillLoadXHR(), and stores ExecutionContext
in XHRReplayData instead of NetworkResourceData.

The ExecutionContext Member was moved from XHRReplayData
to NetworkResourceData by
https://chromium-review.googlesource.com/c/chromium/src/+/833344/
but after
https://chromium-review.googlesource.com/c/chromium/src/+/950304/
we no longer need ExecutionContext in NetworkResourceData.

This CL also makes the reference to ExecutionContext weak.

This CL also removes unused parameters of WillLoadXHR().

Bug: 880027
Change-Id: I173a8a0e3d66ec26572e2ae738c29d62f8d76d39
Reviewed-on: https://chromium-review.googlesource.com/c/1383908
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633913}
[modify] https://crrev.com/fee56e9c7b39cf1d48102e2ece517110435ada71/third_party/blink/renderer/core/inspector/inspector_network_agent.cc
[modify] https://crrev.com/fee56e9c7b39cf1d48102e2ece517110435ada71/third_party/blink/renderer/core/inspector/inspector_network_agent.h
[modify] https://crrev.com/fee56e9c7b39cf1d48102e2ece517110435ada71/third_party/blink/renderer/core/inspector/network_resources_data.cc
[modify] https://crrev.com/fee56e9c7b39cf1d48102e2ece517110435ada71/third_party/blink/renderer/core/inspector/network_resources_data.h
[modify] https://crrev.com/fee56e9c7b39cf1d48102e2ece517110435ada71/third_party/blink/renderer/core/probe/core_probes.pidl
[modify] https://crrev.com/fee56e9c7b39cf1d48102e2ece517110435ada71/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc

Comment 38 by bugdroid, Feb 21 (3 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78058863524db0c3a2d7f014730b3ccb2c3832f4

commit 78058863524db0c3a2d7f014730b3ccb2c3832f4
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Thu Feb 21 00:02:57 2019

Remove ExecutionContext dependency from willSendRequest() etc. probes

This CL removes ExecutionContext from the following probe methods,
and instead passes CoreProbeSink:
- prepareRequest()
- didBlockRequest()
- willSendRequest()
- willSendNavigationRequest()

The ExecutionContext was simply not used, except for
ExecutionContext::Url() inside willSendRequest().
This CL calls FetchContext::Url() at the caller and
pass the URL instead of the whole ExecutionContext.

After this CL, all probe calls from WorkerFetchContext
no longer take WorkerGlobalScope as their argument,
which is good for separating WorkerFetchContext from
WorkerGlobalScope for off-the-main-thread fetch.

Bug: 880027
Change-Id: Idb648c9d809ca6fd95de090fa3b7249b7bb71b9e
Reviewed-on: https://chromium-review.googlesource.com/c/1383911
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633959}
[modify] https://crrev.com/78058863524db0c3a2d7f014730b3ccb2c3832f4/third_party/blink/renderer/core/inspector/inspector_emulation_agent.cc
[modify] https://crrev.com/78058863524db0c3a2d7f014730b3ccb2c3832f4/third_party/blink/renderer/core/inspector/inspector_emulation_agent.h
[modify] https://crrev.com/78058863524db0c3a2d7f014730b3ccb2c3832f4/third_party/blink/renderer/core/inspector/inspector_network_agent.cc
[modify] https://crrev.com/78058863524db0c3a2d7f014730b3ccb2c3832f4/third_party/blink/renderer/core/inspector/inspector_network_agent.h
[modify] https://crrev.com/78058863524db0c3a2d7f014730b3ccb2c3832f4/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/78058863524db0c3a2d7f014730b3ccb2c3832f4/third_party/blink/renderer/core/inspector/inspector_trace_events.h
[modify] https://crrev.com/78058863524db0c3a2d7f014730b3ccb2c3832f4/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/78058863524db0c3a2d7f014730b3ccb2c3832f4/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/78058863524db0c3a2d7f014730b3ccb2c3832f4/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/78058863524db0c3a2d7f014730b3ccb2c3832f4/third_party/blink/renderer/core/probe/core_probes.pidl

Comment 40 by bugdroid, Feb 21 (2 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bd0474d91e0b337e23a13c53a6a0b98eb7c91d7

commit 5bd0474d91e0b337e23a13c53a6a0b98eb7c91d7
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Thu Feb 21 07:37:37 2019

Remove InspectorNetworkAgent::replay_xhrs_to_be_deleted_

As XMLHttpRequest is now GarbageCollected, async destruction is
no longer needed.

Bug: 880027
Change-Id: Ieee63d77af98c4b053b567d477b5397b628448a2
Reviewed-on: https://chromium-review.googlesource.com/c/1383915
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634110}
[modify] https://crrev.com/5bd0474d91e0b337e23a13c53a6a0b98eb7c91d7/third_party/blink/renderer/core/inspector/inspector_network_agent.cc
[modify] https://crrev.com/5bd0474d91e0b337e23a13c53a6a0b98eb7c91d7/third_party/blink/renderer/core/inspector/inspector_network_agent.h

Sign in to add a comment