Chrome does not listen to "colored title bar" setting changes and repaint
Reported by
dchau...@etouch.net,
Sep 3
|
||||||
Issue descriptionChrome Version: 71.0.3541.0 (Official Build) Revision 5b7432c268333c962bdf8bc3280f2d33baf00932-refs/branch-heads/3541@{#1} 32/64-bit OS: Windows-10 Precondition: 1. Enable "windows10-custom-titlebar" in chrome://flags 2. Setup: A. Open Windows machine settings > Personalization > Colors B. 'Enable (On) 'Show Color on Title bar C. Select any required color from 'Accent colors'. What steps will reproduce the problem? 1. Launch Chrome and go to NTP (Selected color on Chrome title-bars will appear). 2. Navigate to Windows machine settings > Personalization > Colors > disable 'Title bars' checkbox and close the Window. 2. Now hover the mouse pointer on Chrome title-bar and observe. Actual: Chrome title-bar color disappears on hovering the mouse pointer on tab-strip. Expected: Chrome title-bar color should disappear when we disable the 'Title bars' checkbox. This is a Windows-10 specific non-regression issue, seen from M-60 series. NOTE: 1. This issue is not reproducible on Windows(7,8,8.1), Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04) OS. 2. This issue is also reproducible on Stable #68.0.3440.106, Beta #69.0.3497.72 and Dev #70.0.3534.4 3. This issue is not observed on Mozilla Firefox browser. Kindly review the attached screen-cast for reference. Thank you.
,
Sep 3
Hey Iām sorry!!!Have. Blessed day!š So you fixed it on your end?If So Thanks
,
Sep 3
I wonder if we get WM_THEMECHANGED or something for this.
,
Nov 14
***Mass UI Triage*** Hi, Just to update: Issue is still reproducible on Windows 10(Touch Device) using Latest canary #72.0.3609.3 Please find the screen shot for reference. Thank You!
,
Nov 14
That's odd, I can't reproduce this exactly as described. I do see a similar problem where the titlebar doesn't repaint if the browser isn't activated (e.g. it's behind a third window when Settings is closed). I imagine fixing that will fix this too.
,
Jan 11
,
Jan 15
,
Jan 19
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa22e21ff92e227e2ed1dd3e619bb87162c40dcf commit fa22e21ff92e227e2ed1dd3e619bb87162c40dcf Author: Dana Fried <dfried@chromium.org> Date: Sat Jan 19 02:17:13 2019 Windows titlebar color change now correctly propagates to browser. We're using the existing ThemeChanged() pathway, which does a little extra work (because it's designed to handle Aero <-> Classic transitions) so there may be a touch of flicker, but it fixes the nasty visual artifacts we were seeing before. Bug: 880020 Change-Id: I56945acb9f53b9abe7bd742a9b57fc08899a2c44 Reviewed-on: https://chromium-review.googlesource.com/c/1410505 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#624421} [modify] https://crrev.com/fa22e21ff92e227e2ed1dd3e619bb87162c40dcf/chrome/browser/themes/theme_service_win.cc [modify] https://crrev.com/fa22e21ff92e227e2ed1dd3e619bb87162c40dcf/ui/views/win/hwnd_message_handler.cc [modify] https://crrev.com/fa22e21ff92e227e2ed1dd3e619bb87162c40dcf/ui/views/window/non_client_view.cc [modify] https://crrev.com/fa22e21ff92e227e2ed1dd3e619bb87162c40dcf/ui/views/window/non_client_view.h
,
Jan 21
(2 days ago)
Update: Rechecked this issue on Windows-10 machine using latest Canary build #73.0.3679.0 and issue is fixed. Hence adding TE-Verified labels. Kindly refer the attached screen-cast for the same. Thank you..! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by rbasuvula@chromium.org
, Sep 3