New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 880001 link

Starred by 2 users
Status: Assigned
Owner:
se...@chromium.org
Cc:
ftirelo@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
█ durgapandey@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:[Settings]Add button is enabled even when 'Save and fill payment methods' options is off

Reported by vineetha...@etouch.net, Sep 3 
Chrome Version : 71.0.3541.0 (Official Build) Revision 5b7432c268333c962bdf8bc3280f2d33baf00932-refs/branch-heads/3541@{#1}(32/64 bit)
OS : Windows (7, 8, 8.1, 10), Linux(14.04 LTS), Mac(10.12.6, 10.13.1, 10.13.6, 10.14)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://settings/payments.
2. Now disable the toggle button for 'Save and fill payment methods' and observe the 'Add' button for Payment methods.

Actual Result   : Add button is seen enabled even when 'Save and fill payment methods' options is off. 
Expected Result : Add button should be disabled when 'Save and fill payment methods' options is off.

This is a regression issue broken in ‘M-71’ and will soon provide the bisect info:
Good Build : 70.0.3538.0 (Revision : 587812)
Bad Build  : 71.0.3539.0 (Revision : 588235)

Note: Same issue is reproducible for 'Add' button for addresses under chrome://settings/autofill

Thank You
ActualVideo.mp4
386 KB View Download
ExpectedVideo.mp4
305 KB View Download

Comment 1 by vineetha...@etouch.net, Sep 3

Labels: hasbisect
Owner: se...@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow bisect info:

https://chromium.googlesource.com/chromium/src/+log/5ff407e19569ad407ad37bddce803759be206e69..61aa180e3283f3f7e495f068b9a34dd3981232d6?pretty=fuller&n=50

Suspecting: https://chromium.googlesource.com/chromium/src/+/2e8a67679cecb521eee5e76d59d43f8792d08897

@sebsg: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note:
1)Provided suspect through 'Narrow bisect' script because unable to perform bisect using 'per-revision' bisect script.
2)Tried performing 'per revision' bisect on Windows ,Mac and Linux OS but unable to perform the same since getting following errors,
 (a)Error message on Mac OS:[Errno 2] No such file or directory error message
 (b)Error message on Windows and Linux OS :Unable to find local data files

Thank You!

Comment 2 by se...@chromium.org, Sep 4

Cc: durgapandey@chromium.org ftirelo@chromium.org
I think this is WAI, the user should still be able to modify or add addresses and cards when they have the toggle set to off.

+Durga to confirm
►

Sign in to add a comment