Issue 879988 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	----
Closed:	Sep 13
Cc:	█ sattlerf@google.com jdoerrie@chromium.org verwa...@chromium.org
Components:	Blink>JavaScript
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	1
Type:	----
Stability Filed-Via-SoM

webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty MSAN

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Sep 3

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of jdoerrie@chromium.org

webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty MSAN

Builders failed on: 
- WebKit Linux Trusty MSAN: 
  https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN

Suspecting r588301, will revert.

Comment 1 by jdoerrie@chromium.org, Sep 3

Example Stack Trace:

20:37:09.284 3308 worker/0 http/tests/devtools/sources/debugger/script-collected.js crashed, (stderr lines):
20:37:09.284 3308   
20:37:09.284 3308   DevTools listening on ws://127.0.0.1:44656/devtools/browser/dd717eb9-2199-4311-a90e-4d908508bf9c
20:37:09.284 3308   ==1==WARNING: MemorySanitizer: use-of-uninitialized-value
20:37:09.284 3308       #0 0x6911f46 in v8::internal::Scanner::ScanPrivateName() ./../../v8/src/parsing/scanner.cc:568:7
20:37:09.284 3308       #1 0x68d6aa5 in ScanSingleToken ./../../v8/src/parsing/scanner-inl.h:515:16
20:37:09.284 3308       #2 0x68d6aa5 in Scan ./../../v8/src/parsing/scanner-inl.h:544:0
20:37:09.284 3308       #3 0x68d6aa5 in v8::internal::Scanner::Initialize() ./../../v8/src/parsing/scanner.cc:190:0
20:37:09.284 3308       #4 0x5af7946 in EnsureMagicComments ./../../v8/src/debug/debug.cc:1872:11
20:37:09.284 3308       #5 0x5af7946 in v8::internal::Debug::ProcessCompileEvent(v8::internal::Debug::CompileStatus, v8::internal::Handle<v8::internal::Script>) ./../../v8/src/debug/debug.cc:1917:0
20:37:09.284 3308       #6 0x6931880 in v8::internal::PendingCompilationErrorHandler::ThrowPendingError(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Script>) ./../../v8/src/pending-compilation-error-handler.cc:96:21
20:37:09.284 3308       #7 0x67edf91 in v8::internal::parsing::ParseProgram(v8::internal::ParseInfo*, v8::internal::Isolate*) ./../../v8/src/parsing/parsing.cc:42:36
20:37:09.284 3308       #8 0x4fcc1d0 in v8::internal::(anonymous namespace)::CompileToplevel(v8::internal::ParseInfo*, v8::internal::Isolate*) ./../../v8/src/compiler.cc:884:8
20:37:09.284 3308       #9 0x4fcfa38 in v8::internal::Compiler::GetFunctionFromEval(v8::internal::Handle<v8::internal::String>, v8::internal::Handle<v8::internal::SharedFunctionInfo>, v8::internal::Handle<v8::internal::Context>, v8::internal::LanguageMode, v8::internal::ParseRestriction, int, int, int, int, int, v8::internal::Handle<v8::internal::Object>, v8::ScriptOriginOptions) ./../../v8/src/compiler.cc:1275:10
20:37:09.284 3308       #10 0x6b94f7c in CompileGlobalEval ./../../v8/src/runtime/runtime-compiler.cc:320:3
20:37:09.284 3308       #11 0x6b94f7c in __RT_impl_Runtime_ResolvePossiblyDirectEval ./../../v8/src/runtime/runtime-compiler.cc:352:0
20:37:09.284 3308       #12 0x6b94f7c in v8::internal::Runtime_ResolvePossiblyDirectEval(int, v8::internal::Object**, v8::internal::Isolate*) ./../../v8/src/runtime/runtime-compiler.cc:330:0
20:37:09.284 3308       #13 0x7377287 in v8::internal::Simulator::DoRuntimeCall(v8::internal::Instruction*) ./../../v8/src/arm64/simulator-arm64.cc:490:11
20:37:09.284 3308       #14 0x737698b in v8::internal::Simulator::ExecuteInstruction() ./../../v8/src/arm64/simulator-arm64.h:779:5
20:37:09.284 3308       #15 0x737675e in v8::internal::Simulator::Run() ./../../v8/src/arm64/simulator-arm64.cc:390:5
20:37:09.284 3308       #16 0x7373bd8 in CheckPCSComplianceAndRun ./../../v8/src/arm64/simulator-arm64.cc:188:3
20:37:09.284 3308       #17 0x7373bd8 in v8::internal::Simulator::CallImpl(unsigned long, v8::internal::Simulator::CallArgument*) ./../../v8/src/arm64/simulator-arm64.cc:157:0
20:37:09.284 3308       #18 0x5d36030 in Call<v8::internal::Object *, v8::internal::Object *, v8::internal::Object *, v8::internal::Object *, int, v8::internal::Object ***> ./../../v8/src/arm64/simulator-arm64.h:725:5
20:37:09.284 3308       #19 0x5d36030 in Call ./../../v8/src/simulator.h:107:0
20:37:09.284 3308       #20 0x5d36030 in v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, bool, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*, v8::internal::Handle<v8::internal::Object>, v8::internal::Execution::MessageHandling, v8::internal::Execution::Target) ./../../v8/src/execution.cc:155:0
20:37:09.285 3308       #21 0x5d34bc3 in CallInternal ./../../v8/src/execution.cc:191:10
20:37:09.285 3308       #22 0x5d34bc3 in v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*) ./../../v8/src/execution.cc:202:0
20:37:09.285 3308       #23 0x5aa0780 in v8::internal::DebugEvaluate::Global(v8::internal::Isolate*, v8::internal::Handle<v8::internal::String>, bool) ./../../v8/src/debug/debug-evaluate.cc:47:32
20:37:09.285 3308       #24 0x4c12a2e in v8::debug::EvaluateGlobal(v8::Isolate*, v8::Local<v8::String>, bool) ./../../v8/src/api.cc:9622:7
20:37:09.285 3308       #25 0x787fe18 in v8_inspector::V8RuntimeAgentImpl::evaluate(v8_inspector::String16 const&, v8_inspector::protocol::Maybe<v8_inspector::String16>, v8_inspector::protocol::Maybe<bool>, v8_inspector::protocol::Maybe<bool>, v8_inspector::protocol::Maybe<int>, v8_inspector::protocol::Maybe<bool>, v8_inspector::protocol::Maybe<bool>, v8_inspector::protocol::Maybe<bool>, v8_inspector::protocol::Maybe<bool>, v8_inspector::protocol::Maybe<bool>, v8_inspector::protocol::Maybe<double>, std::__1::unique_ptr<v8_inspector::protocol::Runtime::Backend::EvaluateCallback, std::__1::default_delete<v8_inspector::protocol::Runtime::Backend::EvaluateCallback> >) ./../../v8/src/inspector/v8-runtime-agent-impl.cc:274:24
20:37:09.285 3308       #26 0x76b8b7a in v8_inspector::protocol::Runtime::DispatcherImpl::evaluate(int, v8_inspector::String16 const&, v8_inspector::String16 const&, std::__1::unique_ptr<v8_inspector::protocol::DictionaryValue, std::__1::default_delete<v8_inspector::protocol::DictionaryValue> >, v8_inspector::protocol::ErrorSupport*) ./gen/v8/src/inspector/protocol/Runtime.cpp:1722:16
20:37:09.285 3308       #27 0x76acd45 in v8_inspector::protocol::Runtime::DispatcherImpl::dispatch(int, v8_inspector::String16 const&, v8_inspector::String16 const&, std::__1::unique_ptr<v8_inspector::protocol::DictionaryValue, std::__1::default_delete<v8_inspector::protocol::DictionaryValue> >) ./gen/v8/src/inspector/protocol/Runtime.cpp:1369:5
20:37:09.285 3308       #28 0x75d4157 in v8_inspector::protocol::UberDispatcher::dispatch(int, v8_inspector::String16 const&, std::__1::unique_ptr<v8_inspector::protocol::Value, std::__1::default_delete<v8_inspector::protocol::Value> >, v8_inspector::String16 const&) ./gen/v8/src/inspector/protocol/Protocol.cpp:815:17
20:37:09.285 3308       #29 0x7852b7b in v8_inspector::V8InspectorSessionImpl::dispatchProtocolMessage(v8_inspector::StringView const&) ./../../v8/src/inspector/v8-inspector-session-impl.cc:329:18
20:37:09.285 3308       #30 0x16124098 in blink::InspectorSession::DispatchProtocolMessage(int, WTF::String const&, WTF::String const&) ./../../third_party/blink/renderer/core/inspector/inspector_session.cc:76:18
20:37:09.285 3308       #31 0x49f1876 in blink::mojom::blink::DevToolsSessionStubDispatch::Accept(blink::mojom::blink::DevToolsSession*, mojo::Message*) ./gen/third_party/blink/public/web/devtools_agent.mojom-blink.cc:423:13
20:37:09.285 3308       #32 0x14d70b26 in blink::mojom::blink::DevToolsSessionStub<mojo::RawPtrImplRefTraits<blink::mojom::blink::DevToolsSession> >::Accept(mojo::Message*) ./gen/third_party/blink/public/web/devtools_agent.mojom-blink.h:346:12
20:37:09.285 3308       #33 0xb48ca69 in mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:423:32
20:37:09.285 3308       #34 0xb48a81a in mojo::FilterChain::Accept(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/filter_chain.cc:40:17
20:37:09.285 3308       #35 0xb04478d in IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnProxyThread(mojo::Message) ./../../ipc/ipc_mojo_bootstrap.cc:864:24
20:37:09.285 3308       #36 0xb03a707 in Invoke<void (IPC::(anonymous namespace)::ChannelAssociatedGroupController::*)(mojo::Message), const scoped_refptr<IPC::(anonymous namespace)::ChannelAssociatedGroupController> &, mojo::Message> ./../../base/bind_internal.h:516:12
20:37:09.285 3308       #37 0xb03a707 in MakeItSo<void (IPC::(anonymous namespace)::ChannelAssociatedGroupController::*const &)(mojo::Message), const scoped_refptr<IPC::(anonymous namespace)::ChannelAssociatedGroupController> &, mojo::Message> ./../../base/bind_internal.h:616:0
20:37:09.285 3308       #38 0xb03a707 in RunImpl<void (IPC::(anonymous namespace)::ChannelAssociatedGroupController::*const &)(mojo::Message), const std::__1::tuple<scoped_refptr<IPC::(anonymous namespace)::ChannelAssociatedGroupController>, base::internal::PassedWrapper<mojo::Message> > &, 0, 1> ./../../base/bind_internal.h:689:0
20:37:09.285 3308       #39 0xb03a707 in base::internal::Invoker<base::internal::BindState<void (IPC::(anonymous namespace)::ChannelAssociatedGroupController::*)(mojo::Message), scoped_refptr<IPC::(anonymous namespace)::ChannelAssociatedGroupController>, base::internal::PassedWrapper<mojo::Message> >, void ()>::Run(base::internal::BindStateBase*) ./../../base/bind_internal.h:671:0
20:37:09.285 3308       #40 0xb109f9f in Run ./../../base/callback.h:99:12
20:37:09.285 3308       #41 0xb109f9f in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/debug/task_annotator.cc:101:0
20:37:09.285 3308       #42 0xb264b7f in base::sequence_manager::internal::ThreadControllerImpl::DoWork(base::sequence_manager::internal::ThreadControllerImpl::WorkType) ./../../base/task/sequence_manager/thread_controller_impl.cc:178:23
20:37:09.285 3308       #43 0xb109f9f in Run ./../../base/callback.h:99:12
20:37:09.285 3308       #44 0xb109f9f in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/debug/task_annotator.cc:101:0
20:37:09.285 3308       #45 0xb104442 in base::MessageLoop::RunTask(base::PendingTask*) ./../../base/message_loop/message_loop.cc:434:46
20:37:09.285 3308       #46 0xb10576b in DeferOrRunPendingTask ./../../base/message_loop/message_loop.cc:445:5
20:37:09.285 3308       #47 0xb10576b in base::MessageLoop::DoWork() ./../../base/message_loop/message_loop.cc:517:0
20:37:09.285 3308       #48 0xb1142f3 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_default.cc:37:31
20:37:09.285 3308       #49 0xb1afb3f in base::RunLoop::Run() ./../../base/run_loop.cc:102:14
20:37:09.285 3308       #50 0x1c74baf9 in content::RendererMain(content::MainFunctionParams const&) ./../../content/renderer/renderer_main.cc:200:23
20:37:09.285 3308       #51 0x8145cc0 in content::RunZygote(content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:496:14
20:37:09.285 3308       #52 0x8148185 in content::RunOtherNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:573:12
20:37:09.286 3308       #53 0x814b739 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:907:10
20:37:09.286 3308       #54 0x11eab420 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:472:29
20:37:09.286 3308       #55 0x48ae201 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10
20:37:09.286 3308       #56 0x1aac865 in main ./../../content/shell/app/shell_main.cc:39:10
20:37:09.286 3308       #57 0x7f0bf7a68f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0
20:37:09.286 3308       #58 0x1a38029 in _start ??:0:0
20:37:09.286 3308   
20:37:09.286 3308     Uninitialized value was created by an allocation of 'scanner.i' in the stack frame of function '_ZN2v88internal5Debug19ProcessCompileEventENS1_13CompileStatusENS0_6HandleINS0_6ScriptEEE'
20:37:09.286 3308       #0 0x5af6d20 in v8::internal::Debug::ProcessCompileEvent(v8::internal::Debug::CompileStatus, v8::internal::Handle<v8::internal::Script>) ./../../v8/src/debug/debug.cc:1903:0
20:37:09.286 3308   
20:37:09.286 3308   SUMMARY: MemorySanitizer: use-of-uninitialized-value (/b/s/w/ir/out/Release/content_shell+0x6911f46)
20:37:09.286 3308   Exiting
20:37:09.292 11970 [1/9] http/tests/devtools/sources/debugger/script-collected.js failed unexpectedly (renderer crashed)

Comment 2 by jdoerrie@chromium.org, Sep 3

Components: Blink>JavaScript
Labels: Stability
Status: Untriaged (was: Available)

Comment 3 by jdoerrie@chromium.org, Sep 3

Cc: sattlerf@google.com verwa...@chromium.org

Explicitly adding sattlerf@ and verwaest@ who have worked on v8/src/parsing recently. Please take a look.

Comment 4 by jdoerrie@chromium.org, Sep 3

Labels: -Sheriff-Chromium

Comment 5 by yangguo@chromium.org, Sep 3

Labels: -Pri-2 Pri-1

Can we pinpoint the culprit and revert it, so that we can re-open roll?

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/29e1d39966c7f9d7ca450519fa3224d7ceb1605e

commit 29e1d39966c7f9d7ca450519fa3224d7ceb1605e
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 14:30:55 2018

Revert "[scanner] Inlining ScanIdentifier and Token check"

This reverts commit 5bbd19219a57574d0ccfcc935605764382b032cb.

Reason for revert: Tentative revert for crbug.com/879988

TBR=sattlerf@chromium.org,verwaest@chromium.org

Original change's description:
> [scanner] Inlining ScanIdentifier and Token check
>
> This improves parse time for code-load and other benchmarks.
>
> Bug: v8:7926
> Change-Id: I9c8017f2e7f73dd952c025db5abe8e4062e6ef9b
> Reviewed-on: https://chromium-review.googlesource.com/1196506
> Commit-Queue: Florian Sattler <sattlerf@google.com>
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55521}

TBR=marja@chromium.org,verwaest@chromium.org,sattlerf@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: v8:7926, chromium:879988
Change-Id: Ic71d9cf63b69c0f9560851259f434b02cc082417
Reviewed-on: https://chromium-review.googlesource.com/1202086
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55592}
[modify] https://crrev.com/29e1d39966c7f9d7ca450519fa3224d7ceb1605e/src/parsing/scanner-inl.h
[modify] https://crrev.com/29e1d39966c7f9d7ca450519fa3224d7ceb1605e/src/parsing/scanner.cc
[modify] https://crrev.com/29e1d39966c7f9d7ca450519fa3224d7ceb1605e/src/parsing/scanner.h

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 15 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 16 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 17 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 18 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 19 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 20 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 21 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 22 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 23 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 24 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 25 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 26 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 27 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 28 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 29 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 30 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 31 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 32 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 33 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 34 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 35 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 36 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 37 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 38 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 39 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 40 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 41 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 42 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 43 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 44 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 45 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 46 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 47 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 48 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 49 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 50 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 51 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 52 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 53 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 54 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 55 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 56 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 57 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 58 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 59 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 60 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 61 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 62 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 63 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 64 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 65 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 66 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 67 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 68 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Comment 69 by cbruni@chromium.org, Sep 4

I'm trying to reland https://crrev.com/c/1203731.
It moved code from a .cc file to a header so it can be inlined, could still be that this accidentally broke something.

Comment 70 by sattlerf@google.com, Sep 4

I talked to yang in the morning, does not look like that this patch caused
the problem.

Project Member

Comment 71 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 72 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 73 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74

commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Sep 03 18:42:28 2018

Revert "inspector: find magic comment using V8 scanner"

This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98.

Reason for revert: crbug/879988

TBR=kozy@chromium.org

Original change's description:
> inspector: find magic comment using V8 scanner
>
> Inspector tries to provide sourceURL and sourceMappingURL for scripts
> with parser errors. Without this CL we convert source of each script
> to inspector string and search for magic comment there. Some web sites
> use pattern when they get some data from network and constantly try to
> parse this data as JSON, in this case we do a lot of useless work.
>
> So we can parse magic comments on V8 side only for compilation errors
> (excluding parse JSON errors), to do it we can reuse scanner by running
> it on each potential comment.
>
> R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
>
> Bug: chromium:873865,v8:7731
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
> Reviewed-on: https://chromium-review.googlesource.com/1182446
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55280}

TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:873865, v8:7731, chromium:879988
Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1202583
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55594}
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt
[modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js

Comment 74 by hablich@chromium.org, Sep 13

Status: Fixed (was: Untriaged)

I guess this one is fixed?

►

Issue 879988 link

Issue metadata

webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty MSAN

Issue description

Comment 1 by jdoerrie@chromium.org, Sep 3

Comment 1 Deleted

Comment 2 by jdoerrie@chromium.org, Sep 3

Comment 2 Deleted

Comment 3 by jdoerrie@chromium.org, Sep 3

Comment 3 Deleted

Comment 4 by jdoerrie@chromium.org, Sep 3

Comment 4 Deleted

Comment 5 by yangguo@chromium.org, Sep 3

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Sep 3

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Sep 3

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Sep 3

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Sep 3

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Sep 3

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Sep 3

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Sep 3

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Sep 3

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Sep 3

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Sep 3

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Sep 3

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Sep 3

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, Sep 3

Comment 18 Deleted

Comment 19 by bugdroid1@chromium.org, Sep 3

Comment 19 Deleted

Comment 20 by bugdroid1@chromium.org, Sep 3

Comment 20 Deleted

Comment 21 by bugdroid1@chromium.org, Sep 3

Comment 21 Deleted

Comment 22 by bugdroid1@chromium.org, Sep 3

Comment 22 Deleted

Comment 23 by bugdroid1@chromium.org, Sep 3

Comment 23 Deleted

Comment 24 by bugdroid1@chromium.org, Sep 3

Comment 24 Deleted

Comment 25 by bugdroid1@chromium.org, Sep 3

Comment 25 Deleted

Comment 26 by bugdroid1@chromium.org, Sep 3

Comment 26 Deleted

Comment 27 by bugdroid1@chromium.org, Sep 3

Comment 27 Deleted

Comment 28 by bugdroid1@chromium.org, Sep 3

Comment 28 Deleted

Comment 29 by bugdroid1@chromium.org, Sep 3

Comment 29 Deleted

Comment 30 by bugdroid1@chromium.org, Sep 3

Comment 30 Deleted

Comment 31 by bugdroid1@chromium.org, Sep 3

Comment 31 Deleted

Comment 32 by bugdroid1@chromium.org, Sep 3

Comment 32 Deleted

Comment 33 by bugdroid1@chromium.org, Sep 3

Comment 33 Deleted

Comment 34 by bugdroid1@chromium.org, Sep 3

Comment 34 Deleted

Comment 35 by bugdroid1@chromium.org, Sep 3

Comment 35 Deleted

Comment 36 by bugdroid1@chromium.org, Sep 3

Comment 36 Deleted

Comment 37 by bugdroid1@chromium.org, Sep 3

Comment 37 Deleted

Comment 38 by bugdroid1@chromium.org, Sep 3

Comment 38 Deleted