Findit has detected flake occurrences for the test PostTaskTestWithExecutor.RegisterExecutorTwice Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/Id8b7bc2e374917ceb421c7f6139790e6f1457511 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVysQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ7Y2hyb21pdW0uY2hyb21pdW1vcy9saW51eC1jaHJvbWVvcy1kYmcvNzYxOC9iYXNlX3VuaXR0ZXN0cy9VRzl6ZEZSaGMydFVaWE4wVjJsMGFFVjRaV04xZEc5eUxsSmxaMmx6ZEdWeVJYaGxZM1YwYjNKVWQybGpaUT09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link and hit submit: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20PostTaskTestWithExecutor.RegisterExecutorTwice&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVysQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ7Y2hyb21pdW0uY2hyb21pdW1vcy9saW51eC1jaHJvbWVvcy1kYmcvNzYxOC9iYXNlX3VuaXR0ZXN0cy9VRzl6ZEZSaGMydFVaWE4wVjJsMGFFVjRaV04xZEc5eUxsSmxaMmx6ZEdWeVJYaGxZM1YwYjNKVWQybGpaUT09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw
Test times out with the following message [1]: [ RUN ] PostTaskTestWithExecutor.RegisterExecutorTwice [WARNING] ../../third_party/googletest/src/googletest/src/gtest-death-test.cc:1050:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 4 threads. See https://github.com/google/googletest/blob/master/googletest/docs/advanced.md#death-tests-and-threads for more explanation and suggested solutions, especially if this is the last message you see before your test times out. [1] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8936438060631285872/+/steps/base_unittests/0/logs/PostTaskTestWithExecutor.RegisterExecutorTwice/0
Disabling test on CrOS in https://crrev.com/c/1201849 and adding original CL author. eseckler@, please take a look.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ce2d21f6b923c7b53b4912e4c5f2788d62c88a3 commit 7ce2d21f6b923c7b53b4912e4c5f2788d62c88a3 Author: jdoerrie <jdoerrie@chromium.org> Date: Mon Sep 03 09:02:54 2018 [Sheriffing] Disable PostTaskTestWithExecutor.RegisterExecutorTwice on CrOS TBR=gab@chromium.org Bug: 879984 Change-Id: I994de9e8f5f9ac51fde51e7376b399d271f53181 Reviewed-on: https://chromium-review.googlesource.com/1201849 Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#588355} [modify] https://crrev.com/7ce2d21f6b923c7b53b4912e4c5f2788d62c88a3/base/task/post_task_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/461cbc77709a44135a9c9fce4ac2e4d81a7cb1cb commit 461cbc77709a44135a9c9fce4ac2e4d81a7cb1cb Author: Eric Seckler <eseckler@chromium.org> Date: Thu Sep 06 15:16:41 2018 base: Make PostTaskTestWithExecutor.RegisterExecutorTwice threadsafe. Also reenables the test on Chrome OS, where it was previously flaking. Bug: 879984 Change-Id: Ida0391c7114afd77b7cb9ec8c2f9b00d8cc275b5 Reviewed-on: https://chromium-review.googlesource.com/1204330 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#589172} [modify] https://crrev.com/461cbc77709a44135a9c9fce4ac2e4d81a7cb1cb/base/task/post_task_unittest.cc
Comment 1 by jdoerrie@chromium.org
, Sep 3