New issue
Advanced search Search tips

Issue 879961 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 21
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-09-24
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

After completing a recaptcha browser can no longer use this page and it hangs on that tab with no touch input.

Reported by rvc...@gmail.com, Sep 3

Issue description

Example URL:
https://patrickhlauke.github.io/recaptcha/

Steps to reproduce the problem:
1.open https://patrickhlauke.github.io/recaptcha/
2. Can zoom in ect.,complete recaptcha. 
3. Can no longer interact with page. 

What is the expected behavior?
Complete recaptcha and continue to use the page and submit. 

What went wrong?
After completion of recaptcha page hangs and will not respond to touch. 

Does it occur on multiple sites: Yes

Is it a problem with a plugin? N/A 

Did this work before? Yes Not sure as I got a new phone (note 9) and noticed it after one update to canary. 

Does this work in other browsers? Yes

Chrome version: 70.0.3538.2  Channel: canary
OS Version: 8.1.0
Flash Version: 

Works in chrome for android version 66.0. 3359.126
 
Components: -Blink Blink>Input
Labels: -Type-Bug Needs-Bisect Type-Bug-Regression
Labels: Needs-triage-Mobile
Cc: chelamcherla@chromium.org
Labels: Triaged-Mobile Needs-Feedback
This issue looks similar to issue 879937.

@ rvcjew: Please provide screenshot/screencast of the issue. This would help in better triaging.

Thanks!
Here is the screen cast with touch data. I could not search for that issue number it told me I did not have rights. https://youtu.be/yO8tusxhLNM
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 5

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-2 -Needs-Bisect hasbisect-per-revision ReleaseBlock-Stable RegressedIn-70 Target-70 M-70 FoundIn-70 Pri-1
Owner: wjmaclean@chromium.org
Status: Assigned (was: Unconfirmed)
Tested the issue in Android and able to reproduce the issue. 

Steps Followed:
1. Navigated to  https://patrickhlauke.github.io/recaptcha/
2. Completed captcha , touch action on page becomes very

Chrome versions tested:
70.0.3538.2

OS:
Android 8.0.0

Android Devices:
Pixel 2

Good Build: 70.0.3521.0
Bad Build: 70.0.3522.0

CL: https://chromium.googlesource.com/chromium/src/+/861a8b2697787f4ace52605e053d0388c57b68f7

@ wjmaclean: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to owner concerned. Adding RB-Stable for M-70, Please remove if this not the case. 

Please navigate to below link for log's  --
go/chrome-androidlogs/879961
Status: Started (was: Assigned)
Cc: benmason@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9b57e6918391d6c80a09b1b3af3fcdba778d30e

commit c9b57e6918391d6c80a09b1b3af3fcdba778d30e
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Fri Sep 21 15:55:49 2018

Don't ack TOUCH_TIMEOUT events from the tail queue.

In CL https://chromium-review.googlesource.com/c/chromium/src/+/1169528
we modified CreateGesture to always attach a unique_touch_event_id, if
available, to GestureEvents it creates. This facilitates event
targetting by not attempting to re-hittest these events in
RenderWidgetHostInputEventRouter. Normally an id of 0 indicates an
Android ContentView event which must be handled separately.

However, adding ids to all GestureEvents has lead to the associated
bug, since GestureEventDataPackets for TOUCH_TIMEOUT can now share a
unique_touch_event_id with another event in the same Sequence. In this
case, we shouldn't mistakenly ack events with source TOUCH_TIMEOUT from
the tail of the queue.

Bug:  879961 
Change-Id: I65dd669cda6c276d6d73bb56b0d761694cb03c82
Reviewed-on: https://chromium-review.googlesource.com/1232592
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593202}
[modify] https://crrev.com/c9b57e6918391d6c80a09b1b3af3fcdba778d30e/ui/events/gesture_detection/touch_disposition_gesture_filter.cc

NextAction: 2018-09-24
Status: Fixed (was: Started)
The change in C#9 should fix this issue.

I'll let the fix bake for a day or two before requesting merg to M-70.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-70; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-70 label, otherwise remove Merge-TBD label. Thanks.
The NextAction date has arrived: 2018-09-24
Labels: -Merge-TBD Merge-Request-70
Project Member

Comment 14 by sheriffbot@chromium.org, Sep 24

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-70 Merge-Approved-70
Approved for merge to 70, branch 3538.
Project Member

Comment 16 by bugdroid1@chromium.org, Sep 28

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af72b91304ba10deefb6a91ce3cb05c2dce3e9d3

commit af72b91304ba10deefb6a91ce3cb05c2dce3e9d3
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Fri Sep 28 17:58:34 2018

Don't ack TOUCH_TIMEOUT events from the tail queue.

In CL https://chromium-review.googlesource.com/c/chromium/src/+/1169528
we modified CreateGesture to always attach a unique_touch_event_id, if
available, to GestureEvents it creates. This facilitates event
targetting by not attempting to re-hittest these events in
RenderWidgetHostInputEventRouter. Normally an id of 0 indicates an
Android ContentView event which must be handled separately.

However, adding ids to all GestureEvents has lead to the associated
bug, since GestureEventDataPackets for TOUCH_TIMEOUT can now share a
unique_touch_event_id with another event in the same Sequence. In this
case, we shouldn't mistakenly ack events with source TOUCH_TIMEOUT from
the tail of the queue.

Bug:  879961 
Change-Id: I65dd669cda6c276d6d73bb56b0d761694cb03c82
Reviewed-on: https://chromium-review.googlesource.com/1232592
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#593202}(cherry picked from commit c9b57e6918391d6c80a09b1b3af3fcdba778d30e)
Reviewed-on: https://chromium-review.googlesource.com/1249536
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#742}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/af72b91304ba10deefb6a91ce3cb05c2dce3e9d3/ui/events/gesture_detection/touch_disposition_gesture_filter.cc

Works as per expected behavior, Issue verified on 70.0.3538.46 and 71.0.3569.0

Sign in to add a comment