New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 879954 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
OOO until 4th Feb
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX

Blocking:
issue 802945



Sign in to add a comment

Make midi sysex syncable

Project Member Reported by raymes@chromium.org, Sep 3

Issue description

In https://chromium-review.googlesource.com/c/chromium/src/+/1196283 we're temporarily making the midi sysex permission unsyncable. This is because as a part of launching permission delegation, we need to perform a migration of some settings. Migrating syncable settings is complicated and it's not critical that midi sysex be syncable. So we're temporarily making it not syncable. This should be reverted 2 milestones after permission delegation has rolled out - which at this stage is approximately M74.

 
Blocking: 802945

Comment 2 Deleted

Comment 3 Deleted

The above comments aren't relevant or constructive. Please refer to our code of conduct for contributions: https://chromium.googlesource.com/chromium/src/+/master/CODE_OF_CONDUCT.md
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76e7b6c7586052e4042c7dbf456e3e0bdcfe6065

commit 76e7b6c7586052e4042c7dbf456e3e0bdcfe6065
Author: Raymes Khoury <raymes@chromium.org>
Date: Mon Sep 03 03:48:21 2018

Make the midi sysex content setting unsyncable

The migration code for permission delegation is going to touch the midi
sysex seting which is currently syncable. Migration code does not run
well on syncable settings. To work around this for the time being, we're
temporarily making midi sysex not syncable.

Bug: 802945, 879954
Change-Id: I36fb0c83fbd823e6c4612a64dce84787080a8732
Reviewed-on: https://chromium-review.googlesource.com/1196283
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588324}
[modify] https://crrev.com/76e7b6c7586052e4042c7dbf456e3e0bdcfe6065/components/content_settings/core/browser/content_settings_registry.cc

Components: -Internals>Permissions Internals>Permissions>Model

Sign in to add a comment