Crostini: only mark vms as running once Tremplin has started in the VM |
||
Issue descriptionIn CrostiniManager, there is a map of running_vms_ which stores the VmInfo for each VM that starts. These should not really be marked as "running" until after the Tremplin service has started in the VM and sent a signal back to Chrome. Without Tremplin running, they can't be used to create/start containers.
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bf3133c14c9ea5e5cbd8cf47480c2df20b181ea commit 1bf3133c14c9ea5e5cbd8cf47480c2df20b181ea Author: Josh Pratt <jopra@chromium.org> Date: Wed Sep 05 22:47:08 2018 Mark VMs as running in callback after Tremplin has started This adds a second stage to OnStartTerminaVm in the form of a callback, fired when Tremplin starts. Bug: 879953 Change-Id: I9dee6f9750f03fb50c12b7473763abc966d0a7a7 Reviewed-on: https://chromium-review.googlesource.com/1203510 Reviewed-by: Nicholas Verne <nverne@chromium.org> Commit-Queue: Josh Pratt <jopra@chromium.org> Cr-Commit-Position: refs/heads/master@{#589039} [modify] https://crrev.com/1bf3133c14c9ea5e5cbd8cf47480c2df20b181ea/chrome/browser/chromeos/crostini/crostini_manager.cc [modify] https://crrev.com/1bf3133c14c9ea5e5cbd8cf47480c2df20b181ea/chrome/browser/chromeos/crostini/crostini_manager.h [modify] https://crrev.com/1bf3133c14c9ea5e5cbd8cf47480c2df20b181ea/chrome/browser/chromeos/crostini/crostini_manager_unittest.cc
,
Sep 6
|
||
►
Sign in to add a comment |
||
Comment 1 by jopra@chromium.org
, Sep 3