components_perftests failing on Windows 10 perf bot |
|||
Issue descriptionBuild: https://ci.chromium.org/buildbot/chromium.perf/win-10-perf/458 Log: 3 tests timed out: ProtoDBPerfTest.DistributionTestSmall_ManyEntries (../../components/leveldb_proto/proto_database_perftest.cc:578) ProtoDBPerfTest.InsertMultipleDBsAlternating_Individual (../../components/leveldb_proto/proto_database_perftest.cc:532) ProtoDBPerfTest.InsertSingleDBAlternating_Individual (../../components/leveldb_proto/proto_database_perftest.cc:541) https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2Fwin-10-perf%2F458%2F%2B%2Frecipes%2Fsteps%2Fcomponents_perftests_on_Intel_GPU_on_Windows_on_Windows-10%2F0%2Fstdout I will disable failing test for now
,
Sep 5
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5afc5b557d8ca1e58d85cd7882fa3c9e813aa8a5 commit 5afc5b557d8ca1e58d85cd7882fa3c9e813aa8a5 Author: Troy Hildebrandt <thildebr@chromium.org> Date: Fri Sep 28 16:48:58 2018 Break up the ProtoDatabasePerfTests. This CL breaks up many larger tests into smaller tests that are less likely to time out. Also reduced the amount of work particular tests perform to further ensure no timeouts. TBR=nyquist@chromium.org Bug: 879922 Change-Id: I9591c9bd4f4308ce9eb183289d5c49c98df72b32 Reviewed-on: https://chromium-review.googlesource.com/1240127 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#595122} [modify] https://crrev.com/5afc5b557d8ca1e58d85cd7882fa3c9e813aa8a5/components/leveldb_proto/proto_database_perftest.cc
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67bf09a84df68ed00372b444944444be5bdf8be6 commit 67bf09a84df68ed00372b444944444be5bdf8be6 Author: Sami Kyostila <skyostil@chromium.org> Date: Tue Oct 02 16:50:25 2018 Disable timing out ProtoDB perf tests TBR=nyquist@chromium.org Bug: 879922 Change-Id: If59565e8610e6307868f9f7ad5ffe8cba54d5f1e Reviewed-on: https://chromium-review.googlesource.com/1256946 Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#595879} [modify] https://crrev.com/67bf09a84df68ed00372b444944444be5bdf8be6/components/leveldb_proto/proto_database_perftest.cc
,
Oct 2
Still timing out are they...
,
Oct 11
Yeah, looks like the remaining ones are also timing out flakily on Windows, e.g: https://chrome-swarming.appspot.com/task?id=407b979134c4b810&refresh=10&show_raw=1 Maybe the test set could be reduced somehow?
,
Oct 11
What's so different about running the tests on Windows vs. other platforms, do you know?
,
Oct 11
I think we saw the original timeout on low-end Windows bots, but this one looks like a regular Windows PC so it's probably not because we're running on a slow machine. Do the tests do a lot of disk IO? That might be one platform-specific difference here.
,
Oct 11
Yes, they're basically strictly disk I/O. I'll try cutting them down quite a bit more then, I didn't realize the performance hit on Windows was so significant.
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c96e46b38de51babe5429a6e5ff694858ba1a31 commit 7c96e46b38de51babe5429a6e5ff694858ba1a31 Author: Troy Hildebrandt <thildebr@chromium.org> Date: Fri Oct 12 15:58:54 2018 Significantly reduce the workload of ProtoDBPerfTest. Certain ProtoDBPerfTests still consistently fail on Windows or are flaky because they take too long. This CL re-enables the disabled tests on Windows but they should now take 10% of the time they used to. Tested locally on Linux, the disabled tests that each took ~20s to finish now take under 2. The total running time of the entire suite locally was reduced from 390s to 49s. Bug: 879922 Change-Id: I620e5329c1ffef53b311f3a04524bafa8b749381 Reviewed-on: https://chromium-review.googlesource.com/c/1276772 Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#599234} [modify] https://crrev.com/7c96e46b38de51babe5429a6e5ff694858ba1a31/components/leveldb_proto/proto_database_perftest.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Sep 3