[MdRefresh] Regression: Can not delete autocompleted suggestion in Omnibox, when it is saved as a bookmark |
|||||
Issue descriptionChrome Version: Canary 71.0.3539.0 OS: Probably OS=All What steps will reproduce the problem? (1) visit google.com (2) save it as bookmark (3) close the tab (4) open a new Tab (5) type goog into the Omnibox (it must be at least 4 letters), so that google.com is autocompleted in the Omnibox (6) Press the Delete Key What is the expected result? The Delete Key should be accepted by the Omnibox. What happens instead? The Delete Key is not accepted by the Omnibox. Here is the regression range: https://chromium.googlesource.com/chromium/src/+log/3da2da6a07d1df3f9cd3aed22dd3dbdd2d2ca262..765de89597de3bc04859164c038eec9926f7a477 This is probably caused by: https://chromium-review.googlesource.com/c/chromium/src/+/1174860 krb@: Can you please take a look at this regression? Thanks in advance :) Mehmet
,
Sep 4
I can duplicate this. Here's what's happening. For the entry 'goog', I get the following duplicate suggestions: For URL http://google.com/: fill into edit 'https://www.google.com' default: YES (autocomplete 'le.com') relevance 1010 type bookmark-title fill into edit 'https://www.google.com' default: YES (autocomplete 'le.com') relevance 1308 type history-url fill into edit 'https://www.google.com' default: YES (autocomplete 'le.com') relevance 1413 type history-url fill into edit 'https://www.google.com' default: YES (autocomplete 'le.com') relevance 756 type history-url The 1413 is best, so it's promoted. But after I hit delete, most of those change to 'not default': For URL http://google.com/: fill into edit 'https://www.google.com' default: YES (autocomplete 'le.com') relevance 1010 type bookmark-title fill into edit 'https://www.google.com' default: NO relevance 1308 type history-url fill into edit 'https://www.google.com' default: NO relevance 1413 type history-url fill into edit 'https://www.google.com' default: NO relevance 756 type history-url We still promote the 1413, due to the new logic, kicking out what would have been best: URL http://google.com/search?q=goog&sourceid=chrome&ie=UTF-8 fill into edit 'goog' default: YES (autocomplete '') relevance 1300 type search-what-you-typed Mark, perhaps we have to disable promotion after backspace or delete? I don't think we can hinge this on match type, since it's not changing between the two sets, but I can dump any other fields that you think might be interesting.
,
Sep 4
I don't think the relevance promotion is the root cause of the bug. At issue here is that the bookmark match, with a non-empty inline autocompletion, is being marked as allowed_to_be_default_match even though prevent_inline_autocomplete is true. That's the bug. It's just the relevance matches surface it more. For a pointer to where to look to fix this issue, see https://cs.chromium.org/chromium/src/components/omnibox/browser/titled_url_match_utils.cc?l=109-115
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64a9d00b7cc27185a5a09f7a73d43466159be027 commit 64a9d00b7cc27185a5a09f7a73d43466159be027 Author: Kevin Bailey <krb@chromium.org> Date: Fri Sep 07 00:46:22 2018 [omnibox] Re-calculate bookmark suggestions each call Bookmark matches' |allowed_to_be_default_match| depends on |prevent_inline_autocomplete| being false. This field can be set and copied before |prevent| is set. The bookmark provider was returning cached results assuming |prevent| was still set. This CL changes the bookmark provider to never cache, and always generate and return fresh results. Bug: 879905 Change-Id: I909364500417cd629cead52a6f430b6d488142b9 Reviewed-on: https://chromium-review.googlesource.com/1204270 Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#589385} [modify] https://crrev.com/64a9d00b7cc27185a5a09f7a73d43466159be027/components/omnibox/browser/bookmark_provider.cc
,
Sep 10
,
Sep 11
branch:3538
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ef05469dfa78e3e90ae8b90e6864c4a3f1afc40 commit 0ef05469dfa78e3e90ae8b90e6864c4a3f1afc40 Author: Kevin Bailey <krb@chromium.org> Date: Tue Sep 11 21:14:26 2018 [omnibox] Re-calculate bookmark suggestions each call Bookmark matches' |allowed_to_be_default_match| depends on |prevent_inline_autocomplete| being false. This field can be set and copied before |prevent| is set. The bookmark provider was returning cached results assuming |prevent| was still set. This CL changes the bookmark provider to never cache, and always generate and return fresh results. TBR=krb@chromium.org (cherry picked from commit 64a9d00b7cc27185a5a09f7a73d43466159be027) Bug: 879905 Change-Id: I909364500417cd629cead52a6f430b6d488142b9 Reviewed-on: https://chromium-review.googlesource.com/1204270 Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589385} Reviewed-on: https://chromium-review.googlesource.com/1220559 Reviewed-by: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#295} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/0ef05469dfa78e3e90ae8b90e6864c4a3f1afc40/components/omnibox/browser/bookmark_provider.cc
,
Sep 12
Able to reproduce the issue on Mac 10.13.3 using chrome reported version #71.0.3539.0 Verified the fix on Mac 10.13.3, Win-10 and Ubuntu 17.10 using chrome version #70.0.3538.16 as per the comment #0. Attaching screen cast for reference. Observed that delete Key is accepted by the Omnibox. Hence, the fix is working as expected. Adding the verified labels. Thanks...!! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by meh...@chromium.org
, Sep 2Summary: [MdRefresh] Regression: Can not delete autocompleted suggestion in Omnibox, when it is saved as a bookmark (was: [MdRefresh] Regression: Can not delete autocompleted suggestion in Omnibox, when it saved as a bookmark)