Can we explain how we crash Chrome? That seems to be a non-standard step!

To clarify: crashing Chrome means all bets are off for Crostini
CrostiniManager dies, so forgets state like which vms are running

Updating this bug to indicate that we need to better handle Chrome crashes. We should guarantee that CrostiniManager and the VM are always in the same state after a crash, which means either:
1) We recover CrostiniManager so it knows VMs are running (preferred)
2) We shut down the VM to match CrostiniManager

This also ties in with efforts to make Wayland continue working after a Chrome crash.

For CrostiniManager, what state is it storing that could not be recovered from garcon?

chirantan will look into shutting down the VM after a Chrome crash. Adding jkardatzke who did something similar for ARC++.

Mine was tied more closely to ARC..so it's not a good example unfortunately:

https://chrome-internal-review.googlesource.com/c/chromeos/platform/arc-oemcrypto/+/624256

But I know this handled Chrome crashes/restarts as well.

 Issue 848213  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1c7f7d4bf3bd1c17f4d99eb6ea850b6cc301c49f

commit 1c7f7d4bf3bd1c17f4d99eb6ea850b6cc301c49f
Author: Chirantan Ekbote <chirantan@chromium.org>
Date: Sat Sep 08 01:37:09 2018

login: Stop VMs if chrome exits

Stop any running VMs if chrome exits.  This ensures that the VMs don't
end up in a state where GUI apps don't work because they are trying to
connect to a wayland server that no longer exists.

BUG= chromium:879903 
TEST=unit test and manual
     start 2 vms, navigate to chrome://restart, and check the logs to
     see that the StopAllVms method was called and all vms exited

Change-Id: I94e71192b53c7d26e083477df87763d89962459c
Signed-off-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1205817

[modify] https://crrev.com/1c7f7d4bf3bd1c17f4d99eb6ea850b6cc301c49f/login_manager/session_manager_process_test.cc
[modify] https://crrev.com/1c7f7d4bf3bd1c17f4d99eb6ea850b6cc301c49f/login_manager/session_manager_service.cc
[modify] https://crrev.com/1c7f7d4bf3bd1c17f4d99eb6ea850b6cc301c49f/login_manager/session_manager_service.h

Requesting a merge for the change in #12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/852290202446b3371644c32ed9aa84dee8ef3700

commit 852290202446b3371644c32ed9aa84dee8ef3700
Author: Chirantan Ekbote <chirantan@chromium.org>
Date: Mon Sep 10 22:22:56 2018

login: Stop VMs if chrome exits

Stop any running VMs if chrome exits.  This ensures that the VMs don't
end up in a state where GUI apps don't work because they are trying to
connect to a wayland server that no longer exists.

BUG= chromium:879903 
TEST=unit test and manual
     start 2 vms, navigate to chrome://restart, and check the logs to
     see that the StopAllVms method was called and all vms exited

Signed-off-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1205817

(cherry picked from commit 1c7f7d4bf3bd1c17f4d99eb6ea850b6cc301c49f)
Signed-off-by: Chirantan Ekbote <chirantan@chromium.org>

Change-Id: I94e71192b53c7d26e083477df87763d89962459c
Reviewed-on: https://chromium-review.googlesource.com/1217823
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Commit-Queue: Chirantan Ekbote <chirantan@chromium.org>
Tested-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/852290202446b3371644c32ed9aa84dee8ef3700/login_manager/session_manager_service.cc
[modify] https://crrev.com/852290202446b3371644c32ed9aa84dee8ef3700/login_manager/session_manager_process_unittest.cc
[modify] https://crrev.com/852290202446b3371644c32ed9aa84dee8ef3700/login_manager/session_manager_service.h

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

I've made a new bug related to running wayland applications after chrome crash without having to restart the VMs: https://bugs.chromium.org/p/chromium/issues/detail?id=884398

Verified by crashing chrome and observed StopAllVms in logs in kevin with M71- 11120.0.0.