Feature Request: Show contrast ratio line for AAA
Reported by
kaycebas...@gmail.com,
Sep 1
|
||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.0 Safari/537.36 Steps to reproduce the problem: 1. Open the color picker. 2. Click the Contrast Ratio section to show the line. What is the expected behavior? There's a way to show a line for AAA colors. What went wrong? You can only see a line for AA colors. Did this work before? No Chrome version: 70.0.3538.0 Channel: n/a OS Version: OS X 10.13.6 Flash Version:
,
Sep 3
@aboxhall, would this make sense for a11y?
,
Sep 3
Yep, that would be cool! Would you want to toggle it, or always show two lines?
,
Dec 3
I think two lines is great.
,
Dec 11
Here's a screenshot for the patch: https://chromium-review.googlesource.com/c/chromium/src/+/1370233/
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06c91da2e7454048cbe91e46685e9965b201d928 commit 06c91da2e7454048cbe91e46685e9965b201d928 Author: Alice Boxhall <aboxhall@chromium.org> Date: Wed Dec 12 23:51:18 2018 [Devtools] Show both AA and AAA contrast ratio lines in the color picker Bug: 879856 Change-Id: Ia0e3da7202f58504d4f6320ea7e817ce24c61269 Reviewed-on: https://chromium-review.googlesource.com/c/1370233 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#616110} [modify] https://crrev.com/06c91da2e7454048cbe91e46685e9965b201d928/third_party/blink/renderer/devtools/front_end/color_picker/ContrastOverlay.js [modify] https://crrev.com/06c91da2e7454048cbe91e46685e9965b201d928/third_party/blink/web_tests/http/tests/devtools/color_picker/contrast-overlay-expected.txt [modify] https://crrev.com/06c91da2e7454048cbe91e46685e9965b201d928/third_party/blink/web_tests/http/tests/devtools/color_picker/contrast-overlay.js |
||
►
Sign in to add a comment |
||
Comment 1 by viswa.karala@chromium.org
, Sep 2