New issue
Advanced search Search tips

Issue 879852 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in avformat_find_stream_info

Project Member Reported by ClusterFuzz, Sep 1

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6710481663033344

Fuzzer: libFuzzer_audio_decoder_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  avformat_find_stream_info
  media::AudioFileReader::OpenDemuxer
  media::AudioFileReader::Open
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=546308:546319

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6710481663033344

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Sep 1

Components: Internals>Media>FFmpeg
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Sep 1

Labels: Test-Predator-Auto-Owner
Owner: mmoroz@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/4b5068a99a84ff2edb34aa0549afc89aa751ccb4 (Add audio_decoder_fuzzer fuzz target.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: wolenetz@chromium.org liber...@chromium.org
Owner: dalecur...@chromium.org
Dale, may I ask you please to pass this to a proper owner?
Easy fix, start_time is AV_NOPTS_VALUE. Will send patch.
Patch sent upstream, will pull down after they apply.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2735761284f040ee91da93b4737116eaf8ad2339

commit 2735761284f040ee91da93b4737116eaf8ad2339
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Mon Sep 10 21:06:20 2018

Roll src/third_party/ffmpeg/ bfe62e18d..bbe6b81a6 (4 commits)

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/bfe62e18d24f..bbe6b81a6c31

$ git log bfe62e18d..bbe6b81a6 --date=short --no-merges --format='%ad %ae %s'
2018-09-10 dalecurtis Update patches file for new ffmpeg fixes.
2018-09-07 dalecurtis avformat/utils: Don't calculate duration using AV_NOPTS_VALUE for start_time.
2018-08-30 dalecurtis avformat/mov: Error on too large stsd entry counts.
2018-08-22 liberato Fetch upstream and check for upstream commit.

Created with:
  roll-dep src/third_party/ffmpeg

BUG= 879852 ,  826648 
TBR=tguilbert

Change-Id: Ibdec4e7e2ffd3d7d61bdefa71f09814d699bba5b
Reviewed-on: https://chromium-review.googlesource.com/1217040
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590062}
[modify] https://crrev.com/2735761284f040ee91da93b4737116eaf8ad2339/DEPS

Status: Fixed (was: Assigned)
Project Member

Comment 8 by ClusterFuzz, Sep 12

ClusterFuzz has detected this issue as fixed in range 589988:590303.

Detailed report: https://clusterfuzz.com/testcase?key=6710481663033344

Fuzzer: libFuzzer_audio_decoder_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  avformat_find_stream_info
  media::AudioFileReader::OpenDemuxer
  media::AudioFileReader::Open
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=546308:546319
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=589988:590303

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6710481663033344

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Sep 12

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6710481663033344 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment