New issue
Advanced search Search tips

Issue 879851 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Terminal window bar should be grey, not blue

Project Member Reported by tbuck...@chromium.org, Sep 1

Issue description

Chrome version: 70.0.3538.0 canary
OS: Chrome

See screenshot
 
Screenshot 2018-09-01 at 11.32.14 AM.png
26.9 KB View Download
Did this change recently for you? Mine is still grey on dev channel.
It's blue on my local ToT build. I don't know how it changed at this stage.
Cc: est...@chromium.org
This was broken by https://chromium-review.googlesource.com/c/chromium/src/+/1187406
Owner: alancutter@chromium.org
Fix is pretty simple, just working out how even to test this.
https://chromium-review.googlesource.com/c/chromium/src/+/1223951
personally i've found the grey bar to be ugly, so the blue one is a bit nicer
actually, is this even a bug ?  if i load other apps like Hangouts or Crosh Window or Secure Shell, they all use a blue bar now.  so we should find out if it's a common UI change and then just follow that.  there is no requirement that the Terminal app itself always use a grey bar ... it should do the same thing as all other CrOS apps.
It's an unintentional regression that applies to all cros apps.
Is fixing this merge worthy (for M70)?
Assuming it is not too dangerous, yes.
Any progress with this bug?
I like the blue
WIP CL screenshots.
before.png
125 KB View Download
after.png
140 KB View Download
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5becfacf4db983efdd63625cfaad8693e60e13c3

commit 5becfacf4db983efdd63625cfaad8693e60e13c3
Author: Alan Cutter <alancutter@chromium.org>
Date: Tue Sep 25 02:08:49 2018

Fix Ash app title bar color being blue instead of grey

The color of Ash app window title bar was changed to
the same color of the settings app title bar accidentally in
https://chromium-review.googlesource.com/c/chromium/src/+/1125512.
This changed DevTools, the Terminal and Chrome App windows to be blue.

This CL fixes the unintentional change in behavior by updating
UpdateFrameColors() to use the same guard as CreateFrameHeader() when
setting the frame color to kMdWebUiFrameColor.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=359594&signed_aid=Yr-u3b9GUhWb0iEc6igy5Q==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=359595&signed_aid=rfGnleo9Sj8jmcVXfDipeg==&inline=1

Bug:  879851 
Change-Id: I8980b7f52f529390938a1a5ff05742b336e665d2
Reviewed-on: https://chromium-review.googlesource.com/1223951
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593802}
[modify] https://crrev.com/5becfacf4db983efdd63625cfaad8693e60e13c3/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/5becfacf4db983efdd63625cfaad8693e60e13c3/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc

Cc: benwells@chromium.org
Tom - do you want us to try to merge this? It is a very simple fix but it is getting late for merges to 70.
It's a ~1 line change, I vote merge.
Labels: Merge-Request-70
Requesting to merge https://crrev.com/5becfacf4db983efdd63625cfaad8693e60e13c3 to 70 to fix incorrect title bar colours for DevTools, Terminal and other app windows on Chrome OS.
Project Member

Comment 17 by sheriffbot@chromium.org, Sep 26

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 19 by bugdroid1@chromium.org, Sep 27

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c72b08e397fb6c2c3f034e0474d9b89d0d154bf3

commit c72b08e397fb6c2c3f034e0474d9b89d0d154bf3
Author: Alan Cutter <alancutter@chromium.org>
Date: Thu Sep 27 00:52:19 2018

Fix Ash app title bar color being blue instead of grey

The color of Ash app window title bar was changed to
the same color of the settings app title bar accidentally in
https://chromium-review.googlesource.com/c/chromium/src/+/1125512.
This changed DevTools, the Terminal and Chrome App windows to be blue.

This CL fixes the unintentional change in behavior by updating
UpdateFrameColors() to use the same guard as CreateFrameHeader() when
setting the frame color to kMdWebUiFrameColor.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=359594&signed_aid=Yr-u3b9GUhWb0iEc6igy5Q==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=359595&signed_aid=rfGnleo9Sj8jmcVXfDipeg==&inline=1

Bug:  879851 
Change-Id: I8980b7f52f529390938a1a5ff05742b336e665d2
Reviewed-on: https://chromium-review.googlesource.com/1223951
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#593802}(cherry picked from commit 5becfacf4db983efdd63625cfaad8693e60e13c3)
Reviewed-on: https://chromium-review.googlesource.com/1247721
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#694}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/c72b08e397fb6c2c3f034e0474d9b89d0d154bf3/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/c72b08e397fb6c2c3f034e0474d9b89d0d154bf3/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/c72b08e397fb6c2c3f034e0474d9b89d0d154bf3

Commit: c72b08e397fb6c2c3f034e0474d9b89d0d154bf3
Author: alancutter@chromium.org
Commiter: alancutter@chromium.org
Date: 2018-09-27 00:52:19 +0000 UTC

Fix Ash app title bar color being blue instead of grey

The color of Ash app window title bar was changed to
the same color of the settings app title bar accidentally in
https://chromium-review.googlesource.com/c/chromium/src/+/1125512.
This changed DevTools, the Terminal and Chrome App windows to be blue.

This CL fixes the unintentional change in behavior by updating
UpdateFrameColors() to use the same guard as CreateFrameHeader() when
setting the frame color to kMdWebUiFrameColor.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=359594&signed_aid=Yr-u3b9GUhWb0iEc6igy5Q==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=359595&signed_aid=rfGnleo9Sj8jmcVXfDipeg==&inline=1

Bug:  879851 
Change-Id: I8980b7f52f529390938a1a5ff05742b336e665d2
Reviewed-on: https://chromium-review.googlesource.com/1223951
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#593802}(cherry picked from commit 5becfacf4db983efdd63625cfaad8693e60e13c3)
Reviewed-on: https://chromium-review.googlesource.com/1247721
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#694}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
Status: Fixed (was: Assigned)
Cc: rohi...@chromium.org avkodipelli@chromium.org
Status: Verified (was: Fixed)
Verified on 11137.0.0, 71.0.3567.0

Sign in to add a comment