Issue metadata
Sign in to add a comment
|
[WPT] New failures introduced in external/wpt/webaudio by import https://crrev.com/c/1200824 |
||||||||||||||||||||||
Issue descriptionWPT import https://crrev.com/c/1200824 introduced new failures in external/wpt/webaudio: List of new failures: external/wpt/webaudio/the-audio-api/the-pannernode-interface/ctor-panner.html new failing tests: https://crrev.com/c/1200824/4/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-pannernode-interface/ctor-panner-expected.txt This import contains upstream changes from 268ce53f61d5005c808df3991c5ae47844fe66d8 to 0588fa34e9f30dd2eaf0421254a759647eb5710c: Merge pull request #12793 from web-platform-tests/sync_a56619e7fb09a02b032e4acab5cd7704bd242ae3: https://github.com/web-platform-tests/wpt/commit/0588fa34e9f30dd2eaf0421254a759647eb5710c Merge pull request #12792 from web-platform-tests/sync_1ce329cb195c77b3d26cb1cadc75aecef7d33728: https://github.com/web-platform-tests/wpt/commit/ab98b1b9d0a587fa3c0fb07a5df793971e856e7b correct failing tests: https://github.com/web-platform-tests/wpt/commit/a56619e7fb09a02b032e4acab5cd7704bd242ae3 Add tests for options bounds in PannerNode's constructor: https://github.com/web-platform-tests/wpt/commit/1ce329cb195c77b3d26cb1cadc75aecef7d33728 [affecting this directory]
,
Sep 4
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f22f8191bf1d0bb9cd81c9d7a5260104bd254f66 commit f22f8191bf1d0bb9cd81c9d7a5260104bd254f66 Author: Raymond Toy <rtoy@chromium.org> Date: Wed Sep 05 23:05:10 2018 Throw errors for invalid rolloffFactor and coneOuterGain The WebAudio spec says we must throw errors for a negative rolloffFactor and for a coneOuterGain outside the interval [0, 1]. Make it so. Also add some additional tests to ctor-panner.html to verify that a rolloffFactor of 0 or 100 do not throw errors and that a coneOuterGain of 0 or 1 do not throw errors. Remove invalid tests from panner-rolloff-clamping.html because negative rolloffFactor now throws an error. Finally remove text expectation for ctor-panner.html test, which passes now. Bug: 879845 Test: the-pannernode-interface/ctor-panner.html, the-pannernode-interface/panner-rolloff-clamping.html Change-Id: Ie90e9fe13e82fd3cc955060dc9e77266ef4ff591 Reviewed-on: https://chromium-review.googlesource.com/1205099 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#589045} [delete] https://crrev.com/dab6b733ee926fbf6b933f87e6c62939ce209a30/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-pannernode-interface/ctor-panner-expected.txt [modify] https://crrev.com/f22f8191bf1d0bb9cd81c9d7a5260104bd254f66/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-pannernode-interface/ctor-panner.html [modify] https://crrev.com/f22f8191bf1d0bb9cd81c9d7a5260104bd254f66/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping.html [modify] https://crrev.com/f22f8191bf1d0bb9cd81c9d7a5260104bd254f66/third_party/blink/renderer/modules/webaudio/panner_node.cc [modify] https://crrev.com/f22f8191bf1d0bb9cd81c9d7a5260104bd254f66/third_party/blink/renderer/modules/webaudio/panner_node.h [modify] https://crrev.com/f22f8191bf1d0bb9cd81c9d7a5260104bd254f66/third_party/blink/renderer/modules/webaudio/panner_node.idl
,
Sep 6
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rtoy@chromium.org
, Sep 4