The damage rect of the video overlay size is off by one pixel/line |
|
Issue descriptionChrome Version: ( 70.0.3531.0) OS: Win10 What steps will reproduce the problem? (1) Go to YouTube. Might need to stretch the Chrome window a bit so we can get a different video size. Or run attached Overlay_baby.html, which has a size that is easy to reproduce this problem. (2) Check DCLayerOverlayProcessor::ProcessForUnderlay() or DCLayerOverlayProcessor::ProcessForOverlay(). The damage rect of the video overlay size is off by one pixel, either in the width or height. See the code in this link. https://cs.chromium.org/chromium/src/components/viz/service/display/dc_layer_overlay.cc?type=cs&q=is_root+%26%26+!processed_overlay_in_frame_+%26%26+is_axis_aligned+%26%26+is_opaque&sq=package:chromium&g=0&l=456 In the underlay case, we want to carve out the video from the overlay from the damage rect and reduce the size of damage rect. Because of this extra pixel/line. The damage rect size sometimes cannot be reduced. |
|
►
Sign in to add a comment |
|
Comment 1 by magchen@chromium.org
, Sep 1