New issue
Advanced search Search tips

Issue 879803 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

"org.chromium.chrome.browser.bookmarks.BookmarkTest#testOpenBookmarkManager" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Sep 1

Issue description

"org.chromium.chrome.browser.bookmarks.BookmarkTest#testOpenBookmarkManager" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVQsSBUZsYWtlIkpvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIuYm9va21hcmtzLkJvb2ttYXJrVGVzdCN0ZXN0T3BlbkJvb2ttYXJrTWFuYWdlcgw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Components: UI>Browser>Bookmarks
Labels: OS-Android
Owner: twelling...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98b974de133e1283a4806c5f7f85c97573da37bb

commit 98b974de133e1283a4806c5f7f85c97573da37bb
Author: Oksana Zhuravlova <oksamyt@chromium.org>
Date: Sat Sep 01 04:02:30 2018

Mark BookmarkTest#testOpenBookmarkManager as flaky

Bug: 879803

Change-Id: Ie3db494b151b36bc73ae9f9067c0c89d4685553b

TBR=twellington@chromium.org

Change-Id: Ie3db494b151b36bc73ae9f9067c0c89d4685553b
Reviewed-on: https://chromium-review.googlesource.com/1200172
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588263}
[modify] https://crrev.com/98b974de133e1283a4806c5f7f85c97573da37bb/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkTest.java

Labels: -Sheriff-Chromium
Labels: -Pri-1 Pri-2
From the stack trace, it appears that mItemsContainer#getAdapter() or BookmarkItemsAdapter#getDelegateForTesting is returning null, which should only happen if we're trying to retrieve the delegate before the adapter is fully initialized.

It appears this has been flaky for a while but just became more flaky recently (08-31). Nothing has changed in the bookmarks code recently so it's not clear why this would have suddenly started flaking, especially since there are other tests in the same suite that have the same block of code.

There's still test coverage of this block of code via the other tests that are still enabled, so moving this to a P2.

java.lang.NullPointerException
	at org.chromium.chrome.browser.bookmarks.BookmarkTest.testOpenBookmarkManager(BookmarkTest.java:216)
	at java.lang.reflect.Method.invokeNative(Method.java)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:116)
	at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55)
	at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270)
	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:237)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:48)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:220)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
	at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:125)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

Sign in to add a comment