New issue
Advanced search Search tips

Issue 879783 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 16
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 721403
issue 855620



Sign in to add a comment

Migrate components/data_reduction_proxy/core/browser/secure_proxy_checker.cc to using SimpleURLLoader

Project Member Reported by jam@chromium.org, Aug 31

Issue description

Blocks Android canary





 
Status: Available (was: Untriaged)
Blocking: 721403
Cc: cduvall@chromium.org
Owner: toniki...@chromium.org
Status: Started (was: Available)
Blocking: 855620
Quick update: Retaking the work here (after  bug 879784  and  bug 879777  are done.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5c4e7f054faf57a62bcb0c396224c77ce764eb4

commit e5c4e7f054faf57a62bcb0c396224c77ce764eb4
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Tue Oct 16 17:07:54 2018

Migrate components/data_reduction_proxy/core/browser/secure_proxy_checker.cc to using SimpleURLLoader

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates DRP's SecureProxyChecker and the
respective unittests away from URLFetcher.

Note that according to tbansal@, using a separate URL request context
that disables SPDY/QUIC is not be needed anymore.
Another requirement of DRP's SecureProxyChecker is that the use of any proxies
is also disabled. For this, the load flag LOAD_BYPASS_PROXY should be enough.

This means that the customized class BasicHTTPURLRequestContextGetter is not
used anymore, and will be removed in a follow up pass.

BUG= 879783 

Change-Id: I5f62007c284b35f9364caec37984cbf63e813720
Reviewed-on: https://chromium-review.googlesource.com/c/1281643
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#600022}
[modify] https://crrev.com/e5c4e7f054faf57a62bcb0c396224c77ce764eb4/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/e5c4e7f054faf57a62bcb0c396224c77ce764eb4/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
[modify] https://crrev.com/e5c4e7f054faf57a62bcb0c396224c77ce764eb4/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/e5c4e7f054faf57a62bcb0c396224c77ce764eb4/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
[modify] https://crrev.com/e5c4e7f054faf57a62bcb0c396224c77ce764eb4/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
[modify] https://crrev.com/e5c4e7f054faf57a62bcb0c396224c77ce764eb4/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h
[modify] https://crrev.com/e5c4e7f054faf57a62bcb0c396224c77ce764eb4/components/data_reduction_proxy/core/browser/secure_proxy_checker.cc
[modify] https://crrev.com/e5c4e7f054faf57a62bcb0c396224c77ce764eb4/components/data_reduction_proxy/core/browser/secure_proxy_checker.h

Status: Fixed (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/722649c8bc057a1601d94efb57ffa09270063730

commit 722649c8bc057a1601d94efb57ffa09270063730
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Tue Oct 16 21:43:47 2018

Remove net::URLRequestStatus from DataReductionProxyConfigTest

This is a follow up of mmenke's request in [1].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1281643/3#37

BUG= 879783 

Change-Id: If7267a4be836a1e8adfca5f7377fa57b53ebcd49
Reviewed-on: https://chromium-review.googlesource.com/c/1284449
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600134}
[modify] https://crrev.com/722649c8bc057a1601d94efb57ffa09270063730/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc

Sign in to add a comment