New issue
Advanced search Search tips

Issue 879778 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Subresource Filter: Disallow indexing rules with non-ascii characters.

Project Member Reported by karandeepb@chromium.org, Aug 31

Issue description

Also see  issue 878138  for extensions.
 
Status: Fixed (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54dfcd966d92273224f2107ae7492ed4dfc984dc

commit 54dfcd966d92273224f2107ae7492ed4dfc984dc
Author: Karan Bhatia <karandeepb@chromium.org>
Date: Wed Sep 05 22:05:34 2018

Subresource Filter: Disallow indexing rules with non-ascii characters.

While comparing a rule against a url, url_pattern_index assumes that the
provided pattern and domains are in canonical form (internationalized domains in
punycode and non-ascii characters in percent-escaped utf8). Document this as
part of url_pattern_index and disallow indexing rules with non-ascii patterns or
domains.

BUG= 879778 

Change-Id: I725c37cd837c862ed3f0024c132ce2acf9c79642
Reviewed-on: https://chromium-review.googlesource.com/1198490
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589020}
[modify] https://crrev.com/54dfcd966d92273224f2107ae7492ed4dfc984dc/components/subresource_filter/core/common/indexed_ruleset_unittest.cc
[modify] https://crrev.com/54dfcd966d92273224f2107ae7492ed4dfc984dc/components/url_pattern_index/flat/url_pattern_index.fbs
[modify] https://crrev.com/54dfcd966d92273224f2107ae7492ed4dfc984dc/components/url_pattern_index/url_pattern_index.cc

Sign in to add a comment