Subresource Filter: Disallow indexing rules with non-ascii characters. |
|
Issue descriptionAlso see issue 878138 for extensions.
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54dfcd966d92273224f2107ae7492ed4dfc984dc commit 54dfcd966d92273224f2107ae7492ed4dfc984dc Author: Karan Bhatia <karandeepb@chromium.org> Date: Wed Sep 05 22:05:34 2018 Subresource Filter: Disallow indexing rules with non-ascii characters. While comparing a rule against a url, url_pattern_index assumes that the provided pattern and domains are in canonical form (internationalized domains in punycode and non-ascii characters in percent-escaped utf8). Document this as part of url_pattern_index and disallow indexing rules with non-ascii patterns or domains. BUG= 879778 Change-Id: I725c37cd837c862ed3f0024c132ce2acf9c79642 Reviewed-on: https://chromium-review.googlesource.com/1198490 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#589020} [modify] https://crrev.com/54dfcd966d92273224f2107ae7492ed4dfc984dc/components/subresource_filter/core/common/indexed_ruleset_unittest.cc [modify] https://crrev.com/54dfcd966d92273224f2107ae7492ed4dfc984dc/components/url_pattern_index/flat/url_pattern_index.fbs [modify] https://crrev.com/54dfcd966d92273224f2107ae7492ed4dfc984dc/components/url_pattern_index/url_pattern_index.cc |
|
►
Sign in to add a comment |
|
Comment 1 by karandeepb@chromium.org
, Sep 5