New issue
Advanced search Search tips

Issue 879777 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 5
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 721403
issue 855620



Sign in to add a comment

Migrate components/data_reduction_proxy/core/browser/warmup_url_fetcher.cc to using SimpleURLLoader

Project Member Reported by jam@chromium.org, Aug 31

Issue description

Blocks Android canary.
 
Status: Available (was: Untriaged)
Owner: toniki...@igalia.com
Status: Started (was: Available)
Owner: toniki...@chromium.org
Blocking: 721403
first all-in-one CL: https://crrev.com/c/1251641

Working now on spin offs of, so that it gets to a review-able size.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f994c2ce70f82e0a7b145515bf715b486c3fe464

commit f994c2ce70f82e0a7b145515bf715b486c3fe464
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Tue Oct 02 16:03:28 2018

Pass an actual URLLoaderFactory instance in chrome/browser/previews tests

InitDataReductionProxySettings constructs DataReductionProxyService, which later on
is provides data to DataReductionProxyIOData to construct DataReductionProxyConfig.
Ultimately, DataReductionProxyConfig constructs WarmupURLFetcher instances.

This CL is a preparation CL for [1], where we migrate WarmupURLFetcher from
URLFetcher to SimpleURLLoader. In [1], |url loader factory| is mandatory to be non-null.
Passing an actual instance at the beginning of the call chain now
has no immediate effect, but is harmless too.

[1] https://crrev.com/c/1251641

BUG= 879777 

Change-Id: I3f3009e6e6d9db9659e7783cbed65a1a82c6a34e
Reviewed-on: https://chromium-review.googlesource.com/1256945
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#595858}
[modify] https://crrev.com/f994c2ce70f82e0a7b145515bf715b486c3fe464/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/f994c2ce70f82e0a7b145515bf715b486c3fe464/chrome/browser/previews/previews_ui_tab_helper_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b22906d49b90614e336f29297f6513abcc5e807e

commit b22906d49b90614e336f29297f6513abcc5e807e
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Tue Oct 02 22:51:21 2018

Pass an actual URLLoaderFactory instance in chrome/browser/renderer_context_menu tests

InitDataReductionProxySettings constructs DataReductionProxyService, which later on
is provides data to DataReductionProxyIOData to construct DataReductionProxyConfig.
Ultimately, DataReductionProxyConfig constructs WarmupURLFetcher instances.

This CL is a preparation CL for [1], where we migrate WarmupURLFetcher from
URLFetcher to SimpleURLLoader. In [1], |url loader factory| is mandatory to be non-null.
Passing an actual instance at the beginning of the call chain now
has no immediate effect, but is harmless too.

[1] https://crrev.com/c/1251641

BUG= 879777 

Change-Id: I5165506e34e31b62a511d02b6e157f3554cc6594
Reviewed-on: https://chromium-review.googlesource.com/c/1256982
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#596022}
[modify] https://crrev.com/b22906d49b90614e336f29297f6513abcc5e807e/chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bfe499616657927ea46965083992f0d071a3111

commit 9bfe499616657927ea46965083992f0d071a3111
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Wed Oct 03 19:39:00 2018

Make URLRequest::proxy_server available through network::ResourceResponseInfo

This is a preparation CL for  bug 879777 , where
data_reduction_proxy::WarmupURLFetcher is being migrated away from
URLFetcher in favor of SimpleURLLoader.

WarmupURLFetcher unittests' correctness relies on checking whether
the appropriate net::ProxyServer instance is used.
This CL makes this information available through network::ResourceResponseInfo.

Note that, because it is a non-trivial c++ object, an specific IPC trait
was implemented, so that the object can be passed across mojo pipes.

BUG= 879777 

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I3728ba3173a23ad59dd3bf00877d7b1131944488
Reviewed-on: https://chromium-review.googlesource.com/c/1251642
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#596327}
[modify] https://crrev.com/9bfe499616657927ea46965083992f0d071a3111/services/network/network_context_unittest.cc
[modify] https://crrev.com/9bfe499616657927ea46965083992f0d071a3111/services/network/public/cpp/net_ipc_param_traits.cc
[modify] https://crrev.com/9bfe499616657927ea46965083992f0d071a3111/services/network/public/cpp/net_ipc_param_traits.h
[modify] https://crrev.com/9bfe499616657927ea46965083992f0d071a3111/services/network/public/cpp/network_ipc_param_traits.h
[modify] https://crrev.com/9bfe499616657927ea46965083992f0d071a3111/services/network/public/cpp/resource_response_info.h
[modify] https://crrev.com/9bfe499616657927ea46965083992f0d071a3111/services/network/url_loader.cc

Cc: cduvall@chromium.org
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d8fcd4caec30132336abfb44ba0426be5829ad2

commit 0d8fcd4caec30132336abfb44ba0426be5829ad2
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Fri Oct 05 15:15:14 2018

Migrate components/data_reduction_proxy/core/browser/warmup_url_fetcher.cc to using SimpleURLLoader

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates Android's WarmupURLFetcher and the
respective unittests away from URLFetcher.

Also, the CL relax an NOTREACHED scenario in TestSharedURLLoaderFactory,
now that some tests call ::Clone on it.

Bug:  879777 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I7b1664a141e409cc2cf43fe8a79eb771e9a9988b
Reviewed-on: https://chromium-review.googlesource.com/c/1251641
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597130}
[modify] https://crrev.com/0d8fcd4caec30132336abfb44ba0426be5829ad2/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc
[modify] https://crrev.com/0d8fcd4caec30132336abfb44ba0426be5829ad2/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc
[modify] https://crrev.com/0d8fcd4caec30132336abfb44ba0426be5829ad2/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/0d8fcd4caec30132336abfb44ba0426be5829ad2/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
[modify] https://crrev.com/0d8fcd4caec30132336abfb44ba0426be5829ad2/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/0d8fcd4caec30132336abfb44ba0426be5829ad2/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/0d8fcd4caec30132336abfb44ba0426be5829ad2/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h
[modify] https://crrev.com/0d8fcd4caec30132336abfb44ba0426be5829ad2/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc
[modify] https://crrev.com/0d8fcd4caec30132336abfb44ba0426be5829ad2/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h
[modify] https://crrev.com/0d8fcd4caec30132336abfb44ba0426be5829ad2/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
[modify] https://crrev.com/0d8fcd4caec30132336abfb44ba0426be5829ad2/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h
[modify] https://crrev.com/0d8fcd4caec30132336abfb44ba0426be5829ad2/components/data_reduction_proxy/core/browser/warmup_url_fetcher.cc
[modify] https://crrev.com/0d8fcd4caec30132336abfb44ba0426be5829ad2/components/data_reduction_proxy/core/browser/warmup_url_fetcher.h
[modify] https://crrev.com/0d8fcd4caec30132336abfb44ba0426be5829ad2/components/data_reduction_proxy/core/browser/warmup_url_fetcher_unittest.cc
[modify] https://crrev.com/0d8fcd4caec30132336abfb44ba0426be5829ad2/services/network/test/test_shared_url_loader_factory.cc

Status: Fixed (was: Started)
Blocking: 855620

Sign in to add a comment