New issue
Advanced search Search tips

Issue 879776 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 11
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Migrate components/offline_pages/core/prefetch/prefetch_request_fetcher.cc to using SimpleURLLoader

Project Member Reported by jam@chromium.org, Aug 31

Issue description

Blocks Android canary.
 
Owner: toniki...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e550f40c242e1b82630df90be057b76cf75b0870

commit e550f40c242e1b82630df90be057b76cf75b0870
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Mon Sep 10 20:41:45 2018

Migrate PrefetchRequestFetcher to using SimpleURLLoader

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates PrefetchRequestFetcher et al and the
respective unittests away from URLFetcher.

Bug: 773295, 879776 
Change-Id: Ibcfc2a7d72b6efe1b372233ade95b58d95fbf62b
Reviewed-on: https://chromium-review.googlesource.com/1215367
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#590048}
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/chrome/browser/offline_pages/prefetch/prefetch_service_factory.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/BUILD.gn
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/DEPS
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/generate_page_bundle_request.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/generate_page_bundle_request.h
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/generate_page_bundle_request_unittest.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/generate_page_bundle_task_unittest.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/get_operation_request.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/get_operation_request.h
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/get_operation_request_unittest.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/get_operation_task_unittest.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_dispatcher_impl_unittest.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_gcm_app_handler_unittest.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_network_request_factory_impl.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_network_request_factory_impl.h
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_network_request_factory_impl_unittest.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_request_fetcher.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_request_fetcher.h
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_request_fetcher_unittest.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_request_operation_response_unittest.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_request_test_base.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_request_test_base.h
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_task_test_base.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_task_test_base.h
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/suggested_articles_observer_unittest.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/test_prefetch_network_request_factory.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/test_prefetch_network_request_factory.h
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/task/task_test_base.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/task/task_test_base.h

Status: Fixed (was: Started)

Sign in to add a comment