New issue
Advanced search Search tips

Issue 879775 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Migrate ios/chrome/browser/ui/contextual_search/contextual_search_delegate.cc to using SimpleURLLoader

Project Member Reported by jam@chromium.org, Aug 31

Issue description

This isn't strictly needed since iOS will always use net-in-process, but is good for consistency with the rest of the code that ios shares with chrome that has switched to SimpleURLLoader.
 
 
Status: Available (was: Untriaged)
Components: Internals
Labels: -Type-Bug Type-Task
Owner: toniki...@chromium.org
Status: Started (was: Available)
This goes together with  issue #872875 .
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ddfc366a47b83c581018480c6adcc8176361e96

commit 4ddfc366a47b83c581018480c6adcc8176361e96
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Mon Sep 17 12:01:08 2018

[ios] Migrate ContextualSearchDelegate using SimpleURLLoader

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates iOS's ContextualSearchDelegate away from URLFetcher.

luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs

Bug: 773295, 879775 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I008a9070fe3131dcd1d21dfe8a48d0acea1e8f8d
Reviewed-on: https://chromium-review.googlesource.com/1225230
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#591646}
[modify] https://crrev.com/4ddfc366a47b83c581018480c6adcc8176361e96/ios/chrome/browser/ui/contextual_search/contextual_search_delegate.cc
[modify] https://crrev.com/4ddfc366a47b83c581018480c6adcc8176361e96/ios/chrome/browser/ui/contextual_search/contextual_search_delegate.h

Status: Fixed (was: Started)

Sign in to add a comment