New issue
Advanced search Search tips

Issue 879774 link

Starred by 2 users
Status: Fixed
Owner:
toniki...@chromium.org
Closed: Sep 18
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Migrate ios/chrome/browser/omaha/omaha_service.mm to using SimpleURLLoader

Project Member Reported by jam@chromium.org, Aug 31 
This isn't strictly needed since iOS will always use net-in-process, but is good for consistency with the rest of the code that ios shares with chrome that has switched to SimpleURLLoader.

Comment 1 by dougt@chromium.org, Aug 31

Status: Available (was: Untriaged)

Comment 2 by dougt@chromium.org, Aug 31

Labels: OS-iOS

Comment 3 by kkhorimoto@chromium.org, Sep 6

Components: Internals
Labels: -Type-Bug Type-Task

Comment 4 by toniki...@chromium.org, Sep 13

Owner: toniki...@igalia.com
Status: Started (was: Available)

Comment 5 by toniki...@chromium.org, Sep 13

Owner: toniki...@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f16cd8d36bf77f6a1e7a5043ed4073bdebeaba8

commit 1f16cd8d36bf77f6a1e7a5043ed4073bdebeaba8
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Tue Sep 18 12:11:18 2018

[ios] Migrate OmahaService to SimpleURLLoader

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates iOS' OmahaService and its respective
unittests away from URLFetcher.

BUG= 879774 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I60339c7599c6174951056c5a8b867aa6df1438da
Reviewed-on: https://chromium-review.googlesource.com/1227191
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#592006}
[modify] https://crrev.com/1f16cd8d36bf77f6a1e7a5043ed4073bdebeaba8/ios/chrome/app/startup_tasks.mm
[modify] https://crrev.com/1f16cd8d36bf77f6a1e7a5043ed4073bdebeaba8/ios/chrome/browser/omaha/BUILD.gn
[modify] https://crrev.com/1f16cd8d36bf77f6a1e7a5043ed4073bdebeaba8/ios/chrome/browser/omaha/omaha_service.h
[modify] https://crrev.com/1f16cd8d36bf77f6a1e7a5043ed4073bdebeaba8/ios/chrome/browser/omaha/omaha_service.mm
[modify] https://crrev.com/1f16cd8d36bf77f6a1e7a5043ed4073bdebeaba8/ios/chrome/browser/omaha/omaha_service_unittest.mm

Comment 7 by toniki...@chromium.org, Sep 18

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e701dcdc8c62818a32ac164d481354d1b6f601ae

commit e701dcdc8c62818a32ac164d481354d1b6f601ae
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Wed Sep 19 18:13:34 2018

fixup! [ios] Migrate OmahaService to SimpleURLLoader

Follow up of [1], that introduces TestURLLoaderFactory::GetPendingRequest.

TBR=droger@chromium.org

[1] https://crrev.com/c/1234133

BUG= 879774 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I234df7faf00625986e741a5bd3e1b52f34b7191e
Reviewed-on: https://chromium-review.googlesource.com/1234554
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#592477}
[modify] https://crrev.com/e701dcdc8c62818a32ac164d481354d1b6f601ae/ios/chrome/browser/omaha/omaha_service_unittest.mm
►

Sign in to add a comment