New issue
Advanced search Search tips

Issue 879771 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Migrate ios/web/webui/url_fetcher_block_adapter.mm to using SimpleURLLoader

Project Member Reported by jam@chromium.org, Aug 31

Issue description

This isn't strictly needed since iOS will always use net-in-process, but is good for consistency with the rest of the code that ios shares with chrome that has switched to SimpleURLLoader.
 
Status: Available (was: Untriaged)
Components: Internals
Labels: -Type-Bug Type-Task
Owner: toniki...@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf1ab83a5cf867d2431d6adaaf5db82bf81496cd

commit cf1ab83a5cf867d2431d6adaaf5db82bf81496cd
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Wed Sep 19 00:02:37 2018

[ios] Migrate URLFetcherBlockAdapter to using SimpleURLLoader

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates iOS' URLFetcherBlockAdapter and its respective
unittests away from URLFetcher.

BUG= 879771 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I3f99811c3bc6b3fdb136d448ec93e76d37ecfd1d
Reviewed-on: https://chromium-review.googlesource.com/1232073
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592272}
[modify] https://crrev.com/cf1ab83a5cf867d2431d6adaaf5db82bf81496cd/ios/web/BUILD.gn
[modify] https://crrev.com/cf1ab83a5cf867d2431d6adaaf5db82bf81496cd/ios/web/webui/crw_web_ui_manager.mm
[modify] https://crrev.com/cf1ab83a5cf867d2431d6adaaf5db82bf81496cd/ios/web/webui/crw_web_ui_manager_unittest.mm
[modify] https://crrev.com/cf1ab83a5cf867d2431d6adaaf5db82bf81496cd/ios/web/webui/url_fetcher_block_adapter.h
[modify] https://crrev.com/cf1ab83a5cf867d2431d6adaaf5db82bf81496cd/ios/web/webui/url_fetcher_block_adapter.mm
[modify] https://crrev.com/cf1ab83a5cf867d2431d6adaaf5db82bf81496cd/ios/web/webui/url_fetcher_block_adapter_unittest.mm

Status: Fixed (was: Started)

Sign in to add a comment