New issue
Advanced search Search tips

Issue 879770 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Migrate ios/chrome/browser/net/retryable_url_fetcher.mm using SimpleURLLoader

Project Member Reported by jam@chromium.org, Aug 31

Issue description

This isn't strictly needed since iOS will always use net-in-process, but is good for consistency with the rest of the code that ios shares with chrome that has switched to SimpleURLLoader.
 
Status: Available (was: Untriaged)
Components: Internals
Labels: -Type-Bug Type-Task
I'd like to take this one, but I can't change the status/owner to assign it to myself. Maybe I need to get special permissions?
Owner: ma...@igalia.com
Status: Started (was: Available)
Taking this (thanks for the editbugs permissions)
Tentative patch ready for review here:
https://chromium-review.googlesource.com/c/chromium/src/+/1235722/
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efc95f7499abbeaf2dd8697a3bcadf1ba4158dab

commit efc95f7499abbeaf2dd8697a3bcadf1ba4158dab
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Fri Sep 21 13:51:08 2018

Migrate ios/chrome/browser/net/retryable_url_fetcher.mm using SimpleURLLoader

This isn't strictly needed since iOS will always use net-in-process, but is
good for consistency with the rest of the code that ios shares with chrome
that has switched to SimpleURLLoader.

Bug:  879770 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I49665d4b6054c1a882a42d4661f03162bfceebc7
Reviewed-on: https://chromium-review.googlesource.com/1235722
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#593169}
[modify] https://crrev.com/efc95f7499abbeaf2dd8697a3bcadf1ba4158dab/ios/chrome/browser/net/BUILD.gn
[modify] https://crrev.com/efc95f7499abbeaf2dd8697a3bcadf1ba4158dab/ios/chrome/browser/net/retryable_url_fetcher.h
[modify] https://crrev.com/efc95f7499abbeaf2dd8697a3bcadf1ba4158dab/ios/chrome/browser/net/retryable_url_fetcher.mm
[modify] https://crrev.com/efc95f7499abbeaf2dd8697a3bcadf1ba4158dab/ios/chrome/browser/net/retryable_url_fetcher_unittest.mm

Status: Fixed (was: Started)
Patch landed, resolving s fixed

Sign in to add a comment