New issue
Advanced search Search tips

Issue 879767 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Sep 6
Cc:
rtoy@chromium.org
robertma@chromium.org
hongchan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

[WPT] New failures introduced in external/wpt/webaudio by import https://crrev.com/c/1199936

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, Aug 31 
WPT import https://crrev.com/c/1199936 introduced new failures in external/wpt/webaudio:

List of new failures:
external/wpt/webaudio/the-audio-api/the-audioparam-interface/audioparam-setValueCurve-exceptions.html new failing tests: https://crrev.com/c/1199936/4/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audioparam-interface/audioparam-setValueCurve-exceptions-expected.txt

This import contains upstream changes from 490ffffbb1889dd4e0fff55b019ef3c316b7029b to 214201456566050d2c45db5e4806afe37f96b912:
Fix a test case and add more test cases for overlapping SetValueCurveAtTime.: https://github.com/web-platform-tests/wpt/commit/214201456566050d2c45db5e4806afe37f96b912 [affecting this directory]
Fix typo in audioparam-setValueCurve-exceptions.html.: https://github.com/web-platform-tests/wpt/commit/e4a0aa65f4e435a52fce48bd3f566b1749ae0150 [affecting this directory]
Add a test case for a negative curve duration in audioparam-exceptional-values.html.: https://github.com/web-platform-tests/wpt/commit/91e7172e72d5ebb58e1c710b0113598fe99cf931 [affecting this directory]
Move Autoplay feature policy tests to html dir: https://github.com/web-platform-tests/wpt/commit/6bde19a48d5c85d8cf7d4a0df51035be25d9da3c
[LayoutNG] Fix when 'vertical-align: top' is nested: https://github.com/web-platform-tests/wpt/commit/b81e490a7032404418b325277312884b07208ed3

Comment 1 by rtoy@chromium.org, Sep 4

Components: Blink>Layout
Adding Blink>Layout component for the LayoutNG test failure.

Comment 2 by rtoy@chromium.org, Sep 4

Components: -Blink>Layout
Owner: rtoy@chromium.org
Status: Assigned (was: Untriaged)
Oops. LayoutNG test doesn't cause a new failure. Remove component.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c5722acdb2d084cf210c9ba2940f8353943c136

commit 9c5722acdb2d084cf210c9ba2940f8353943c136
Author: Raymond Toy <rtoy@chromium.org>
Date: Wed Sep 05 23:39:10 2018

Fix cases where setValueCurveAtTime was not throwing errors

Catch more cases where we should throw errors if a new
setValueCurveAtTime overlaps an existing setValueCurveAtTime event.

Add some additional tests for more coverage.  Also, some of the
existing tests were using incorrect expected error types so fix them.

Remove test expectations file since we pass now.

Bug:  879767 
Test: the-audioparam-interface/audioparam-setValueCurve-exceptions.html
Change-Id: I14a7a7c9ab36955b7e084ca9148495860b661111
Reviewed-on: https://chromium-review.googlesource.com/1205719
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589059}
[delete] https://crrev.com/5e6e9bf248b3e26c0ea9e4f0511c8fcbefdb2656/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audioparam-interface/audioparam-setValueCurve-exceptions-expected.txt
[modify] https://crrev.com/9c5722acdb2d084cf210c9ba2940f8353943c136/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audioparam-interface/audioparam-setValueCurve-exceptions.html
[modify] https://crrev.com/9c5722acdb2d084cf210c9ba2940f8353943c136/third_party/blink/renderer/modules/webaudio/audio_param_timeline.cc

Comment 4 by rtoy@chromium.org, Sep 6

Status: Fixed (was: Assigned)
►

Sign in to add a comment