Don't Add Brotli Accept-Encoding header if it is already present |
||
Issue descriptionhttps://cs.chromium.org/chromium/src/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc?l=706&rcl=af7877a78f72c5089e81d2bddcebf763827b8b87 In some edge cases, it is possible to trigger this DCHECK because a server is advertising brotli encoding when we don't normally expect it to. We should instead: * remove the DCHECK and its comment * only add the brotli value to Accept-Encoding if it doesn't already exist. Potentially Useful: https://cs.chromium.org/chromium/src/net/http/http_util.cc?l=1093&rcl=af7877a78f72c5089e81d2bddcebf763827b8b87
,
Sep 4
Can I take a look this issue?
,
Sep 4
Sorry, this issue is already assigned.
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24038bb6a8ab3689e20101bd8ad49495e4906b47 commit 24038bb6a8ab3689e20101bd8ad49495e4906b47 Author: Jered Gray <jegray@google.com> Date: Mon Sep 10 20:02:51 2018 Don't add Brotli Accept-Encoding when already present It's possible for a server to advertise brotli encoding when it isn't normally expected to. In these cases, we were previously triggering a DCHECK and potentially adding a second Brotli Accept-Encoding. This has been changed so that the Brotli Accept-Encoding is now only added when it is not already present. Bug: 879762 Change-Id: I5f9bb8eeec0cc03ee4953cd8fdf7fd7c15a92067 Reviewed-on: https://chromium-review.googlesource.com/1200386 Commit-Queue: Jered Gray <jegray@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#590031} [modify] https://crrev.com/24038bb6a8ab3689e20101bd8ad49495e4906b47/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc [modify] https://crrev.com/24038bb6a8ab3689e20101bd8ad49495e4906b47/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
,
Sep 19
|
||
►
Sign in to add a comment |
||
Comment 1 by robertogden@chromium.org
, Aug 31