New issue
Advanced search Search tips

Issue 879757 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: Sep 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.content.browser.InterstitialPageTest#testCloseInterstitial" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 31

Issue description

"org.chromium.content.browser.InterstitialPageTest#testCloseInterstitial" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 5 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUgsSBUZsYWtlIkdvcmcuY2hyb21pdW0uY29udGVudC5icm93c2VyLkludGVyc3RpdGlhbFBhZ2VUZXN0I3Rlc3RDbG9zZUludGVyc3RpdGlhbAw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
CL disabling the test is in CQ:
https://crrev.com/c/1200165
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c9c754fdfffd339955ce1e14984b1425499e747

commit 0c9c754fdfffd339955ce1e14984b1425499e747
Author: Oksana Zhuravlova <oksamyt@chromium.org>
Date: Fri Aug 31 23:45:11 2018

Mark InterstitialPageTest#testCloseInterstitial as flaky

Bug:  879757 

Change-Id: Ib8fbd95f086d95fc0f1ac00526059a7383e2ca24

TBR=boliu@chromium.org

Change-Id: Ib8fbd95f086d95fc0f1ac00526059a7383e2ca24
Reviewed-on: https://chromium-review.googlesource.com/1200165
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588214}
[modify] https://crrev.com/0c9c754fdfffd339955ce1e14984b1425499e747/content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java

Cc: tedc...@chromium.org dtrainor@chromium.org jinsuk...@chromium.org yfried...@chromium.org
Labels: -Sheriff-Chromium OS-Android
Owner: boliu@chromium.org
Status: Assigned (was: Untriaged)
Labels: Sheriff-Chromium
Detected 4 new flakes for test/step "org.chromium.content.browser.InterstitialPageTest#testCloseInterstitial". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUgsSBUZsYWtlIkdvcmcuY2hyb21pdW0uY29udGVudC5icm93c2VyLkludGVyc3RpdGlhbFBhZ2VUZXN0I3Rlc3RDbG9zZUludGVyc3RpdGlhbAw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
Test is still flaky, crashing frequently on Marshmallow: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_shell_test_apk&tests=org.chromium.content.browser.InterstitialPageTest%23testCloseInterstitial.

Since test is already marked as flaky (r588214), I will remove the Sheriff label again.
Null pointer exception with this stack:
  00000000021c98e4  content::RenderWidgetHostInputEventRouter::SetMouseCaptureTarget(content::RenderWidgetHostViewBase*, bool)                                                                                                                                                                                                                                                                                                                                                                                                                                                    ??:0:0
  000000000299b3fc  content::mojom::WidgetInputHandlerHostStubDispatch::Accept(content::mojom::WidgetInputHandlerHost*, mojo::Message*)                                                                                                                                                                                                                                                                                                                                                                                                                                           ??:0:0
  0000000003aa3800  mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                         ??:0:0
  0000000003aa34f0  mojo::FilterChain::Accept(mojo::Message*)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     ??:0:0
  0000000003aa454c  mojo::InterfaceEndpointClient::HandleIncomingMessage(mojo::Message*)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          ??:0:0
  0000000003aa7608  mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*)                                                                                                                                                                                                                                                                                                                                                                    ??:0:0
  0000000003aa71b8  mojo::internal::MultiplexRouter::Accept(mojo::Message*)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       ??:0:0
  0000000003aa34f0  mojo::FilterChain::Accept(mojo::Message*)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     ??:0:0
  0000000003aa07d4  mojo::Connector::ReadSingleMessage(unsigned int*)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             ??:0:0
  0000000003aa0eb8  mojo::Connector::ReadAllAvailableMessages()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                   ??:0:0
  0000000003aa0d3c  mojo::Connector::OnHandleReadyInternal(unsigned int)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          ??:0:0
  0000000001e9e830  void base::internal::Invoker<base::internal::BindState<void (content::AppCacheQuotaClient::*)(int), base::internal::UnretainedWrapper<content::AppCacheQuotaClient> >, void (int)>::RunImpl<void (content::AppCacheQuotaClient::* const&)(int), std::__ndk1::tuple<base::internal::UnretainedWrapper<content::AppCacheQuotaClient> > const&, 0ul>(void (content::AppCacheQuotaClient::* const&)(int), std::__ndk1::tuple<base::internal::UnretainedWrapper<content::AppCacheQuotaClient> > const&, std::__ndk1::integer_sequence<unsigned long, 0ul>, int&&)  ??:0:0
  0000000001e9e804  base::internal::Invoker<base::internal::BindState<void (content::AppCacheQuotaClient::*)(int), base::internal::UnretainedWrapper<content::AppCacheQuotaClient> >, void (int)>::Run(base::internal::BindStateBase*, int)                                                                                                                                                                                                                                                                                                                                       ??:0:0
  0000000003a99088  mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&)                                                                                                                                                                                                                                                                                                                                                                                                                                                                        ??:0:0
  000000000397c4e0  base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          ??:0:0
  0000000003995fcc  base::MessageLoop::RunTask(base::PendingTask*)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                ??:0:0
  0000000003996304  base::MessageLoop::DoWork()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                   ??:0:0
  000000000399951c  base::MessagePumpForUI::OnNonDelayedLooperCallback()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          ??:0:0
  00000000039991ac  base::(anonymous namespace)::NonDelayedLooperCallback(int, int, void*)    
Already fixed here: crbug.com/880203

I'll just enable.
Mergedinto: 880203
Status: Duplicate (was: Assigned)
In cq: https://chromium-review.googlesource.com/c/chromium/src/+/1211960
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56bebe81d8da04fe54043020e790a22e373df699

commit 56bebe81d8da04fe54043020e790a22e373df699
Author: Bo <boliu@chromium.org>
Date: Thu Sep 06 22:54:37 2018

Revert "Mark InterstitialPageTest#testCloseInterstitial as flaky"

This reverts commit 0c9c754fdfffd339955ce1e14984b1425499e747.

Reason for revert: Underlying issue (crbug.com/880203) is fixed.

Original change's description:
> Mark InterstitialPageTest#testCloseInterstitial as flaky
> 
> Bug:  879757 
> 
> Change-Id: Ib8fbd95f086d95fc0f1ac00526059a7383e2ca24
> 
> TBR=boliu@chromium.org
> 
> Change-Id: Ib8fbd95f086d95fc0f1ac00526059a7383e2ca24
> Reviewed-on: https://chromium-review.googlesource.com/1200165
> Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#588214}

TBR=boliu@chromium.org,oksamyt@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  879757 
Change-Id: I6c31bda83ad0a72c76fcb4054b14343478f7683f
Reviewed-on: https://chromium-review.googlesource.com/1211960
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589352}
[modify] https://crrev.com/56bebe81d8da04fe54043020e790a22e373df699/content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java

Sign in to add a comment