New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 879746 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocked on:
issue 846423

Blocking:
issue 878465



Sign in to add a comment

Resolve ".local" TLDs from WebRTC using mDNS in Chromium

Project Member Reported by zstein@chromium.org, Aug 31

Issue description

WebRTC needs to be able to resolve ".local" TLDs using mDNS for  crbug.com/878465 .
 
Blocking: 878465
Summary: Resolve ".local" TLDs from WebRTC using mDNS in Chromium (was: Resolve ".local" TLDs from WebRTC using mDNS)
Notes: https://docs.google.com/document/d/1SIKd6R-v0gXgSL-UmC_t_zCvyY3Hd-7C52SbLJxAxQI/edit#heading=h.kqj44lz4njsp

The plan is to migrate P2PSocketManager::GetHostAddress to use the new HostResolver::CreateRequest method and then set ResolveHostParameters.source to MULTICAST_DNS (once it is implemented) when the host name ends with ".local."
Blockedon: 846423
Status: Started (was: Untriaged)
Blocked on MDNS support in HostResolver via HostResolverSource (https://cs.chromium.org/chromium/src/net/dns/host_resolver_source.h?q=846423&sq=package:chromium&g=0&l=10).

Let me know if there is a more specific bug to track.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de5059db59ef0c9896ce918f226b3ab1db8658c5

commit de5059db59ef0c9896ce918f226b3ab1db8658c5
Author: Zach Stein <zstein@chromium.org>
Date: Thu Sep 06 04:29:56 2018

Migrate P2PSocketManager::GetHostAddress to use the new HostResolver API.

This will enable us to issue MDNS queries for .local TLDs once HostResolver
supports MDNS.

Bug:  chromium:879746 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I4c5a8e01c2337f83a73ac3f6ecc6d3527bdcd875
Reviewed-on: https://chromium-review.googlesource.com/1200404
Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Zach Stein <zstein@google.com>
Cr-Commit-Position: refs/heads/master@{#589099}
[modify] https://crrev.com/de5059db59ef0c9896ce918f226b3ab1db8658c5/services/network/p2p/socket_manager.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7562ea9e8862fe435354d08c2422a3597efc7a79

commit 7562ea9e8862fe435354d08c2422a3597efc7a79
Author: Zach Stein <zstein@chromium.org>
Date: Mon Oct 29 07:24:35 2018

Resolve hostname in P2PSocketManager with MDNS if the TLD is "local"

Bug:  chromium:879746 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Iabd87f6e3aad8ed689d255329310a48a7a02f323
Reviewed-on: https://chromium-review.googlesource.com/c/1217346
Commit-Queue: Zach Stein <zstein@google.com>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603430}
[modify] https://crrev.com/7562ea9e8862fe435354d08c2422a3597efc7a79/services/network/p2p/socket_manager.cc

Status: Fixed (was: Started)

Sign in to add a comment