New issue
Advanced search Search tips

Issue 879728 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

WPT tools roll seems to have broken two .serviceworker. tests

Project Member Reported by jbudorick@chromium.org, Aug 31

Issue description

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a26ac49044f9fc80594579c25465606853795dde

commit a26ac49044f9fc80594579c25465606853795dde
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Aug 31 21:43:33 2018

Mark two .serviceworker. tests as flaky.

TBR=foolip@chromium.org,robertma@chromium.org

Bug:  879728 
Change-Id: I961914c7ccffa3842d2a27ee489611278e88f01c
Reviewed-on: https://chromium-review.googlesource.com/1199968
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588180}
[modify] https://crrev.com/a26ac49044f9fc80594579c25465606853795dde/third_party/WebKit/LayoutTests/TestExpectations

Components: Blink>Infra>Ecosystem
Owner: foolip@chromium.org
Status: Assigned (was: Untriaged)
Labels: -Sheriff-Chromium
Owner: robertma@chromium.org
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/chromium/src/+/1214106
Thanks Robert!!
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28bfd8c8ebc6c96fba6689c0c8050b47ccc5961e

commit 28bfd8c8ebc6c96fba6689c0c8050b47ccc5961e
Author: Robert Ma <robertma@chromium.org>
Date: Sat Sep 08 13:58:38 2018

Unskip two idlharness tests

There was a short period of time after we rolled in the new version of
WPT tools (r588057) when these two tests were missing baselines (likely
due to race between test changes and the roll). Now that the baselinse
have been created by the importer, the two tests should no longer fail.

Bug:  879728 
Change-Id: Ide735b5dcf3538642187b0646c5459bb0442b03b
Reviewed-on: https://chromium-review.googlesource.com/1214106
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589780}
[modify] https://crrev.com/28bfd8c8ebc6c96fba6689c0c8050b47ccc5961e/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Started)

Sign in to add a comment