New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 879726 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Findit's revert conflicts with a fix

Project Member Reported by chanli@chromium.org, Aug 31

Issue description

The revert: https://chromium-review.googlesource.com/c/chromium/src/+/1196027

What happened:
- CL 1194067 breaks a test
- A fix of the failed test at 1194509 was landed, though no new build yet to pick up this fix
- Findit found the culprit and reverted it at 1196027, because it's not able to find the fix:
  * Fix doesn't depend on the culprit
  * Fix was on the test file which was not included in the culprit
  * There was no new build to pick up the fix yet
- The fix and Findit's revert conflicted and broke compile

Possible solution for this is to run a try job with the revert to check if 1. revert is correct 2. revert doesn't conflict with other changes.


 
But this case seems to be quite rare and unfortunate. 

I'll keep this bug open and collect similar cases in the future. If this kind of cases happen more in the future, we may need to implement the solution to solve it.

Sign in to add a comment