New issue
Advanced search Search tips

Issue 879705 link

Starred by 1 user
Status: Fixed
Owner:
jianli@chromium.org
Closed: Sep 7
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Offline indicator should not be shown when the page is still being loaded

Project Member Reported by jianli@chromium.org, Aug 31 
Steps:
(1) Load a slow page
(2) Disconnect the network while it is still being loaded

Observe that the offline indicator is shown. Per the spec, the offline indicator should not be shown at this time.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/040c9b95be1c6ed3d1852515b227fe18ddb64142

commit 040c9b95be1c6ed3d1852515b227fe18ddb64142
Author: Jian Li <jianli@chromium.org>
Date: Sat Sep 01 00:36:38 2018

Fix a couple problems with showing offline indicator UI

1) Do not show offline indicator UI on offline page
2) If the page is still being loaded, wait until it is done and
   then decide whether to show offline indicator UI.

Bug:  879705 
Change-Id: I31f3df33ca19544b846e8cb60d2d1bc87c9b2439
Reviewed-on: https://chromium-review.googlesource.com/1138987
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588231}
[modify] https://crrev.com/040c9b95be1c6ed3d1852515b227fe18ddb64142/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/ConnectivityDetector.java
[modify] https://crrev.com/040c9b95be1c6ed3d1852515b227fe18ddb64142/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorController.java
[modify] https://crrev.com/040c9b95be1c6ed3d1852515b227fe18ddb64142/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorControllerTest.java

Comment 2 by jianli@chromium.org, Sep 6

Labels: Merge-Request-70 M-70
Verified in Canary 71.0.3544.0

Comment 3 by benmason@chromium.org, Sep 7

Labels: -Merge-Request-70 Merge-Approved-70

Comment 4 by benmason@chromium.org, Sep 7 

Approved for merge into 70, branch 3538.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 7

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5470b3c20c179f1b7782291686e38e6795edd4e

commit a5470b3c20c179f1b7782291686e38e6795edd4e
Author: Jian Li <jianli@chromium.org>
Date: Fri Sep 07 20:24:30 2018

Merge M70: Fix a couple problems with showing offline indicator UI

1) Do not show offline indicator UI on offline page
2) If the page is still being loaded, wait until it is done and
   then decide whether to show offline indicator UI.

TBR=jianli@chromium.org

(cherry picked from commit 040c9b95be1c6ed3d1852515b227fe18ddb64142)

Bug:  879705 
Change-Id: I31f3df33ca19544b846e8cb60d2d1bc87c9b2439
Reviewed-on: https://chromium-review.googlesource.com/1138987
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588231}
Reviewed-on: https://chromium-review.googlesource.com/1214164
Reviewed-by: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#154}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/a5470b3c20c179f1b7782291686e38e6795edd4e/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/ConnectivityDetector.java
[modify] https://crrev.com/a5470b3c20c179f1b7782291686e38e6795edd4e/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorController.java
[modify] https://crrev.com/a5470b3c20c179f1b7782291686e38e6795edd4e/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorControllerTest.java

Comment 6 by jianli@chromium.org, Sep 7

Status: Fixed (was: Started)
►

Sign in to add a comment