New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 879704 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until 2019-01-24
Closed: Sep 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature
Proj-VR
Proj-XR
Proj-XR-VR

Blocked on:
issue 859952
issue 861920



Sign in to add a comment

Set up trybot mirroring "Nougat Phone Tester"

Project Member Reported by kbr@chromium.org, Aug 31

Issue description

In Issue 861920 two VMs were provisioned for running tryjobs against a configuration similar to "Nougat Phone Tester":
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Nougat%20Phone%20Tester

in order to manually run the VR tests against code changes.

These should be set up into a new trybot.

 
Cc: jbudorick@chromium.org
Status: Started (was: Assigned)
The new trybot will be called "try-nougat-phone-tester" in similar naming convention to the "gpu-manual-try-" trybots, but a bit less verbose.

Blockedon: 861920 859952
I suspect we'll wind up renaming both CI and try here -- I know you're partial to including try- in the name, but we've tried to avoid that beyond GPU in favor of having the names match.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/dce17d71fe3e6e5bd0f96984cde74233f4588324

commit dce17d71fe3e6e5bd0f96984cde74233f4588324
Author: Kenneth Russell <kbr@google.com>
Date: Fri Aug 31 20:52:29 2018

Fair enough. Once the new CI and trybot naming convention is decided upon, happy to rename all of these. (It looks like the names of CI and trybots don't currently match.)

Indeed; we've tried to do so w/ newer bots (and a few older bots), but we are far away from getting everything renamed, and I wouldn't want to name the trybot "Nougat Phone Tester" here.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68389b5021f30962b4ced4190bbe7f8395ac4949

commit 68389b5021f30962b4ced4190bbe7f8395ac4949
Author: Kenneth Russell <kbr@chromium.org>
Date: Fri Aug 31 23:30:26 2018

Add infra configs for "try-nougat-phone-tester" trybot.

Bug:  879704 
No-Try: True
Change-Id: I454192e7c0cde3883bfe43e76029727b4924bfc1
Reviewed-on: https://chromium-review.googlesource.com/1200312
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588208}
[modify] https://crrev.com/68389b5021f30962b4ced4190bbe7f8395ac4949/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/68389b5021f30962b4ced4190bbe7f8395ac4949/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/68389b5021f30962b4ced4190bbe7f8395ac4949/tools/mb/mb_config.pyl

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/2ac56474e54925153b9597be1af3f285b09c29a5

commit 2ac56474e54925153b9597be1af3f285b09c29a5
Author: Kenneth Russell <kbr@chromium.org>
Date: Fri Aug 31 23:43:10 2018

Add recipes for "try-nougat-phone-tester" trybot.

Bug:  879704 
Change-Id: I7e53010992ea9b3eabb6123642e183c6da9b09d8
Reviewed-on: https://chromium-review.googlesource.com/1200284
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

[modify] https://crrev.com/2ac56474e54925153b9597be1af3f285b09c29a5/tests/masters_recipes_test.py
[modify] https://crrev.com/2ac56474e54925153b9597be1af3f285b09c29a5/scripts/slave/recipe_modules/chromium_tests/trybots.py

My initial guess is that any VR tests in that run will fail. Whatever is isolating the tests for swarming needs to have the DOWNLOAD_VR_TEST_APKS environment variable set when running "gclient runhooks" in order to get the APKs necessary for VR tests (we got complaints about unconditionally downloading them when they were initially added, so we had to move them behind the environment variable).
Nevermind, looks like that's never been set in the bot_update step. Since it's cloning the arm64 builder, everything should be taken care of.
Status: Fixed (was: Started)
The first tryjob passed the following steps which it ran:

chrome_public_test_vr_apk-ddready-cardboard on Android device Pixel 1 XL (with patch)
chrome_public_test_vr_apk-ddready-dynamicsettings on Android device Pixel 1 XL (with patch)

It failed the following step:

chrome_public_test_vr_apk-ddready-ddview on Android device Pixel 1 XL (with patch)
https://chromium-swarm.appspot.com/task?id=3fabbd157a362910&refresh=10&show_raw=1

apparently because the device that was being tested went offline during the test.

It might be necessary to increase the timeouts on both the waterfall bots and this trybot in order to handle tryjobs that come in on it. That can be done if it looks like the bot is not reliable. For now closing this as fixed.

Sign in to add a comment