CQ not commiting a patch it's ready to commit |
||||||
Issue descriptionhttps://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/1199867/2 is the CQ status page If you look at the raw CQ logs, it seems ready to commit the CL very quickly, but then just sits there and doesn't commit it for a long time. I ended up manually submitting the change, since it was NOTRY-ed anyways.
,
Aug 31
The graphs above are for chromium repo, but this CL is for chromium/tools/build.
,
Aug 31
There were no other CLs in committer thread of build at the same time. So, for whatever reason this CL didn't end up in read_queue, despite messages sent to CQ status app.
,
Aug 31
Oh, this is a fun race: CQ uses CL number as a key when checking which CLs to be removed from queue and which to add. Turns out you've triggered CQ twice -- on PS#1, which CQ actually tried to submit, but failed because you added bug number to description. Then CQ detected PS#2, but didn't actually prune commit ready queue from #PS1 somehow.
,
Aug 31
Yep, both "queues" (not really FIFO, more like sets) inside CQ use dict as underlying storage and index by issue number only. I'm very surprised this wasn't noticed before.
,
Sep 19
After improving CQ, it became obvious where bug is: when CQ notices new attempt of CL which is already being processed, it didn't wipe out item from both queues, only from one. https://chrome-internal-review.googlesource.com/c/infra/infra_internal/+/682130
,
Sep 19
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/46ae9a3a9c4bcbab9249ebe982c522d39b134da4 commit 46ae9a3a9c4bcbab9249ebe982c522d39b134da4 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed Sep 19 18:55:14 2018
,
Sep 20
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/f5b026f06b91d5b6ba7af5ac5d862d6e9acd8fdf commit f5b026f06b91d5b6ba7af5ac5d862d6e9acd8fdf Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu Sep 20 00:58:06 2018
,
Sep 20
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/664add687b9ad22e24e3338abcf6874809f089cd commit 664add687b9ad22e24e3338abcf6874809f089cd Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu Sep 20 01:16:04 2018
,
Sep 20
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/0d5e5ffa4e5a699acd268e6ec733850619eb4088 commit 0d5e5ffa4e5a699acd268e6ec733850619eb4088 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu Sep 20 01:24:15 2018
,
Sep 20
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/a0f800c3d71cc913c55c8dce3cb939d308b634cc commit a0f800c3d71cc913c55c8dce3cb939d308b634cc Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu Sep 20 02:04:32 2018
,
Sep 24
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/puppet/+/d0a52a93a6c617fdc01f630bda12fdc4d5817214 commit d0a52a93a6c617fdc01f630bda12fdc4d5817214 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Mon Sep 24 18:04:35 2018
,
Sep 24
Released. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tandrii@chromium.org
, Aug 31