New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 879677 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Suite control file timeout args are being ignored

Project Member Reported by mattmallett@chromium.org, Aug 31

Issue description

Running control.hardware_storagequal, which has a timeout defined in the control file of:

args_dict['timeout_mins'] = 40320 # entire suite timeout after 28 days
args_dict['max_runtime_mins'] = 40320 # one test timeout after 28 days

The suite was provisioned with a timeout and max_runtime displayed in AFE of 1440.

The suite timed out after 1440 minutes, 24 hours.

logs -> https://pantheon.corp.google.com/storage/browser/chromeos-moblab-peng-staging/results/G9MSCX000070/41705c4aabd511e886db5130859bd2e0/664-moblab/hostless/
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f888c5ff406732565ce3776f5060604637063619

commit f888c5ff406732565ce3776f5060604637063619
Author: Matt Mallett <mattmallett@chromium.org>
Date: Wed Sep 05 23:11:20 2018

[moblab] Set suite timeout in moblab_rpc_interface

Add a map of suite timeouts to the moblab_rpc_interface. Default
to 24 hours. This is to prevent the suite job from timing out
on long running tests. The suite job doesn't get its timeout
from the suite control file, rather from the create_suite_job
rpc call.

BUG= chromium:879677 
TEST=local moblab device

Change-Id: If8d89c46745bd15149ccbbee1025cdb4fa28cd72
Reviewed-on: https://chromium-review.googlesource.com/1205651
Commit-Ready: Matt Mallett <mattmallett@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/f888c5ff406732565ce3776f5060604637063619/frontend/afe/moblab_rpc_interface.py

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 5

Labels: merge-merged-release-R69-10895.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4b37fd5b4558aa64c054dcd2c291cbf9d6e0ab7d

commit 4b37fd5b4558aa64c054dcd2c291cbf9d6e0ab7d
Author: Matt Mallett <mattmallett@chromium.org>
Date: Wed Sep 05 23:58:33 2018

[moblab] Set suite timeout in moblab_rpc_interface

Add a map of suite timeouts to the moblab_rpc_interface. Default
to 24 hours. This is to prevent the suite job from timing out
on long running tests. The suite job doesn't get its timeout
from the suite control file, rather from the create_suite_job
rpc call.

BUG= chromium:879677 
TEST=local moblab device

Change-Id: If8d89c46745bd15149ccbbee1025cdb4fa28cd72
Reviewed-on: https://chromium-review.googlesource.com/1206192
Reviewed-by: Matt Mallett <mattmallett@chromium.org>
Commit-Queue: Matt Mallett <mattmallett@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Trybot-Ready: Matt Mallett <mattmallett@chromium.org>

[modify] https://crrev.com/4b37fd5b4558aa64c054dcd2c291cbf9d6e0ab7d/frontend/afe/moblab_rpc_interface.py

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 5

Labels: merge-merged-release-R70-11021.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4f211abe4748acd68641db2b7a8b8c7b186d81dd

commit 4f211abe4748acd68641db2b7a8b8c7b186d81dd
Author: Matt Mallett <mattmallett@chromium.org>
Date: Wed Sep 05 23:58:34 2018

[moblab] Set suite timeout in moblab_rpc_interface

Add a map of suite timeouts to the moblab_rpc_interface. Default
to 24 hours. This is to prevent the suite job from timing out
on long running tests. The suite job doesn't get its timeout
from the suite control file, rather from the create_suite_job
rpc call.

BUG= chromium:879677 
TEST=local moblab device

Change-Id: If8d89c46745bd15149ccbbee1025cdb4fa28cd72
Reviewed-on: https://chromium-review.googlesource.com/1206193
Reviewed-by: Matt Mallett <mattmallett@chromium.org>
Commit-Queue: Matt Mallett <mattmallett@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Trybot-Ready: Matt Mallett <mattmallett@chromium.org>

[modify] https://crrev.com/4f211abe4748acd68641db2b7a8b8c7b186d81dd/frontend/afe/moblab_rpc_interface.py

Status: fixed (was: Started)

Sign in to add a comment