New issue
Advanced search Search tips

Issue 879660 link

Starred by 1 user
Status: Fixed
Owner:
siggi@chromium.org
Closed: Sep 20
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Polymerize chrome://discards page

Project Member Reported by siggi@chromium.org, Aug 31 
It looks like Polymer would simplimaficate the implementation of the page, as it provides easy-to use data binding mechanisms. Maybe it could even look less ugly.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93411b8c6fd272677daa64ae18a19ccdb12f9e65

commit 93411b8c6fd272677daa64ae18a19ccdb12f9e65
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Tue Sep 18 19:55:54 2018

Polymerization of chrome://discards UI.

Convert the imperative implementation to all-declarative polymer
(for the most part). Add closure_compile build configuration and fix the
problems it showed up.
This change should be a no-op in terms of the UI presented.

Bug:  879660 

Change-Id: I60d607f1b556a5a2a31f7cb776abb1ff6db38660
Reviewed-on: https://chromium-review.googlesource.com/1210385
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592160}
[modify] https://crrev.com/93411b8c6fd272677daa64ae18a19ccdb12f9e65/chrome/browser/browser_resources.grd
[modify] https://crrev.com/93411b8c6fd272677daa64ae18a19ccdb12f9e65/chrome/browser/resources/BUILD.gn
[add] https://crrev.com/93411b8c6fd272677daa64ae18a19ccdb12f9e65/chrome/browser/resources/discards/BUILD.gn
[modify] https://crrev.com/93411b8c6fd272677daa64ae18a19ccdb12f9e65/chrome/browser/resources/discards/database_tab.html
[add] https://crrev.com/93411b8c6fd272677daa64ae18a19ccdb12f9e65/chrome/browser/resources/discards/database_tab.js
[delete] https://crrev.com/f0e2d8fa2846414cec70d9223a7d09e951fd19ef/chrome/browser/resources/discards/discards.css
[modify] https://crrev.com/93411b8c6fd272677daa64ae18a19ccdb12f9e65/chrome/browser/resources/discards/discards.html
[modify] https://crrev.com/93411b8c6fd272677daa64ae18a19ccdb12f9e65/chrome/browser/resources/discards/discards.js
[add] https://crrev.com/93411b8c6fd272677daa64ae18a19ccdb12f9e65/chrome/browser/resources/discards/discards_main.html
[add] https://crrev.com/93411b8c6fd272677daa64ae18a19ccdb12f9e65/chrome/browser/resources/discards/discards_main.js
[modify] https://crrev.com/93411b8c6fd272677daa64ae18a19ccdb12f9e65/chrome/browser/resources/discards/discards_tab.html
[add] https://crrev.com/93411b8c6fd272677daa64ae18a19ccdb12f9e65/chrome/browser/resources/discards/discards_tab.js
[modify] https://crrev.com/93411b8c6fd272677daa64ae18a19ccdb12f9e65/chrome/browser/ui/webui/discards/discards_ui.cc

Comment 2 by siggi@chromium.org, Sep 19 

Imma call this done.

Comment 3 by siggi@chromium.org, Sep 20

Status: Fixed (was: Assigned)
I could have sworn I tagged this fixed already.
►

Sign in to add a comment